starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

PGO has been "at a farm upstate" since VS 2022 #17928

New Issue
Closed
opened 2026-01-31 05:58:47 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 05:58:47 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Jul 13, 2022).

image

There are only five commits in that range, and not one of them might explain what is happening better than the VS 2022 one.

Originally created by @DHowett on GitHub (Jul 13, 2022). <img width="1049" alt="image" src="https://user-images.githubusercontent.com/189190/178838290-8754633e-bbf6-400d-9371-533a9416f0e3.png"> There are only five commits in that range, and not one of them might explain what is happening better than the VS 2022 one.
claunia added the Needs-TriageResolution-Fix-CommittedNeeds-Tag-Fix labels 2026-01-31 05:58:47 +00:00
claunia commented 2026-01-31 05:58:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 13, 2022):

Fortunately Helix gives us dumps

and this one looks like "I couldn't load TerminalApp.dll, yo"

0b 00000018`9ff5f450 00007ff6`bff0e91d     WindowsTerminal!winrt::throw_hresult+0x3ba [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 4946] 
0c 00000018`9ff5f4b0 00007ff6`bff0ebbe     WindowsTerminal!winrt::check_hresult+0x2d [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 5016] 
0d 00000018`9ff5f4f0 00007ff6`bff30f9e     WindowsTerminal!winrt::get_activation_factory<winrt::Windows::Foundation::IActivationFactory>+0x7e [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6039] 
0e 00000018`9ff5f550 00007ff6`bff232fb     WindowsTerminal!winrt::impl::factory_cache_entry<winrt::TerminalApp::App,winrt::Windows::Foundation::IActivationFactory>::call<winrt::TerminalApp::App (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &)>+0x9e [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6266] 
0f 00000018`9ff5f600 00007ff6`bff24aa9     WindowsTerminal!winrt::impl::call_factory_cast<winrt::TerminalApp::App (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &),winrt::TerminalApp::App,winrt::Windows::Foundation::IActivationFactory,`winrt::TerminalApp::App::App'::`1'::<lambda_164_> >+0xab [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6325] 
10 00000018`9ff5f640 00007ff6`bff34f73     WindowsTerminal!winrt::TerminalApp::App::App+0x39 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\TerminalApp.h @ 6090] 
11 00000018`9ff5f680 00007ff6`bff2e913     WindowsTerminal!AppHost::AppHost+0x63 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\AppHost.cpp @ 32] 
12 00000018`9ff5f760 00007ff6`bff27fe2     WindowsTerminal!wWinMain+0x183 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\main.cpp @ 139]
@DHowett commented on GitHub (Jul 13, 2022): Fortunately Helix gives us dumps and this one looks like "I couldn't load TerminalApp.dll, yo" ``` 0b 00000018`9ff5f450 00007ff6`bff0e91d WindowsTerminal!winrt::throw_hresult+0x3ba [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 4946] 0c 00000018`9ff5f4b0 00007ff6`bff0ebbe WindowsTerminal!winrt::check_hresult+0x2d [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 5016] 0d 00000018`9ff5f4f0 00007ff6`bff30f9e WindowsTerminal!winrt::get_activation_factory<winrt::Windows::Foundation::IActivationFactory>+0x7e [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6039] 0e 00000018`9ff5f550 00007ff6`bff232fb WindowsTerminal!winrt::impl::factory_cache_entry<winrt::TerminalApp::App,winrt::Windows::Foundation::IActivationFactory>::call<winrt::TerminalApp::App (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &)>+0x9e [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6266] 0f 00000018`9ff5f600 00007ff6`bff24aa9 WindowsTerminal!winrt::impl::call_factory_cast<winrt::TerminalApp::App (__cdecl*)(winrt::Windows::Foundation::IActivationFactory const &),winrt::TerminalApp::App,winrt::Windows::Foundation::IActivationFactory,`winrt::TerminalApp::App::App'::`1'::<lambda_164_> >+0xab [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\base.h @ 6325] 10 00000018`9ff5f640 00007ff6`bff34f73 WindowsTerminal!winrt::TerminalApp::App::App+0x39 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\Generated Files\winrt\TerminalApp.h @ 6090] 11 00000018`9ff5f680 00007ff6`bff2e913 WindowsTerminal!AppHost::AppHost+0x63 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\AppHost.cpp @ 32] 12 00000018`9ff5f760 00007ff6`bff27fe2 WindowsTerminal!wWinMain+0x183 [C:\a\_work\1\s\src\cascadia\WindowsTerminal\main.cpp @ 139] ```
claunia commented 2026-01-31 05:58:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 13, 2022):

It loads properly on Windows 11 SV2...

Time to unearth the Vb VM

@DHowett commented on GitHub (Jul 13, 2022): It loads properly on Windows 11 SV2... Time to unearth the Vb VM
claunia commented 2026-01-31 05:58:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 13, 2022):

It... doesn't fail on the VB VM. Oh man.

@DHowett commented on GitHub (Jul 13, 2022): It... doesn't fail on the VB VM. Oh man.
claunia commented 2026-01-31 05:58:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 13, 2022):

I'm guessing that the Helix machines have an old version of the VC++ redist that is missing msvcp140_atomic_wait.dll

@DHowett commented on GitHub (Jul 13, 2022): I'm guessing that the Helix machines have an old version of the VC++ redist that is missing `msvcp140_atomic_wait.dll`
claunia commented 2026-01-31 05:58:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 13, 2022):

https://microsoft.visualstudio.com/Dart/_build/results?buildId=52437427&view=results

@DHowett commented on GitHub (Jul 13, 2022): https://microsoft.visualstudio.com/Dart/_build/results?buildId=52437427&view=results
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17928
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?