starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bad code in src/terminal/parser/ft_fuzzer/fuzzing_directed.h #17929

New Issue
Closed
opened 2026-01-31 05:58:51 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:58:51 +00:00
Owner
Copy Link

Originally created by @JonCavesMSFT on GitHub (Jul 14, 2022).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

The code in question is on line 965:

return (this->m_fFuzzed) ? &(this->m_t) : &CFuzzType<_Type, _Args...>::m_tInit;

The Visual C++ compiler is correctly rejecting this code for two reasons: 1) the non-static data member 'm_tInit' is protected so the attempt to create the pointer-to-member will fail; and 2) even if it succeeds there is no way the compiler can bring the types associated with the left and right expressions of the ':' operator to a common type. I suspect that the code should be:

return (this->m_fFuzzed) ? &(this->m_t) : &(this->m_tInit);

Thanks
JonCaves

Expected Behavior

No response

Actual Behavior

The code fails to compile with a recent build of the Visual C++ compiler

Originally created by @JonCavesMSFT on GitHub (Jul 14, 2022). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce The code in question is on line 965: `return (this->m_fFuzzed) ? &(this->m_t) : &CFuzzType<_Type, _Args...>::m_tInit;` The Visual C++ compiler is correctly rejecting this code for two reasons: 1) the non-static data member '`m_tInit`' is protected so the attempt to create the pointer-to-member will fail; and 2) even if it succeeds there is no way the compiler can bring the types associated with the left and right expressions of the '`:`' operator to a common type. I suspect that the code should be: `return (this->m_fFuzzed) ? &(this->m_t) : &(this->m_tInit);` Thanks JonCaves ### Expected Behavior _No response_ ### Actual Behavior The code fails to compile with a recent build of the Visual C++ compiler
claunia commented 2026-01-31 05:58:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 14, 2022):

What version of the tools are you using? This seems to compile fine with VS 17.3.0 Preview 2.0...

Most of https://github.com/microsoft/terminal/blob/main/src/terminal/parser/ft_fuzzer/fuzzing_directed.h has been unchanged since we went open source, but INTERESTINGLY, that specific line was changed in #11816. In that PR, it was changed from what you suggest here to the current code. Link:https://github.com/microsoft/terminal/pull/11816/files#diff-5fbf1a284c85ac9a45b91d448ed5dc80ffc98cd56c82e9d40028e172d3681013L963

/cc @lhecker

@zadjii-msft commented on GitHub (Jul 14, 2022): What version of the tools are you using? This seems to compile fine with VS 17.3.0 Preview 2.0... Most of https://github.com/microsoft/terminal/blob/main/src/terminal/parser/ft_fuzzer/fuzzing_directed.h has been unchanged since we went open source, but INTERESTINGLY, that specific line _was_ changed in #11816. In that PR, it was changed from what you suggest here to the current code. Link:https://github.com/microsoft/terminal/pull/11816/files#diff-5fbf1a284c85ac9a45b91d448ed5dc80ffc98cd56c82e9d40028e172d3681013L963 /cc @lhecker
claunia commented 2026-01-31 05:58:54 +00:00
Author
Owner
Copy Link

@JonCavesMSFT commented on GitHub (Jul 14, 2022):

I am using the live compiler -- it will probably become 17.4 at some point. The intention of that PR appears to be to make the code more conformant and so in order for 2-phase name lookup to work for access to 'm_t' and 'm_tInit' they need to be made dependent -- and the best way to achieve this is to append 'this->'. The syntax '&CFuzzType<_Type, _Args...>::m_tInit' creates a pointer-to-member - what is not what it wanted in this situation.

JonCaves

@JonCavesMSFT commented on GitHub (Jul 14, 2022): I am using the live compiler -- it will probably become 17.4 at some point. The intention of that PR appears to be to make the code more conformant and so in order for 2-phase name lookup to work for access to '`m_t`' and '`m_tInit`' they need to be made dependent -- and the best way to achieve this is to append '`this->`'. The syntax '`&CFuzzType<_Type, _Args...>::m_tInit`' creates a pointer-to-member - what is not what it wanted in this situation. JonCaves
claunia commented 2026-01-31 05:58:54 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 14, 2022):

Thanks for the heads up about 17.4!

@DHowett commented on GitHub (Jul 14, 2022): Thanks for the heads up about 17.4!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Bug Priority-2 Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17929
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?