starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.16] Default theme updates #17984

New Issue
Open
opened 2026-01-31 06:00:22 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 06:00:22 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jul 21, 2022).

Originally assigned to: @zadjii-msft, @cinnamon-msft on GitHub.

From discussion with @cinnamon-msft et. al.

  • Dark theme by default (was system)
  • tab.background: terminalBackground
  • Change the tab row colors back to what they were pre-Controlsv2
    • This point I might be mis-remembering. I think the crux was "make the colors better", and we had freedom to do whatever we wanted.
    • The current dark tabRow.background is basically the same as the default scheme BG, and maybe that's good, maybe that's bad.
  • tabRow.unfocusedBackground set to something sensible in the default themes as well.

The 🌶️ rejected ides:

  • Default to mica on
    • Rejected cause this would disable vintage opacity
    • Rejected cause our Mica story isn't fleshed out yet
    • Rejected cause dark tabs in light OS theme with Mica titlebars has pretty low contrast overall.
  • ... with a non-acrylic, transparent control, so that you'd get the mica termcontrol body.
    • see all the above.
Originally created by @zadjii-msft on GitHub (Jul 21, 2022). Originally assigned to: @zadjii-msft, @cinnamon-msft on GitHub. From discussion with @cinnamon-msft et. al. * [ ] Dark theme by default (was `system`) * [ ] `tab.background: terminalBackground` * [ ] Change the tab row colors back to what they were pre-Controlsv2 - This point I might be mis-remembering. I think the crux was "make the colors better", and we had freedom to do whatever we wanted. - The current dark tabRow.background is basically the same as the default scheme BG, and maybe that's good, maybe that's bad. * [ ] `tabRow.unfocusedBackground` set to something sensible in the default themes as well. _The 🌶️ rejected ides:_ * Default to mica on * Rejected cause this would disable vintage opacity * Rejected cause our Mica story isn't fleshed out yet * Rejected cause dark tabs in light OS theme with Mica titlebars has pretty low contrast overall. * ... with a non-acrylic, transparent control, so that you'd get the mica termcontrol body. * see all the above.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17984
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?