starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.16] Default theme updates #17987

New Issue
Closed
opened 2026-01-31 06:00:25 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:00:25 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jul 21, 2022).

Originally assigned to: @zadjii-msft, @cinnamon-msft on GitHub.

From discussion with @cinnamon-msft et. al.

  • Dark theme by default (was system)
  • tab.background: terminalBackground
  • Change the tab row colors back to what they were pre-Controlsv2
    • This point I might be mis-remembering. I think the crux was "make the colors better", and we had freedom to do whatever we wanted.
    • The current dark tabRow.background is basically the same as the default scheme BG, and maybe that's good, maybe that's bad.
  • tabRow.unfocusedBackground set to something sensible in the default themes as well.

The 🌶️ rejected ides:

  • Default to mica on
    • Rejected cause this would disable vintage opacity
    • Rejected cause our Mica story isn't fleshed out yet
    • Rejected cause dark tabs in light OS theme with Mica titlebars has pretty low contrast overall.
  • ... with a non-acrylic, transparent control, so that you'd get the mica termcontrol body.
    • see all the above.
Originally created by @zadjii-msft on GitHub (Jul 21, 2022). Originally assigned to: @zadjii-msft, @cinnamon-msft on GitHub. From discussion with @cinnamon-msft et. al. * [ ] Dark theme by default (was `system`) * [ ] `tab.background: terminalBackground` * [ ] Change the tab row colors back to what they were pre-Controlsv2 - This point I might be mis-remembering. I think the crux was "make the colors better", and we had freedom to do whatever we wanted. - The current dark tabRow.background is basically the same as the default scheme BG, and maybe that's good, maybe that's bad. * [ ] `tabRow.unfocusedBackground` set to something sensible in the default themes as well. _The 🌶️ rejected ides:_ * Default to mica on * Rejected cause this would disable vintage opacity * Rejected cause our Mica story isn't fleshed out yet * Rejected cause dark tabs in light OS theme with Mica titlebars has pretty low contrast overall. * ... with a non-acrylic, transparent control, so that you'd get the mica termcontrol body. * see all the above.
claunia commented 2026-01-31 06:00:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 5, 2022):

🏗️ Work in progress 🏗️

originscreenshot (focused/unforcused if available)tab.backgroundtabRow.backgroundtabRow.unfocusedBackgroundWith terminalBackground & CampbellContrast (goal 3:1)
Edge Dark

image
image

(1.454:1 / 1.212:1)

#3b3b3b

#202020

#2e2e2e

image
image

 1.2:1 / 1.44:1
Terminal (Controlsv1)

image

#0c0c0c

#333333

 n/a

image

 1.548:1
Terminal (Controlsv2)

image

(1.342:1)

#282828

#0a0a0a

 n/a

image

 1.012:1
BG from edge unfocused,

inactive BG from controlsv1

 n/a

terminalBackground

#2e2e2e

#333333

image

image

 1.44:1 / 1.548:1
Light BG from edge unfocused,

inactive BG from controlsv1

 n/a

terminalBackground

#e8e8e8

#ffffff

 15.9:1

Notes:

  • Campbell's BG is #0c0c0c
@zadjii-msft commented on GitHub (Aug 5, 2022): _🏗️ Work in progress 🏗️_ <table> <tr> <td>origin</td><td>screenshot (focused/unforcused if available)</td><td>tab.background</td><td>tabRow.background</td><td>tabRow.unfocusedBackground</td><td>With terminalBackground & Campbell</td><td>Contrast (goal 3:1)</td> </tr> <tr> <td>Edge Dark</td> <td> ![image](https://user-images.githubusercontent.com/18356694/183107109-d181736c-0643-4c60-8288-d465737f392a.png) ![image](https://user-images.githubusercontent.com/18356694/183107151-1f354592-951f-443b-bceb-e9d54cdeeb40.png) (1.454:1 / 1.212:1) </td> <td> `#3b3b3b`</td> <td> `#202020`</td> <td> `#2e2e2e`</td> <td> ![image](https://user-images.githubusercontent.com/18356694/183117887-6ec33d12-eda3-4d66-a48a-2fa71ead5b59.png) ![image](https://user-images.githubusercontent.com/18356694/183117914-94408386-54a8-4530-9395-6505510eb876.png) </td> <td> 1.2:1 / 1.44:1 </td> </tr> <tr> <td>Terminal (Controlsv1)</td> <td> ![image](https://user-images.githubusercontent.com/18356694/183116397-25d19d61-3192-447c-b954-7f0c1b7d9974.png) </td> <td> `#0c0c0c`</td> <td> `#333333`</td> <td>n/a</td> <td> ![image](https://user-images.githubusercontent.com/18356694/183118049-3b43b248-7762-4bca-a42b-c30fb17b4fe0.png) </td> <td>1.548:1</td> </tr> <tr> <td>Terminal (Controlsv2)</td> <td> ![image](https://user-images.githubusercontent.com/18356694/183117281-f8965c46-10f7-4c24-9166-091649c4df11.png) (1.342:1) </td> <td> `#282828`</td> <td> `#0a0a0a`</td> <td>n/a</td> <td> ![image](https://user-images.githubusercontent.com/18356694/183118256-735fda77-fd5e-48e6-b2c0-becc843b6de7.png) </td> <td>1.012:1</td> </tr> <tr> <td>BG from edge unfocused, inactive BG from controlsv1</td> <td> n/a </td> <td> `terminalBackground`</td> <td> `#2e2e2e`</td> <td> `#333333`</td> <td> ![image](https://user-images.githubusercontent.com/18356694/183122948-5f14ae7d-80c3-4bf3-8ad9-9a7fc765a413.png) ![image](https://user-images.githubusercontent.com/18356694/183123022-b5535cd0-f8e6-4319-912a-e4ea931ee20c.png) </td> <td> 1.44:1 / 1.548:1</td> </tr> <tr> <td>Light BG from edge unfocused, inactive BG from controlsv1</td> <td> n/a </td> <td> `terminalBackground`</td> <td> `#e8e8e8`</td> <td> `#ffffff`</td> <td> </td> <td> 15.9:1 </td> </tr> </table> _Notes:_ * Campbell's BG is #0c0c0c
claunia commented 2026-01-31 06:00:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13743, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13743, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17987
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?