starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Command History should discard empty histories first before discarding LRU non-empty history #18009

New Issue
Closed
opened 2026-01-31 06:01:06 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:01:06 +00:00
Owner
Copy Link

Originally created by @neerajsi-msft on GitHub (Jul 22, 2022).

Description of the new feature/enhancement

Scenario:

  1. Run one of the dbgeng console debuggers (cdb.exe) to debug a program in a build window.
  2. Exit the debugger.
  3. Run a build (I'm using the Windows build system).
  4. Relaunch the debugger and try to use the command history.

Behavior: No history for the debugger is preserved, since the executables in the build have flushed out the relevant history.

Desired Behavior: The executables that were part of the build had no input commands, while the console debugger had some input, so we should leave the console debugger's history in the list.

Proposed technical implementation details (optional)

There are a couple implementations we could consider to avoid discarding useful history:

  1. When picking a history in CommandHistory::s_Allocate, scan first for history buffers that aren't !CLE_ALLOCATED and have zero commands, and only discard a non-empty history if no candidate was found with zero commands.
  2. Alternatively, lazily call s_Allocate when the first command is added to a history buffer.

Option 1 is a simpler implementation, but option 2 is nice in that we can use the full NumberOfHistoryBuffers for useful histories, rather than losing one buffer for empty commands cycling through.

Originally created by @neerajsi-msft on GitHub (Jul 22, 2022). # Description of the new feature/enhancement Scenario: 1) Run one of the dbgeng console debuggers (cdb.exe) to debug a program in a build window. 2) Exit the debugger. 3) Run a build (I'm using the Windows build system). 4) Relaunch the debugger and try to use the command history. Behavior: No history for the debugger is preserved, since the executables in the build have flushed out the relevant history. Desired Behavior: The executables that were part of the build had no input commands, while the console debugger had some input, so we should leave the console debugger's history in the list. # Proposed technical implementation details (optional) There are a couple implementations we could consider to avoid discarding useful history: 1) When picking a history in CommandHistory::s_Allocate, scan first for history buffers that aren't !CLE_ALLOCATED and have zero commands, and only discard a non-empty history if no candidate was found with zero commands. 2) Alternatively, lazily call s_Allocate when the first command is added to a history buffer. Option 1 is a simpler implementation, but option 2 is nice in that we can use the full NumberOfHistoryBuffers for useful histories, rather than losing one buffer for empty commands cycling through.
claunia commented 2026-01-31 06:01:08 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 22, 2022):

Huh. That's a good point.

@DHowett commented on GitHub (Jul 22, 2022): _Huh_. That's a good point.
claunia commented 2026-01-31 06:01:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 25, 2022):

now this is a commandline change I can get behind and can't POSSIBLY imagine that an oil rig is depending on. Thanks for the suggestion!

@zadjii-msft commented on GitHub (Jul 25, 2022): now this is a commandline change I can get behind and can't POSSIBLY imagine that an oil rig is depending on. Thanks for the suggestion!
claunia commented 2026-01-31 06:01:08 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13869, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13869, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CookedRead Help Wanted Issue-Task Needs-Tag-Fix Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18009
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?