starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Windows terminal hangs after running ripgrep in a loop #1801

New Issue
Closed
opened 2026-01-30 22:36:47 +00:00 by claunia · 9 comments
claunia commented 2026-01-30 22:36:47 +00:00
Owner
Copy Link

Originally created by @Treit on GitHub (Jun 21, 2019).

Originally assigned to: @miniksa on GitHub.

Environment

Windows version 1903 OS build 18899.1000
Windows Terminal (Preview) version 0.2.1703.0

Any other software?
ripgrep 11.0.0

Steps to reproduce

Install ripgrep
Open wt (Windows Terminal), running PowerShell.
Run the following from the root of a large drive
while ($true) { rg -i "foo" }

Expected behavior

The terminal continually runs ripgrep against all files on the drive

Actual behavior

The terminal eventually hangs and is completely unresponsive.

The call stack for the main thread when the window hangs is attached.

HungTerminal1.callstack.txt

A minidump of the hung process is available here:
HungWindowsTerminal

Originally created by @Treit on GitHub (Jun 21, 2019). Originally assigned to: @miniksa on GitHub. # Environment Windows version 1903 OS build 18899.1000 Windows Terminal (Preview) version 0.2.1703.0 Any other software? ripgrep 11.0.0 # Steps to reproduce Install [ripgrep](https://github.com/BurntSushi/ripgrep) Open wt (Windows Terminal), running PowerShell. Run the following from the root of a large drive `while ($true) { rg -i "foo" }` # Expected behavior The terminal continually runs ripgrep against all files on the drive # Actual behavior The terminal eventually hangs and is completely unresponsive. The call stack for the main thread when the window hangs is attached. [HungTerminal1.callstack.txt](https://github.com/microsoft/terminal/files/3312675/HungTerminal1.callstack.txt) A minidump of the hung process is available here: [HungWindowsTerminal](https://1drv.ms/u/s!Alav93a0o3vchOg0nCVjwUPjFn0DYw?e=Ue4AP5)
claunia commented 2026-01-30 22:36:48 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Sep 11, 2019):

The callstack and dump given appears to be in a state of appropriate locks with output being written to the buffer at the time of the dump/stack break.

I'm trying to repro this locally to see if I can find something a bit more obvious.

@miniksa commented on GitHub (Sep 11, 2019): The callstack and dump given appears to be in a state of appropriate locks with output being written to the buffer at the time of the dump/stack break. I'm trying to repro this locally to see if I can find something a bit more obvious.
claunia commented 2026-01-30 22:36:48 +00:00
Author
Owner
Copy Link

@Treit commented on GitHub (Sep 12, 2019):

The callstack and dump given appears to be in a state of appropriate locks with output being written to the buffer at the time of the dump/stack break.

I'm trying to repro this locally to see if I can find something a bit more obvious.

@miniksa I was able to reproduce it just now on my primary machine so if there is anything I can do to help debug it please let me know.

@Treit commented on GitHub (Sep 12, 2019): > The callstack and dump given appears to be in a state of appropriate locks with output being written to the buffer at the time of the dump/stack break. > > I'm trying to repro this locally to see if I can find something a bit more obvious. @miniksa I was able to reproduce it just now on my primary machine so if there is anything I can do to help debug it please let me know.
claunia commented 2026-01-30 22:36:49 +00:00
Author
Owner
Copy Link

@Treit commented on GitHub (Sep 20, 2019):

@miniksa Just adding some of the details I sent in email here for reference.

The issue I am hitting appears to be an infinite loop in:

void Terminal::_WriteBuffer(const std::wstring_view& stringView)

This is in Terminal.cpp, line 326

On line 372 we have the following code:

i += cellDistance - 1;

I can see in the debugger when this hang reproduces that cellDistance has become 0. Thus, this becomes a decrement instead of an increment.

So, the variable is decremented by one on line 372 and is then incremented by one at the start of the next loop iteration. When it comes back to line 372, i is decremented again, and this process repeats forever.

Further investigation will be needed to determine how cellDistance can become zero and trigger this infinite loop.

@Treit commented on GitHub (Sep 20, 2019): @miniksa Just adding some of the details I sent in email here for reference. The issue I am hitting appears to be an infinite loop in: `void Terminal::_WriteBuffer(const std::wstring_view& stringView)` [This is in Terminal.cpp, line 326](https://github.com/microsoft/terminal/blob/b84a073464cdda225ccf65214f58b354cbe6a166/src/cascadia/TerminalCore/Terminal.cpp#L326) On [line 372](https://github.com/microsoft/terminal/blob/b84a073464cdda225ccf65214f58b354cbe6a166/src/cascadia/TerminalCore/Terminal.cpp#L372) we have the following code: `i += cellDistance - 1;` I can see in the debugger when this hang reproduces that cellDistance has become 0. Thus, this becomes a decrement instead of an increment. So, the variable is decremented by one on line 372 and is then incremented by one at the start of the next loop iteration. When it comes back to line 372, i is decremented again, and this process repeats forever. Further investigation will be needed to determine how cellDistance can become zero and trigger this infinite loop.
claunia commented 2026-01-30 22:36:49 +00:00
Author
Owner
Copy Link

@Treit commented on GitHub (Sep 23, 2019):

I have found an easier way to reproduce this issue, by running the following trivial C# program:

namespace TerminalStress
{
    using System;
    using System.Text;

    class Program
    {
        static void Main(string[] args)
        {
            Random r = new Random();

            Console.OutputEncoding = Encoding.UTF8;

            while (true)
            {
                char c = (char)r.Next(0xD100, 0xFA95);

                Console.Write(c);
            }
        }
    }
}
@Treit commented on GitHub (Sep 23, 2019): I have found an easier way to reproduce this issue, by running the following trivial C# program: ``` namespace TerminalStress { using System; using System.Text; class Program { static void Main(string[] args) { Random r = new Random(); Console.OutputEncoding = Encoding.UTF8; while (true) { char c = (char)r.Next(0xD100, 0xFA95); Console.Write(c); } } } } ```
claunia commented 2026-01-30 22:36:49 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Sep 26, 2019):

Two issues here:

  1. When something inside Terminal::_WriteBuffer, the function that sorely needs to be rewritten in the Boogaloo Bug #780, gets the cursor into an X position that falls outside the bounds of the buffer (Cursor X = 120, but the buffer is only valid 0-119), then the TextBuffer::Write methods will refuse to write because they're checking that the cursor is in bounds before attempting to write. This results in a cell-advance count of 0 reported to _WriteBuffer. It doesn't compensate for this in any appreciable manner. It also never realizes that proposedCursorPosition is outside the bounds of the buffer to correct itself down a line (X=0; Y++). Compensating for a 0 cell distance advance, a proposedCursorPosition.X past the buffer end, or both does resolve this issue.

  2. However, something in Write is permitting a cell distance that when advanced by the caller results in a position outside the buffer. That's not correct. That's a character bisect (where we only end up drawing the left half of a wide character). I haven't totally narrowed this one down yet, but I'm looking into it next as it's important to fix this too.

All of this really comes down to.... #780 needs to get done. It would head off this entire class of issue. I'll patch up Terminal::_WriteBuffer now and #780 is booked for November.

@miniksa commented on GitHub (Sep 26, 2019): Two issues here: 1. When something inside `Terminal::_WriteBuffer`, the function that sorely needs to be rewritten in the Boogaloo Bug #780, gets the cursor into an X position that falls outside the bounds of the buffer (Cursor X = 120, but the buffer is only valid 0-119), then the `TextBuffer::Write` methods will refuse to write because they're checking that the cursor is in bounds before attempting to write. This results in a cell-advance count of 0 reported to `_WriteBuffer`. It doesn't compensate for this in any appreciable manner. It also never realizes that `proposedCursorPosition` is outside the bounds of the buffer to correct itself down a line (X=0; Y++). Compensating for a 0 cell distance advance, a `proposedCursorPosition.X` past the buffer end, or both does resolve this issue. 2. However, something in `Write` is permitting a cell distance that when advanced by the caller results in a position outside the buffer. That's not correct. That's a character bisect (where we only end up drawing the left half of a wide character). I haven't totally narrowed this one down yet, but I'm looking into it next as it's important to fix this too. All of this really comes down to.... #780 needs to get done. It would head off this entire class of issue. I'll patch up `Terminal::_WriteBuffer` now and #780 is booked for November.
claunia commented 2026-01-30 22:36:50 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 16, 2019):

Reopening: the cure was worse than the disease, so we may well just have to wait for #780 to land here. Sorry!

@DHowett-MSFT commented on GitHub (Oct 16, 2019): Reopening: the cure was worse than the disease, so we may well just have to wait for #780 to land here. Sorry!
claunia commented 2026-01-30 22:36:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 23, 2019):

:tada:This issue was addressed in #2924, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.🎉

Handy links:

@ghost commented on GitHub (Oct 23, 2019): :tada:This issue was addressed in #2924, which has now been successfully released as `Windows Terminal Preview v0.6.2951.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.6.2951.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
claunia commented 2026-01-30 22:36:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 27, 2020):

:tada:This issue was addressed in #4150, which has now been successfully released as Windows Terminal Preview v0.8.10261.0.🎉

Handy links:

@ghost commented on GitHub (Jan 27, 2020): :tada:This issue was addressed in #4150, which has now been successfully released as `Windows Terminal Preview v0.8.10261.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.8.10261.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
claunia commented 2026-01-30 22:36:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 13, 2020):

:tada:This issue was addressed in #4150, which has now been successfully released as Windows Terminal Preview v0.9.433.0.🎉

Handy links:

@ghost commented on GitHub (Feb 13, 2020): :tada:This issue was addressed in #4150, which has now been successfully released as `Windows Terminal Preview v0.9.433.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.9.433.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Quality Area-TerminalControl Issue-Bug Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1801
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?