starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Experimental "marks" settings are documented as global, but are per-profile #18024

New Issue
Closed
opened 2026-01-31 06:01:33 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:01:33 +00:00
Owner
Copy Link

Originally created by @TBBle on GitHub (Jul 23, 2022).

#13414 added experimental.autoMarkPrompts and experimental.showMarksOnScrollbar to the Globals section of doc/cascadia/profiles.schema.json (and they were also described as such in the relevant release notes), but these settings are per-profile (as you'd expect such settings to be, and as documented in #11000).

Confirmed both because that's where they actually work in the profile, and by their presence in the MTSM_PROFILE_SETTINGS macro.

At least in VS Code's case, there's also an issue that even with the $schema pointing at the correct JSON schema, validation does not like the new scrollToMark action, or in fact any of the new marks, but I suspect that is more of a VSCode JSON editor issue, since it's also rejecting intenseTextStyle as a profile setting. >_<

Originally created by @TBBle on GitHub (Jul 23, 2022). <!-- Briefly describe which document needs to be corrected and why. --> #13414 added `experimental.autoMarkPrompts` and `experimental.showMarksOnScrollbar` to the `Globals` section of [_doc/cascadia/profiles.schema.json_](https://github.com/microsoft/terminal/blob/main/doc/cascadia/profiles.schema.json) (and they were also described as such in the [relevant release notes](https://github.com/microsoft/terminal/releases/tag/v1.15.1862.0)), but these settings are per-profile (as you'd expect such settings to be, and as documented in #11000). Confirmed both because that's where they actually _work_ in the profile, and by [their presence in the `MTSM_PROFILE_SETTINGS` macro](https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/MTSMSettings.h#L84-L85). At least in VS Code's case, there's also an issue that even with the `$schema` pointing at [the correct JSON schema](https://raw.githubusercontent.com/microsoft/terminal/v1.15.2002.0/doc/cascadia/profiles.schema.json), validation does not like the new `scrollToMark` action, or in fact any of the new marks, but I suspect that is more of a VSCode JSON editor issue, since it's also rejecting `intenseTextStyle` as a profile setting. >_<
claunia commented 2026-01-31 06:01:35 +00:00
Author
Owner
Copy Link

@TBBle commented on GitHub (Jul 23, 2022):

Also, the current JSON schema in main is probably invalid JSON, but that doesn't seem worth a separate bug report since fixing this will have to touch that file anyway.

@TBBle commented on GitHub (Jul 23, 2022): Also, [the current JSON schema in main is probably invalid JSON](https://github.com/microsoft/terminal/pull/13469#discussion_r928138496), but that doesn't seem worth a separate bug report since fixing this will have to touch that file anyway.
claunia commented 2026-01-31 06:01:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 26, 2022):

Huh. Thanks for the heads up!

@zadjii-msft commented on GitHub (Jul 26, 2022): Huh. Thanks for the heads up!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Schema Help Wanted Issue-Docs Needs-Triage Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18024
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?