starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Users cannot Touch Inspect window caption controls #18066

New Issue
Open
opened 2026-01-31 06:02:45 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:02:45 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Jul 29, 2022).

  1. Open Terminal
  2. On a touch device, start Narrator
    1. Hover over title bar content such as min/max/close buttons
    2. Observe that Narrator cannot find the controls
  3. Alternative, use Inspect and use it to hit test the title bar content
    1. Observe that hit testing in Inspect doesn't find the min/max/close controls

It is worth noting that the tabs in the title bar hit test correctly. The draggable part also hit tests, but Inspect shows that the bounding rect extends beyond the bounds of the window (looks like the width is that of the window rather than (window - tabs)).

Notes from original reporter

This issue was discovered in the investigation of a similar issue in File Explorer. We believe it is up to providers
to support hit testing when their client area extends into the title bar.

In this scenario, the issue is that the app has specified that its client area includes the non-client area of the
title bar. UIA makes sure not to override any hit testing that is within the client area of an app.

To make this work, we recommend following the pattern of other apps that extend their client area into the title bar,
such as WordPad:

  1. Set the provider option to remove UIA non-client area support (may be more of an optimization and not strictly
    required) by returning ProviderOptions_RefuseNonClientSupport.

ex:

CUxHWNDElementProvider::get_ProviderOptions  
{  
// <snip> 
     // Claim support for the non-client area   
    *pRetVal = (ProviderOptions)(ProviderOptions_ServerSideProvider | ProviderOptions_RefuseNonClientSupport);  
    return S_OK;  
}
  1. Update client-area hit testing to also test non-client controls, such as min/max/close buttons.

ex:

CUxHWNDElementProvider::RootElementProviderFromPoint  
// <snip> 
    // Ask the main frame what caption element pt is on, if any
    POINT pt = {static_cast<LONG>(x), static_cast<LONG>(y)}; 
    LRESULT lHit = SendMessage(_hwndMain, WM_NCHITTEST, 0, POINTTOPOINTS(pt)); 
 
    // Special case for custom caption elements: this could potentially be a custom child element 
    // Those values are returned by HWndContainer::OnNcHitTest 
    if (lHit == HTCAPTION || lHit == HTBORDER) 
    { 
// <snip> --- Special handling for custom controls in title bar --- 
    } 

    // If we don't have anything yet, try the regular hit-testing for non-client. 
    if (pProvider == NULL) 
    { 
// <snip> --- maps lHit to OBJID_* --- 
            // Get the non-client provider for this piece and wrap it up 
            IRawElementProviderSimple * pRawProvider; 
            hr = UiaProviderForNonClient(_hwndMain, lEnd, CHILDID_SELF, &pRawProvider); 
...

Ported from MSFT-38927143

Originally created by @DHowett on GitHub (Jul 29, 2022). 1. Open Terminal 1. On a touch device, start Narrator 1. Hover over title bar content such as min/max/close buttons 1. Observe that Narrator cannot find the controls 1. Alternative, use Inspect and use it to hit test the title bar content 1. Observe that hit testing in Inspect doesn't find the min/max/close controls It is worth noting that the tabs in the title bar hit test correctly. The draggable part also hit tests, but Inspect shows that the bounding rect extends beyond the bounds of the window (looks like the width is that of the window rather than (window - tabs)). > _Notes from original reporter_ > > This issue was discovered in the investigation of a similar issue in File Explorer. We believe it is up to providers > to support hit testing when their client area extends into the title bar. > > In this scenario, the issue is that the app has specified that its client area includes the non-client area of the > title bar. UIA makes sure not to override any hit testing that is within the client area of an app. > > > > To make this work, we recommend following the pattern of other apps that extend their client area into the title bar, > such as WordPad: > > 1) Set the provider option to remove UIA non-client area support (may be more of an optimization and not strictly > required) by returning ProviderOptions_RefuseNonClientSupport. > > ex: > > ```c++ > CUxHWNDElementProvider::get_ProviderOptions > { > // <snip> > // Claim support for the non-client area > *pRetVal = (ProviderOptions)(ProviderOptions_ServerSideProvider | ProviderOptions_RefuseNonClientSupport); > return S_OK; > } > ``` > > 2) Update client-area hit testing to also test non-client controls, such as min/max/close buttons. > > ex: > > ```c++ > CUxHWNDElementProvider::RootElementProviderFromPoint > // <snip> > // Ask the main frame what caption element pt is on, if any > POINT pt = {static_cast<LONG>(x), static_cast<LONG>(y)}; > LRESULT lHit = SendMessage(_hwndMain, WM_NCHITTEST, 0, POINTTOPOINTS(pt)); > > // Special case for custom caption elements: this could potentially be a custom child element > // Those values are returned by HWndContainer::OnNcHitTest > if (lHit == HTCAPTION || lHit == HTBORDER) > { > // <snip> --- Special handling for custom controls in title bar --- > } > > // If we don't have anything yet, try the regular hit-testing for non-client. > if (pProvider == NULL) > { > // <snip> --- maps lHit to OBJID_* --- > // Get the non-client provider for this piece and wrap it up > IRawElementProviderSimple * pRawProvider; > hr = UiaProviderForNonClient(_hwndMain, lEnd, CHILDID_SELF, &pRawProvider); > ... > ``` _Ported from MSFT-38927143_
claunia added the Issue-BugProduct-TerminalPriority-2Area-Accessibility labels 2026-01-31 06:02:46 +00:00
claunia commented 2026-01-31 06:02:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 1, 2022):

Hey we may need to do this for theming! There's a mail thread titled "RE: Snap Flyouts only over DWM caption buttons?". See also #10509

@zadjii-msft commented on GitHub (Aug 1, 2022): Hey we may need to do this for theming! There's a mail thread titled "RE: Snap Flyouts only over DWM caption buttons?". See also #10509
claunia commented 2026-01-31 06:02:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 2, 2022):

Maybe also related: #11260

@zadjii-msft commented on GitHub (Aug 2, 2022): Maybe also related: #11260
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18066
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?