starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Export Text when in Admin mode filename suggestion has invalid character ":" #18093

New Issue
Closed
opened 2026-01-31 06:03:26 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 06:03:26 +00:00
Owner
Copy Link

Originally created by @restartedwill on GitHub (Aug 3, 2022).

Windows Terminal version

1.14.1963.0

Windows build number

22000.795

Other Software

No response

Steps to reproduce

Open Windows Terminal (Admin).
Have text in console window.
Right click on tab and choose "Export Text".

Expected Behavior

Cleanse out the colon character and other invalid characters for filenames based on the tab name.

Actual Behavior

Observe filename provided has "Admin: " as the leading text, and on Windows, a colon is not valid in filenames.

Originally created by @restartedwill on GitHub (Aug 3, 2022). ### Windows Terminal version 1.14.1963.0 ### Windows build number 22000.795 ### Other Software _No response_ ### Steps to reproduce Open Windows Terminal (Admin). Have text in console window. Right click on tab and choose "Export Text". ### Expected Behavior Cleanse out the colon character and other invalid characters for filenames based on the tab name. ### Actual Behavior Observe filename provided has "Admin: " as the leading text, and on Windows, a colon is not valid in filenames.
claunia commented 2026-01-31 06:03:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 3, 2022):

I mean, I guess why not? We'd probably accept this as a contribution

@zadjii-msft commented on GitHub (Aug 3, 2022): I mean, I guess why not? We'd probably accept this as a contribution
claunia commented 2026-01-31 06:03:29 +00:00
Author
Owner
Copy Link

@Eschivo commented on GitHub (Aug 5, 2022):

If @restartedwill is not willing to work on this issue, I would try to tackle this, but I'll need guidance to identify what files need to be examined and edited

@Eschivo commented on GitHub (Aug 5, 2022): If @restartedwill is not willing to work on this issue, I would try to tackle this, but I'll need guidance to identify what files need to be examined and edited
claunia commented 2026-01-31 06:03:29 +00:00
Author
Owner
Copy Link

@restartedwill commented on GitHub (Aug 5, 2022):

Yes, I am not able to tackle this change; just raising awareness in the hopes another developer could pick it up.

From: EliaSchiavon @.>
Sent: Friday, August 5, 2022 4:16 AM
To: microsoft/terminal @.>
Cc: Will DP @.>; Mention @.>
Subject: Re: [microsoft/terminal] Export Text when in Admin mode filename suggestion has invalid character ":" (Issue #13664)

If @restartedwill https://github.com/restartedwill is not willing to work on this issue, I would try to tackle this, but I'll need guidance to identify what files need to be examined and edited

—
Reply to this email directly, view it on GitHub https://github.com/microsoft/terminal/issues/13664#issuecomment-1206284826 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHJGH5IQU2AV24YK6GC7RLVXTSWTANCNFSM55POEZIA .
You are receiving this because you were mentioned. https://github.com/notifications/beacon/AGHJGHZN5EOK47B4U2XGEITVXTSWTA5CNFSM55POEZIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI7THEGQ.gif Message ID: @.***>

@restartedwill commented on GitHub (Aug 5, 2022): Yes, I am not able to tackle this change; just raising awareness in the hopes another developer could pick it up. From: EliaSchiavon ***@***.***> Sent: Friday, August 5, 2022 4:16 AM To: microsoft/terminal ***@***.***> Cc: Will DP ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/terminal] Export Text when in Admin mode filename suggestion has invalid character ":" (Issue #13664) If @restartedwill <https://github.com/restartedwill> is not willing to work on this issue, I would try to tackle this, but I'll need guidance to identify what files need to be examined and edited — Reply to this email directly, view it on GitHub <https://github.com/microsoft/terminal/issues/13664#issuecomment-1206284826> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGHJGH5IQU2AV24YK6GC7RLVXTSWTANCNFSM55POEZIA> . You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AGHJGHZN5EOK47B4U2XGEITVXTSWTA5CNFSM55POEZIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI7THEGQ.gif> Message ID: ***@***.***>
claunia commented 2026-01-31 06:03:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 5, 2022):

That'd be great! I'd start right here:

74cdffe921/src/cascadia/TerminalApp/TabManagement.cpp (L435-L436)

That's the line where we set the proposed text. I don't think we have any existing helpers for trimming a string so that it's a viable filename - I'll leave that as an exercise for the reader 😉

@zadjii-msft commented on GitHub (Aug 5, 2022): That'd be great! I'd start right here: https://github.com/microsoft/terminal/blob/74cdffe9215740a2c783c2d1f393fd303286b2b5/src/cascadia/TerminalApp/TabManagement.cpp#L435-L436 That's the line where we set the proposed text. I don't think we have any existing helpers for trimming a string so that it's a viable filename - I'll leave that as an exercise for the reader 😉
claunia commented 2026-01-31 06:03:29 +00:00
Author
Owner
Copy Link

@Eschivo commented on GitHub (Aug 5, 2022):

Ahah thank you! Started working on it, I will raise a PR in the next few days

@Eschivo commented on GitHub (Aug 5, 2022): Ahah thank you! Started working on it, I will raise a PR in the next few days
claunia commented 2026-01-31 06:03:30 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13693, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13693, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 06:03:30 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 18, 2022):

:tada:This issue was addressed in #13693, which has now been successfully released as Windows Terminal v1.15.2874.🎉

Handy links:

@ghost commented on GitHub (Oct 18, 2022): :tada:This issue was addressed in #13693, which has now been successfully released as `Windows Terminal v1.15.2874`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.2874) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface good first issue Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18093
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?