starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

tab.showCloseButton: hover|never + tabWidthMode: titleLength should have some padding on the left of the tab #18156

New Issue
Open
opened 2026-01-31 06:05:19 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 06:05:19 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 11, 2022).

  • There should be a bit more space to the right of the tab title to match the left side (next to icon)
    image
Fixed in 1.16

From 1.16.2142.0 bash on Aug 2nd

  • Gap between inactive tabs and content
    image
  • A light tabRow.BG in dark mode causes the chevron to be white:
    image
  • We need to remove useMica
  • With "tab.background" set to "terminalBackground":
    • Hover over a terminal tab -> the tab color doesn't change/give any visual feedback that it is being hovered over
    • Hover over a settings tab -> the tab color does change/give visual feedback

additional

  • With "tab.showCloseButton" set to "hover": Height of inactive tabs change upon hover - (can't seem to post a GIF in OneNote so try it yourself)
    • Mike couldn't repro this, so maybe someone else can?
Originally created by @zadjii-msft on GitHub (Aug 11, 2022). * [ ] There should be a bit more space to the right of the tab title to match the left side (next to icon) ![image](https://user-images.githubusercontent.com/18356694/184159398-5ad2da19-c0ef-44b6-bf8b-85df2d18bb1d.png) <details> <summary>Fixed in 1.16</summary> ### From 1.16.2142.0 bash on Aug 2nd * [x] Gap between inactive tabs and content ![image](https://user-images.githubusercontent.com/18356694/184158584-f2f512f9-8f78-498e-8425-ceeab1c3945f.png) - This might be related to the gap I was seeing in 2.8. Maybe fixing this (or at least understanding the root cause) might alleviate that issue as well. - Tracked upstream at: https://github.com/microsoft/microsoft-ui-xaml/issues/7674 * [x] A light tabRow.BG in dark mode causes the chevron to be white: ![image](https://user-images.githubusercontent.com/18356694/184158730-27c59deb-e744-4246-9ed3-bc6fb9d734d5.png) * fixed in #13871 * [x] We need to remove `useMica` * [x] With "tab.background" set to "terminalBackground": * [x] Hover over a terminal tab -> the tab color doesn't change/give any visual feedback that it is being hovered over * [x] Hover over a settings tab -> the tab color does change/give visual feedback </details> ### additional * [x] With `"tab.showCloseButton"` set to `"hover"`: Height of inactive tabs change upon hover - (can't seem to post a GIF in OneNote so try it yourself) * Mike couldn't repro this, so maybe someone else can?
claunia added the Help WantedIssue-BugPriority-3Product-TerminalArea-Theming labels 2026-01-31 06:05:19 +00:00
claunia commented 2026-01-31 06:05:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 29, 2022):

note:

setting the bottom padding to -1 (0,0,0,-1) on this element:

image
image
(first tab has no line, second does)

seems to fix this, now I just have to find the right way to do that

@zadjii-msft commented on GitHub (Aug 29, 2022): note: setting the bottom padding to -1 (0,0,0,-1) on this element: ![image](https://user-images.githubusercontent.com/18356694/187266980-dbb65ff9-2c9f-4546-9624-01a462923e13.png) ![image](https://user-images.githubusercontent.com/18356694/187267084-d413fa56-7189-4f20-a662-9f83baf32054.png) _(first tab has no line, second does)_ seems to fix this, now I just have to find the right way to do that
claunia commented 2026-01-31 06:05:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 29, 2022):

Ah hecks no
enhance.jpeg

The "thin line under the inactive tabs" repros even in the WinUI gallery. I'm betting that's out of our control. Great. I'll file upstream.

@zadjii-msft commented on GitHub (Aug 29, 2022): Ah hecks no ![enhance.jpeg](https://user-images.githubusercontent.com/18356694/187287364-ba2a4131-4895-4756-be60-fe59f28057d7.png) The "thin line under the inactive tabs" repros even in the WinUI gallery. I'm betting that's out of our control. Great. I'll file upstream.
claunia commented 2026-01-31 06:05:21 +00:00
Author
Owner
Copy Link

@pete-debiase commented on GitHub (Nov 2, 2022):

Apologies if this is not the right place to post this, but just wanted to add a +1 for There should be a bit more space to the right of the tab title to match the left side (next to icon) from the OP. The fact that tab titles are not centered with showCloseButton: never has been bugging me recently.

On a similar note, would it be feasible to remove the (erroneous?) straight line cutting through the rounded bottom left corner of each tab? This seems like it may be some kind of stray rendering artifact left over from when the tab is not active (if I'm seeing this right, the corner rounding is applied when the tab becomes active). Are the left and right sides of the tab handled differently? There is no cut-through in the bottom right corner of the tab.

image
@pete-debiase commented on GitHub (Nov 2, 2022): Apologies if this is not the right place to post this, but just wanted to add a +1 for `There should be a bit more space to the right of the tab title to match the left side (next to icon)` from the OP. The fact that tab titles are not centered with `showCloseButton: never` has been bugging me recently. On a similar note, would it be feasible to remove the (erroneous?) straight line cutting through the rounded bottom left corner of each tab? This seems like it may be some kind of stray rendering artifact left over from when the tab is not active (if I'm seeing this right, the corner rounding is applied when the tab becomes active). Are the left and right sides of the tab handled differently? There is no cut-through in the bottom right corner of the tab. <img width="520" alt="image" src="https://user-images.githubusercontent.com/15940251/199595003-35430bcc-3ed9-4607-99de-8d7ed986eb96.png">
claunia commented 2026-01-31 06:05:21 +00:00
Author
Owner
Copy Link

@bradwilson commented on GitHub (Oct 31, 2023):

Just ran across this, and this issue has been quiet for a while. Is this still planned?

@bradwilson commented on GitHub (Oct 31, 2023): Just ran across this, and this issue has been quiet for a while. Is this still planned?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Help Wanted Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?