starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

TODO: [MSFT:4586207] Clean up CommandLine::ProcessCommandLine -- needs helpers. #1830

New Issue
Closed
opened 2026-01-30 22:39:02 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:39:02 +00:00
Owner
Copy Link

Originally created by @ChristophePichaud on GitHub (Jun 22, 2019).

Summary of the new feature/enhancement

This code requires functions (helpers) and better wrtiting style.
Issue idea comes from source code of cmdline.cpp line 582 and a TODO MSFT comment.

Proposed technical implementation details (optional)

../..
switch (wch)
{
case VK_ESCAPE:
OnKeyEscape(cookedReadData, true);
break;
case VK_DOWN:
OnKeyDown(cookedReadData);
break;
../..

MSFT:4586207

Originally created by @ChristophePichaud on GitHub (Jun 22, 2019). # Summary of the new feature/enhancement This code requires functions (helpers) and better wrtiting style. Issue idea comes from source code of cmdline.cpp line 582 and a TODO MSFT comment. # Proposed technical implementation details (optional) ../.. switch (wch) { case VK_ESCAPE: OnKeyEscape(cookedReadData, true); break; case VK_DOWN: OnKeyDown(cookedReadData); break; ../.. MSFT:4586207
claunia commented 2026-01-30 22:39:05 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 24, 2019):

Please be careful when looking at this area. It's one of the more difficult areas in conhost, and it can impact application compatibility pretty heavily.

@DHowett-MSFT commented on GitHub (Jun 24, 2019): Please be careful when looking at this area. It's one of the more difficult areas in conhost, and it can impact application compatibility pretty heavily.
claunia commented 2026-01-30 22:39:05 +00:00
Author
Owner
Copy Link

@ChristophePichaud commented on GitHub (Jun 24, 2019):

Does it means I can try on a dedicated branch or I need to explain more things ?
Looking at the code is not so tremendous difficult. It's a central and nervous point yes, but not so difficult to handle. Correct me if I'm wrong.

@ChristophePichaud commented on GitHub (Jun 24, 2019): Does it means I can try on a dedicated branch or I need to explain more things ? Looking at the code is not so tremendous difficult. It's a central and nervous point yes, but not so difficult to handle. Correct me if I'm wrong.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CookedRead Area-Input In-PR Issue-Task Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1830
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?