starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Try to flow together JSON serialization for keybindings #1832

New Issue
Closed
opened 2026-01-30 22:39:06 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 22:39:06 +00:00
Owner
Copy Link

Originally created by @Jaykul on GitHub (Jun 22, 2019).

Originally assigned to: @zadjii-msft on GitHub.

I would love it if we could see all the keybindings ...

Wouldn't it be better if the default profiles.json could be formatted like ...

        "keybindings": [
            { "command": "closeTab",       "keys": [ "ctrl+w" ] },
            { "command": "newTab",         "keys": [ "ctrl+t" ] },
            { "command": "newTabProfile0", "keys": [ "ctrl+shift+1" ] },
            { "command": "newTabProfile1", "keys": [ "ctrl+shift+2" ] },
            { "command": "newTabProfile2", "keys": [ "ctrl+shift+3" ] },
            { "command": "newTabProfile3", "keys": [ "ctrl+shift+4" ] },
            { "command": "newTabProfile4", "keys": [ "ctrl+shift+5" ] },
            { "command": "newTabProfile5", "keys": [ "ctrl+shift+6" ] },
            { "command": "newTabProfile6", "keys": [ "ctrl+shift+7" ] },
            { "command": "newTabProfile7", "keys": [ "ctrl+shift+8" ] },
            { "command": "newTabProfile8", "keys": [ "ctrl+shift+9" ] },
            { "command": "nextTab",        "keys": [ "ctrl+tab" ] },
            { "command": "prevTab",        "keys": [ "ctrl+shift+tab" ] },
            { "command": "openSettings",   "keys": [ "ctrl+," ] },
            { "command": "scrollDown",     "keys": [ "ctrl+shift+down" ] },
            { "command": "scrollDownPage", "keys": [ "ctrl+shift+pgdn" ] },
            { "command": "scrollUp",       "keys": [ "ctrl+shift+up" ] },
            { "command": "scrollUpPage",   "keys": [ "ctrl+shift+pgup" ] },
            { "command": "switchToTab0",   "keys": [ "ctrl+1" ] },
            { "command": "switchToTab1",   "keys": [ "ctrl+2" ] },
            { "command": "switchToTab2",   "keys": [ "ctrl+3" ] },
            { "command": "switchToTab3",   "keys": [ "ctrl+4" ] },
            { "command": "switchToTab4",   "keys": [ "ctrl+5" ] },
            { "command": "switchToTab5",   "keys": [ "ctrl+6" ] },
            { "command": "switchToTab6",   "keys": [ "ctrl+7" ] },
            { "command": "switchToTab7",   "keys": [ "ctrl+8" ] },
            { "command": "switchToTab8",   "keys": [ "ctrl+9" ] }
        ],

And I just mean getting rid of the terribly redundant white space so that all the keys fit on screen at the same time ... not the fact that these key defaults are clearly superior (who's idea was it to use ALT for switching tabs, anyway?).

Originally created by @Jaykul on GitHub (Jun 22, 2019). Originally assigned to: @zadjii-msft on GitHub. # I would love it if we could see all the keybindings ... Wouldn't it be better if the default profiles.json could be formatted like ... ```json "keybindings": [ { "command": "closeTab", "keys": [ "ctrl+w" ] }, { "command": "newTab", "keys": [ "ctrl+t" ] }, { "command": "newTabProfile0", "keys": [ "ctrl+shift+1" ] }, { "command": "newTabProfile1", "keys": [ "ctrl+shift+2" ] }, { "command": "newTabProfile2", "keys": [ "ctrl+shift+3" ] }, { "command": "newTabProfile3", "keys": [ "ctrl+shift+4" ] }, { "command": "newTabProfile4", "keys": [ "ctrl+shift+5" ] }, { "command": "newTabProfile5", "keys": [ "ctrl+shift+6" ] }, { "command": "newTabProfile6", "keys": [ "ctrl+shift+7" ] }, { "command": "newTabProfile7", "keys": [ "ctrl+shift+8" ] }, { "command": "newTabProfile8", "keys": [ "ctrl+shift+9" ] }, { "command": "nextTab", "keys": [ "ctrl+tab" ] }, { "command": "prevTab", "keys": [ "ctrl+shift+tab" ] }, { "command": "openSettings", "keys": [ "ctrl+," ] }, { "command": "scrollDown", "keys": [ "ctrl+shift+down" ] }, { "command": "scrollDownPage", "keys": [ "ctrl+shift+pgdn" ] }, { "command": "scrollUp", "keys": [ "ctrl+shift+up" ] }, { "command": "scrollUpPage", "keys": [ "ctrl+shift+pgup" ] }, { "command": "switchToTab0", "keys": [ "ctrl+1" ] }, { "command": "switchToTab1", "keys": [ "ctrl+2" ] }, { "command": "switchToTab2", "keys": [ "ctrl+3" ] }, { "command": "switchToTab3", "keys": [ "ctrl+4" ] }, { "command": "switchToTab4", "keys": [ "ctrl+5" ] }, { "command": "switchToTab5", "keys": [ "ctrl+6" ] }, { "command": "switchToTab6", "keys": [ "ctrl+7" ] }, { "command": "switchToTab7", "keys": [ "ctrl+8" ] }, { "command": "switchToTab8", "keys": [ "ctrl+9" ] } ], ``` And I just mean getting rid of the terribly redundant white space so that all the keys fit on screen at the same time ... not the fact that these key defaults are clearly superior (who's idea was it to use ALT for switching tabs, anyway?).
claunia commented 2026-01-30 22:39:07 +00:00
Author
Owner
Copy Link

@fedfigca commented on GitHub (Jun 22, 2019):

Yes, please.
If the configuration is going to be via text file, which I'm perfectly fine with, there should be some good information architecture in the layout and order of the items.
IMHO, alphabetic order is not the best way to sort the items here, because it hurts discoverability of all the features and related items, since a human is reading the file, fields like name or guid should come first, and then grouped by what the features modify, layout, colors, fonts, cursors, etc so that the user can find the group it's interested in and explore only those options instead of having to read through some 15 items and figure out what each one is for.

Thanks for the great work, I'm really happy to see it come to reality, it's going to make our developer lives even better.

@fedfigca commented on GitHub (Jun 22, 2019): Yes, please. If the configuration is going to be via text file, which I'm perfectly fine with, there should be some good information architecture in the layout and order of the items. IMHO, alphabetic order is not the best way to sort the items here, because it hurts discoverability of all the features and related items, since a human is reading the file, fields like `name` or `guid` should come first, and then grouped by what the features modify, layout, colors, fonts, cursors, etc so that the user can find the group it's interested in and explore only those options instead of having to read through some 15 items and figure out what each one is for. Thanks for the great work, I'm really happy to see it come to reality, it's going to make our developer lives even better.
claunia commented 2026-01-30 22:39:07 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 1, 2019):

@fedfigca Hopefully this won't be as much of a problem once #754 is complete. The "defaults" file will be in a sane, non-alphabetic order, similar to how they were before #1005. Then, the user settings will be in whatever order the user puts them in.

@zadjii-msft commented on GitHub (Jul 1, 2019): @fedfigca Hopefully this won't be as much of a problem once #754 is complete. The "defaults" file will be in a sane, non-alphabetic order, similar to how they were before #1005. Then, the user settings will be in whatever order the user puts them in.
claunia commented 2026-01-30 22:39:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 24, 2019):

:tada:This issue was addressed in #2515, which has now been successfully released as Windows Terminal Preview v0.5.2661.0.🎉

Handy links:

@ghost commented on GitHub (Sep 24, 2019): :tada:This issue was addressed in #2515, which has now been successfully released as `Windows Terminal Preview v0.5.2661.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.5.2661.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1832
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?