starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Accessibility: NVDA emits errors in WT1.15 preview #18331

New Issue
Closed
opened 2026-01-31 06:10:37 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 06:10:37 +00:00
Owner
Copy Link

Originally created by @LeonarddeR on GitHub (Aug 28, 2022).

Originally assigned to: @carlos-zamora on GitHub.

Windows Terminal version

1.15.2283.0

Windows build number

25188.1000

Other Software

NVDA 2022.2.2

Steps to reproduce

  1. Open bash in windows terminal
  2. type nano /etc/hosts

Expected Behavior

No error in NVDA

Actual Behavior

NVDA emits the following error:

ERROR - NVDAObjects.behaviors.LiveText._monitor (18:21:06.798) - Dynamic_WinTerminalUIAEditableTextWithAutoSelectDetectionUIA._monitorThread (22344):
Error getting or calculating new text
Traceback (most recent call last):
  File "NVDAObjects\behaviors.pyc", line 386, in _monitor
  File "NVDAObjects\behaviors.pyc", line 350, in _getText
  File "diffHandler.pyc", line 62, in _getText
  File "baseObject.pyc", line 26, in __get__
  File "NVDAObjects\UIA\__init__.pyc", line 848, in _get_text
  File "NVDAObjects\UIA\__init__.pyc", line 555, in _getTextFromUIARange
  File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__
_ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None))

I wasn't able to reproduce this with WT1.14, so therefore I'm filing this here since there might be a regression in UIA related code. @codeofdusk could you reproduce this?

Originally created by @LeonarddeR on GitHub (Aug 28, 2022). Originally assigned to: @carlos-zamora on GitHub. ### Windows Terminal version 1.15.2283.0 ### Windows build number 25188.1000 ### Other Software NVDA 2022.2.2 ### Steps to reproduce 1. Open bash in windows terminal 2. type nano /etc/hosts ### Expected Behavior No error in NVDA ### Actual Behavior NVDA emits the following error: ``` ERROR - NVDAObjects.behaviors.LiveText._monitor (18:21:06.798) - Dynamic_WinTerminalUIAEditableTextWithAutoSelectDetectionUIA._monitorThread (22344): Error getting or calculating new text Traceback (most recent call last): File "NVDAObjects\behaviors.pyc", line 386, in _monitor File "NVDAObjects\behaviors.pyc", line 350, in _getText File "diffHandler.pyc", line 62, in _getText File "baseObject.pyc", line 26, in __get__ File "NVDAObjects\UIA\__init__.pyc", line 848, in _get_text File "NVDAObjects\UIA\__init__.pyc", line 555, in _getTextFromUIARange File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__ _ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None)) ``` I wasn't able to reproduce this with WT1.14, so therefore I'm filing this here since there might be a regression in UIA related code. @codeofdusk could you reproduce this?
claunia commented 2026-01-31 06:10:40 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Aug 30, 2022):

I've also seen this, but not with wtNotifications.

This is probably related to broken assumptions when switching to/from the alt buffer.

@codeofdusk commented on GitHub (Aug 30, 2022): I've also seen this, but not with `wtNotifications`. This is probably related to broken assumptions when switching to/from the alt buffer.
claunia commented 2026-01-31 06:10:40 +00:00
Author
Owner
Copy Link

@LeonarddeR commented on GitHub (Sep 1, 2022):

This error indeed has nothing to do with the notifications implementation.

CC @carlos-zamora just want to make sure that this bug doesn't end up in a release, since that would be annoying for many sr users.

@LeonarddeR commented on GitHub (Sep 1, 2022): This error indeed has nothing to do with the notifications implementation. CC @carlos-zamora just want to make sure that this bug doesn't end up in a release, since that would be annoying for many sr users.
claunia commented 2026-01-31 06:10:40 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 1, 2022):

@leonardder (or @codeofdusk since you're familiar with the space) I think I need a little more context here. It looks like NVDA is calling the UIA API GetText() off of a TextRange. That corresponds to the following code in Windows Terminal: f2a691863b/src/types/UiaTextRangeBase.cpp (L954-L1023)

It looks like we emit an error if...

  1. the second parameter (the out param) wasn't provided properly
  2. the first parameter (dictating the max length) is less than -1
  3. the newly created terminal content isn't fully initialized yet
  4. we're out of memory and we can't create the string result to return
  5. (as @codeofdusk said) the text range points to content that doesn't exist (this is a quick-n-easy way to invalidate a text range that was on the alt buffer when we're now on the main buffer)

I assume the main culprit here is number 5, but to be certain, could you provide the following:

  • What UIA APIs was NVDA calling? Obviously GetText() is the one that returns an error, but what were the calls leading up to that.
  • If you can explain how I can get a trace from NVDA, that'd be even better.
@carlos-zamora commented on GitHub (Sep 1, 2022): @leonardder (or @codeofdusk since you're familiar with the space) I think I need a little more context here. It looks like NVDA is calling the UIA API `GetText()` off of a `TextRange`. That corresponds to the following code in Windows Terminal: https://github.com/microsoft/terminal/blob/f2a691863bb4add22d225ca4f912345eb815a8d9/src/types/UiaTextRangeBase.cpp#L954-L1023 It looks like we emit an error if... 1. the second parameter (the out param) wasn't provided properly 2. the first parameter (dictating the max length) is less than -1 3. the newly created terminal content isn't fully initialized yet 4. we're out of memory and we can't create the string result to return 5. (as @codeofdusk said) the text range points to content that doesn't exist (this is a quick-n-easy way to invalidate a text range that was on the alt buffer when we're now on the main buffer) I assume the main culprit here is number 5, but to be certain, could you provide the following: - What UIA APIs was NVDA calling? Obviously `GetText()` is the one that returns an error, but what were the calls leading up to that. - If you can explain how I can get a trace from NVDA, that'd be even better.
claunia commented 2026-01-31 06:10:40 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 1, 2022):

Yeah, that error code is E_FAIL so it's 100% that alt buffer thing.

@carlos-zamora commented on GitHub (Sep 1, 2022): Yeah, that error code is `E_FAIL` so it's 100% that alt buffer thing.
claunia commented 2026-01-31 06:10:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13907, which has now been successfully released as Windows Terminal v1.15.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13907, which has now been successfully released as `Windows Terminal v1.15.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 06:10:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13907, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13907, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Issue-Bug Needs-Tag-Fix Needs-Triage Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?