Don't constantly repaint if a pixel shader doesn't reference time #18355

Closed
opened 2026-01-31 06:11:17 +00:00 by claunia · 2 comments
Owner

Originally created by @zadjii-msft on GitHub (Sep 1, 2022).

Originally assigned to: @DHowett on GitHub.

image
image

technically it could be time ,Time, tiempo or anything, right? in the shader, its just the 0th float in PixelShaderSettings yea?

right we'd use it by index instead of name

Originally created by @zadjii-msft on GitHub (Sep 1, 2022). Originally assigned to: @DHowett on GitHub. ![image](https://user-images.githubusercontent.com/18356694/187975473-e71e870a-9390-4353-834c-343e8b03ed24.png) ![image](https://user-images.githubusercontent.com/18356694/187975497-30509c32-0aca-4aa9-92dc-3df49e7a9d7e.png) > technically it could be `time` ,`Time`, `tiempo` or anything, right? in the shader, its just the 0th float in `PixelShaderSettings` yea? > right we'd use it by index instead of name
Author
Owner

@DHowett commented on GitHub (Sep 1, 2022):

I figured I'd take a crack at this for Atlas today

@DHowett commented on GitHub (Sep 1, 2022): I figured I'd take a crack at this for Atlas today
Author
Owner

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13903, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13903, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18355