starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Removed shortcuts for starting new sessions is not reflected in new-session dropdown #18401

New Issue
Closed
opened 2026-01-31 06:12:45 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 06:12:45 +00:00
Owner
Copy Link

Originally created by @vermiculus on GitHub (Sep 8, 2022).

Windows Terminal version

1.14.2281.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  1. Have at least four (or some number of) profiles configured.
  2. Remove default keybindings like ctrl+shift+4 and make sure customizations are applied.
  3. Click dropdown to launch a new shell.

Expected Behavior

I would expect to not see ctrl+shift+4 to be advertised as bound.

Actual Behavior

You will see ctrl+shift+4 still advertised as bound.

image

Keybindings were removed from the right-hand side and are still visible in the drop-down. The keybindings don't work, as expected, but they are still being advertised.

Originally created by @vermiculus on GitHub (Sep 8, 2022). ### Windows Terminal version 1.14.2281.0 ### Windows build number 10.0.19044.0 ### Other Software _No response_ ### Steps to reproduce 1. Have at least four (or some number of) profiles configured. 1. Remove default keybindings like `ctrl+shift+4` and make sure customizations are applied. 2. Click dropdown to launch a new shell. ### Expected Behavior I would expect to not see `ctrl+shift+4` to be advertised as bound. ### Actual Behavior You will see `ctrl+shift+4` still advertised as bound. ![image](https://user-images.githubusercontent.com/2082195/189015738-6727dd63-1044-40be-a429-27ff8966e0de.png) Keybindings were removed from the right-hand side and are still visible in the drop-down. The keybindings don't work, as expected, but they are still being advertised.
claunia commented 2026-01-31 06:12:47 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 8, 2022):

Thanks for the report!

@carlos-zamora, this is probably a layering/masking issue. The shortcuts exist on the lower layer (defaults.json) but have been unbound on the upper layer (settings.json).

@DHowett commented on GitHub (Sep 8, 2022): Thanks for the report! @carlos-zamora, this is probably a layering/masking issue. The shortcuts exist on the lower layer (defaults.json) but have been unbound on the upper layer (settings.json).
claunia commented 2026-01-31 06:12:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 8, 2022):

Shockingly, this isn't a test for this case.

    void KeyBindingsTests::TestUnbindReverseLookup()
    {
        Log::Comment(L"TODO!");

        // Wrap the first one in `R"!(...)!"` because it has `()` internally.
        const std::string bindings0String{ R"!([ { "command": { "action": "newTab", "index": 0 }, "keys":"ctrl+a" } ])!" };
        const std::string bindings1String{ R"([ { "keys": "ctrl+a", "command": null } ])" };

        const auto bindings0Json = VerifyParseSucceeded(bindings0String);
        const auto bindings1Json = VerifyParseSucceeded(bindings1String);

        auto actionMap = winrt::make_self<implementation::ActionMap>();
        VERIFY_ARE_EQUAL(0u, actionMap->_KeyMap.size());

        actionMap->LayerJson(bindings0Json);
        VERIFY_ARE_EQUAL(1u, actionMap->_KeyMap.size());

        NewTerminalArgs newTerminalArgs{ 0 };
        NewTabArgs newTabArgs{ newTerminalArgs };
        {
            auto keyChord{ actionMap->GetKeyBindingForAction(ShortcutAction::NewTab, newTabArgs) };
            VERIFY_IS_NOT_NULL(keyChord);
        }

        actionMap->LayerJson(bindings1Json);

        {
            auto keyChord{ actionMap->GetKeyBindingForAction(ShortcutAction::NewTab, newTabArgs) };
            VERIFY_IS_NULL(keyChord);
        }
    }

This actually does pass today on main, so there's gotta be some parenting trickiness that causes this to fail

@zadjii-msft commented on GitHub (Sep 8, 2022): Shockingly, this _isn't_ a test for this case. ```c++ void KeyBindingsTests::TestUnbindReverseLookup() { Log::Comment(L"TODO!"); // Wrap the first one in `R"!(...)!"` because it has `()` internally. const std::string bindings0String{ R"!([ { "command": { "action": "newTab", "index": 0 }, "keys":"ctrl+a" } ])!" }; const std::string bindings1String{ R"([ { "keys": "ctrl+a", "command": null } ])" }; const auto bindings0Json = VerifyParseSucceeded(bindings0String); const auto bindings1Json = VerifyParseSucceeded(bindings1String); auto actionMap = winrt::make_self<implementation::ActionMap>(); VERIFY_ARE_EQUAL(0u, actionMap->_KeyMap.size()); actionMap->LayerJson(bindings0Json); VERIFY_ARE_EQUAL(1u, actionMap->_KeyMap.size()); NewTerminalArgs newTerminalArgs{ 0 }; NewTabArgs newTabArgs{ newTerminalArgs }; { auto keyChord{ actionMap->GetKeyBindingForAction(ShortcutAction::NewTab, newTabArgs) }; VERIFY_IS_NOT_NULL(keyChord); } actionMap->LayerJson(bindings1Json); { auto keyChord{ actionMap->GetKeyBindingForAction(ShortcutAction::NewTab, newTabArgs) }; VERIFY_IS_NULL(keyChord); } } ``` This actually does pass today on main, so there's gotta be some parenting trickiness that causes this to fail
claunia commented 2026-01-31 06:12:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 8, 2022):

This is a test however: dev/migrie/b/13943-a-test-for-this

@zadjii-msft commented on GitHub (Sep 8, 2022): _This_ is a test however: [`dev/migrie/b/13943-a-test-for-this`](https://github.com/microsoft/terminal/compare/dev/migrie/b/13943-a-test-for-this)
claunia commented 2026-01-31 06:12:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 24, 2023):

ignore me, just adding some keywords: new tab key keys shortcut shortcuts menu bindings

@zadjii-msft commented on GitHub (May 24, 2023): ignore me, just adding some keywords: new tab key keys shortcut shortcuts menu bindings
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?