starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.16] Pressing enter with a selection no longer sends Enter #18405

New Issue
Closed
opened 2026-01-31 06:12:58 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 06:12:58 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Sep 9, 2022).

Possibly worth calling out in a relnote. I just stumbled over this because our default key binding for Enter is now Copy, and I didn't realize I had relied on Enter to send Enter even with a selection active.

Originally created by @DHowett on GitHub (Sep 9, 2022). Possibly worth calling out in a relnote. I just stumbled over this because our default key binding for Enter is now Copy, and I didn't realize I had relied on Enter to send Enter even with a selection active.
claunia commented 2026-01-31 06:12:59 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 4, 2022):

  • copyOnSelect should make Enter be ignored? Unbind it?

  • if copyOnSelect, copy keybindings should be passed through?

  • ctrl+c and Enter behave differently

    • see how we handle ctrl+c (used to be in TermControl, probably Interactivity now?), and make sure Enter (or really all kbds) are handled similarly (see _selectionNeedsToBeCopied)

  • compare Mark Mode to mouse selection with copyOnSelect

@carlos-zamora commented on GitHub (Oct 4, 2022): - `copyOnSelect` should make `Enter` be ignored? Unbind it? - if `copyOnSelect`, `copy` keybindings should be passed through? - ctrl+c and Enter behave differently - see how we handle ctrl+c (used to be in TermControl, probably Interactivity now?), and make sure Enter (or really all kbds) are handled similarly (see `_selectionNeedsToBeCopied`) - compare Mark Mode to mouse selection with `copyOnSelect`
claunia commented 2026-01-31 06:13:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 2, 2022):

We cool just moving this one to a docs bug/? Haven't had complaints about this in the 1.16 preview timeframe yet.

See https://github.com/MicrosoftDocs/terminal/issues/618

@zadjii-msft commented on GitHub (Dec 2, 2022): We cool just moving this one to a docs bug/? Haven't had complaints about this in the 1.16 preview timeframe yet. See https://github.com/MicrosoftDocs/terminal/issues/618
claunia commented 2026-01-31 06:13:00 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 6, 2022):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Dec 6, 2022): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:13:00 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 6, 2022):

Preview is pretty small, so we should be careful about drawing non-crash conclusions. But, yes.

@DHowett commented on GitHub (Dec 6, 2022): Preview is pretty small, so we should be careful about drawing non-crash conclusions. But, yes.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Interaction Issue-Bug Needs-Attention Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?