starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

one line moved up when maximizing Terminal #18419

New Issue
Closed
opened 2026-01-31 06:13:22 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:13:22 +00:00
Owner
Copy Link

Originally created by @jackyzy823 on GitHub (Sep 10, 2022).

Windows Terminal version

1.14.2281.0

Windows build number

10.0.19042.1526

Other Software

No response

Steps to reproduce

Make Terminal in maximized status and prompt in the last line
before

Then just minimize and maximize by click Taskbar twice

after

It is obviously a line moved up.

Then just type some char
afterandinput

Repeat above steps
afterandinput_repeat

Expected Behavior

The prompt still in the last line , not automatically (wrongly) move up one line after maximize.

Actual Behavior

It moves up one line.

Originally created by @jackyzy823 on GitHub (Sep 10, 2022). ### Windows Terminal version 1.14.2281.0 ### Windows build number 10.0.19042.1526 ### Other Software _No response_ ### Steps to reproduce Make Terminal in **maximized status** and prompt in the last line ![before](https://user-images.githubusercontent.com/2900871/189484638-6b1eb2a9-10c7-4a4c-a3af-ad6a02dd9feb.PNG) Then just **minimize** and **maximize** by click Taskbar twice ![after](https://user-images.githubusercontent.com/2900871/189484664-b4155d3c-89df-4f9e-abc7-045a4ed77b05.PNG) It is obviously a line moved up. Then just type some char ![afterandinput](https://user-images.githubusercontent.com/2900871/189484679-40deb12d-af17-448e-88bf-fc6f1b113d64.PNG) Repeat above steps ![afterandinput_repeat](https://user-images.githubusercontent.com/2900871/189484681-78f1e837-c51d-405b-a76e-7c8998199eee.PNG) ### Expected Behavior The prompt still in the last line , not automatically (wrongly) move up one line after maximize. ### Actual Behavior It moves up one line.
claunia commented 2026-01-31 06:13:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 22, 2023):

Some cursory notes:

  • The PsReadline cursor position is wrong, but that was fixed in a more recent psreadline build.
  • Why is the Terminal resizing though? That's weird. Just maximizing / minimizing the Terminal shouldn't resize the window. It should just swap between the two states. Weird.
@zadjii-msft commented on GitHub (Mar 22, 2023): Some cursory notes: * The PsReadline cursor position is wrong, but that was fixed in a more recent psreadline build. * Why is the Terminal resizing though? That's weird. Just maximizing / minimizing the Terminal shouldn't resize the window. It should just swap between the two states. Weird.
claunia commented 2026-01-31 06:13:25 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Apr 6, 2024):

This has been annoying me recently, so I tried to find out what was causing the issue, and it looks to me like it might be the XAML framework that is giving us the wrong size. When I minimize the terminal, I receive a height in the ControlCore::SizeChanged handler that is 8 pixels smaller than what it should be (this translates to 16 device pixels, since my display scaling is 200%).

I don't know if this is something we can fix, but as a workaround, I've discovered that you can prevent it from triggering a scroll just by tweaking the window padding. The idea is to adjust the available height so that the maximized size and minimized size both round down to the same number of rows.

As an example on my system, using device pixels, the original panel height was 1857, which allowed for 50 rows with a 37 pixel cell height. The minimized height was 1841, which only allowed for 49 rows. It was that difference in row count that caused it to scroll up a line.

But after adjusting the padding, I was able to get the base height down to 1846, which results in a minimized height of 1830. Since both of those can fit 49 rows with a 37 pixel cell height, there is no longer a change in row count when minimizing and maximizing, so it doesn't trigger a scroll.

The amount of padding you need to add will obviously depend on your screen size and font size, but if you're desperate enough to fix the issue, you can just keep adjusting the padding 1 pixel at a time until it eventually works (hopefully).

@j4james commented on GitHub (Apr 6, 2024): This has been annoying me recently, so I tried to find out what was causing the issue, and it looks to me like it might be the XAML framework that is giving us the wrong size. When I minimize the terminal, I receive a height in the `ControlCore::SizeChanged` handler that is 8 pixels smaller than what it should be (this translates to 16 device pixels, since my display scaling is 200%). I don't know if this is something we can fix, but as a workaround, I've discovered that you can prevent it from triggering a scroll just by tweaking the window padding. The idea is to adjust the available height so that the maximized size and minimized size both round down to the same number of rows. As an example on my system, using device pixels, the original panel height was 1857, which allowed for 50 rows with a 37 pixel cell height. The minimized height was 1841, which only allowed for 49 rows. It was that difference in row count that caused it to scroll up a line. But after adjusting the padding, I was able to get the base height down to 1846, which results in a minimized height of 1830. Since both of those can fit 49 rows with a 37 pixel cell height, there is no longer a change in row count when minimizing and maximizing, so it doesn't trigger a scroll. The amount of padding you need to add will obviously depend on your screen size and font size, but if you're desperate enough to fix the issue, you can just keep adjusting the padding 1 pixel at a time until it eventually works (hopefully).
claunia commented 2026-01-31 06:13:26 +00:00
Author
Owner
Copy Link

@tusharsnx commented on GitHub (Apr 9, 2024):

size-change-maximized-minimized

Under Minimized state, we go into Window mode styling that adds extra padding at the top.

@tusharsnx commented on GitHub (Apr 9, 2024): ![size-change-maximized-minimized](https://github.com/microsoft/terminal/assets/55626797/019ca689-8960-49b1-9675-4cfe0af14fd0) Under Minimized state, we go into Window mode styling that adds extra padding at the top.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl In-PR Issue-Bug Needs-Repro Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?