starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Using double-size characters can cause the Atlas engine to crash #18420

New Issue
Closed
opened 2026-01-31 06:13:27 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:13:27 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Sep 10, 2022).

Windows Terminal version

Commit 3e6abd37df

Windows build number

10.0.19044.1889

Other Software

Vttest

Steps to reproduce

  1. Make sure the Atlas renderer is enabled.
  2. Open a WSL shell.
  3. Run Vttest, and select option 4, the "Test of double-size characters".
  4. While the first test page is visible, open the terminal settings.
  5. Without changing anything click Save and then close the settings.

Expected Behavior

No crash.

Actual Behavior

The app crashes with:

Unhandled exception thrown: write access violation.
it->_Ptr->_Next->**_Prev** was 0x7FFE52FDE460.

and the stack trace:

>	Microsoft.Terminal.Control.dll!Microsoft::Console::Render::AtlasEngine::StartPaint() Line 280	C++
 	Microsoft.Terminal.Control.dll!Microsoft::Console::Render::Renderer::_PaintFrameForEngine(Microsoft::Console::Render::IRenderEngine * const pEngine) Line 121	C++
 	Microsoft.Terminal.Control.dll!Microsoft::Console::Render::RenderThread::_ThreadProc() Line 214	C++
 	[External Code]

Sometimes the crash occurs elsewhere, but it always seems to be something with the _Prev pointer being null or pointing somewhere inaccessible.

Originally created by @j4james on GitHub (Sep 10, 2022). ### Windows Terminal version Commit 3e6abd37df192d969088188ce836edbf645b13b4 ### Windows build number 10.0.19044.1889 ### Other Software [Vttest](https://www.invisible-island.net/vttest/) ### Steps to reproduce 1. Make sure the Atlas renderer is enabled. 2. Open a WSL shell. 3. Run _Vttest_, and select option 4, the "Test of double-size characters". 4. While the first test page is visible, open the terminal settings. 5. Without changing anything click _Save_ and then close the settings. ### Expected Behavior No crash. ### Actual Behavior The app crashes with: ``` Unhandled exception thrown: write access violation. it->_Ptr->_Next->**_Prev** was 0x7FFE52FDE460. ``` and the stack trace: ``` > Microsoft.Terminal.Control.dll!Microsoft::Console::Render::AtlasEngine::StartPaint() Line 280 C++ Microsoft.Terminal.Control.dll!Microsoft::Console::Render::Renderer::_PaintFrameForEngine(Microsoft::Console::Render::IRenderEngine * const pEngine) Line 121 C++ Microsoft.Terminal.Control.dll!Microsoft::Console::Render::RenderThread::_ThreadProc() Line 214 C++ [External Code] ``` Sometimes the crash occurs elsewhere, but it always seems to be something with the `_Prev` pointer being null or pointing somewhere inaccessible.
claunia commented 2026-01-31 06:13:28 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Sep 10, 2022):

I can sometimes reproduce this with a simple printf "\e#3Test\n", but that may require opening and closing the settings more than once. I'm not exactly sure what is triggering it, so maybe there is an aspect of randomness involved.

As a wild guess, could it be that the Atlas engine can't cope with the fact that double-width lines only contain half the number of buffer cells as a full width line?

@j4james commented on GitHub (Sep 10, 2022): I can sometimes reproduce this with a simple `printf "\e#3Test\n"`, but that may require opening and closing the settings more than once. I'm not exactly sure what is triggering it, so maybe there is an aspect of randomness involved. As a wild guess, could it be that the Atlas engine can't cope with the fact that double-width lines only contain half the number of buffer cells as a full width line?
claunia commented 2026-01-31 06:13:29 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 11, 2022):

As a wild guess, could it be that the Atlas engine can't cope with the fact that double-width lines only contain half the number of buffer cells as a full width line?

Yeah that sounds quite likely unfortunately.

@lhecker commented on GitHub (Sep 11, 2022): > As a wild guess, could it be that the Atlas engine can't cope with the fact that double-width lines only contain half the number of buffer cells as a full width line? Yeah that sounds quite likely unfortunately.
claunia commented 2026-01-31 06:13:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 23, 2022):

:tada:This issue was addressed in #13966, which has now been successfully released as Windows Terminal Preview v1.16.2641.0.🎉

Handy links:

@ghost commented on GitHub (Sep 23, 2022): :tada:This issue was addressed in #13966, which has now been successfully released as `Windows Terminal Preview v1.16.2641.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.2641.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-AtlasEngine Issue-Bug Needs-Tag-Fix Needs-Triage Priority-2 Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?