starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add subtext to why Always show tabs is not toggleable in SUI #18438

New Issue
Closed
opened 2026-01-31 06:13:59 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 06:13:59 +00:00
Owner
Copy Link

Originally created by @elsaco on GitHub (Sep 14, 2022).

Windows Terminal version

1.16.2523.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

Open Appearance in SUI and select Always show tabs

Expected Behavior

Always show tabs option to be toggleable

Actual Behavior

Control is grayed out and set to On:

alwasy_show_tabs

Originally created by @elsaco on GitHub (Sep 14, 2022). ### Windows Terminal version 1.16.2523.0 ### Windows build number 10.0.19044.0 ### Other Software _No response_ ### Steps to reproduce Open `Appearance` in SUI and select `Always show tabs` ### Expected Behavior `Always show tabs` option to be toggleable ### Actual Behavior Control is grayed out and set to `On`: ![alwasy_show_tabs](https://user-images.githubusercontent.com/3933920/190029900-cf79af06-81b2-486f-8efd-328728ec9075.PNG)
claunia commented 2026-01-31 06:14:02 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 14, 2022):

You cannot turn off the display of tabs while "show tabs in titlebar" is turned on.

@DHowett commented on GitHub (Sep 14, 2022): You cannot turn off the display of tabs while "show tabs in titlebar" is turned on.
claunia commented 2026-01-31 06:14:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 14, 2022):

We probably should have some sub-text that appears when in this case to indicate why it's forced on. Or at least additional text that clarifies "This setting cannot be disabled while 'Hide the titlebar' is enabled."

@zadjii-msft commented on GitHub (Sep 14, 2022): We probably should have some sub-text that appears when in this case to indicate why it's forced on. Or at least additional text that clarifies "This setting cannot be disabled while 'Hide the titlebar' is enabled."
claunia commented 2026-01-31 06:14:03 +00:00
Author
Owner
Copy Link

@elsaco commented on GitHub (Sep 15, 2022):

Thank you @DHowett. I wouldn't have guessed that Hide the title bar needs to be off before Always show tabs control becomes active. Some clue in the SUI would be helpful, as suggested by @zadjii-msft

@elsaco commented on GitHub (Sep 15, 2022): Thank you @DHowett. I wouldn't have guessed that `Hide the title bar` needs to be off before `Always show tabs` control becomes active. Some clue in the SUI would be helpful, as suggested by @zadjii-msft
claunia commented 2026-01-31 06:14:03 +00:00
Author
Owner
Copy Link

@BenConstable9 commented on GitHub (Oct 19, 2022):

Looking at how PowerToys handles a scenario like this:

image

Would this be acceptable? If so, happy to make PR.

@BenConstable9 commented on GitHub (Oct 19, 2022): Looking at how PowerToys handles a scenario like this: ![image](https://user-images.githubusercontent.com/15877083/196692876-e5e9cd7f-73ec-4f87-82cd-d4ddac862bda.png) Would this be acceptable? If so, happy to make PR.
claunia commented 2026-01-31 06:14:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 27, 2023):

@BenConstable9 I love your suggestion - sorry, I never said that and let this thread go dark - and it fits in with how we're going to pivot title bar appearance into the theming UI in the future.

I'd love to see how it turns out if you do choose to PR it.

@DHowett commented on GitHub (Jan 27, 2023): @BenConstable9 I love your suggestion - sorry, I never said that and let this thread go dark - and it fits in with how we're going to pivot title bar appearance into the theming UI in the future. I'd love to see how it turns out if you do choose to PR it.
claunia commented 2026-01-31 06:14:04 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 7, 2023):

Adding text is easy enough.

image
@jamespack commented on GitHub (Apr 7, 2023): Adding text is easy enough. <img width="863" alt="image" src="https://user-images.githubusercontent.com/2086722/230632282-29d5f2a0-b780-4b71-863e-0ba4c0b0cb8d.png">
claunia commented 2026-01-31 06:14:04 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 7, 2023):

Happy to PR it if you are good with that verbiage

@jamespack commented on GitHub (Apr 7, 2023): Happy to PR it if you are good with that verbiage
claunia commented 2026-01-31 06:14:04 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 7, 2023):

Works for me!

We may want to note in the <comment> for that translation that it is referring to another setting (and include the localization key for that setting too)

@DHowett commented on GitHub (Apr 7, 2023): Works for me! We may want to note in the `<comment>` for that translation that it is referring to another setting (and include the localization key for that setting too)
claunia commented 2026-01-31 06:14:04 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 10, 2023):

Ok PR opened.

@jamespack commented on GitHub (Apr 10, 2023): Ok PR opened.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI good first issue Help Wanted In-PR Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18438
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?