starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

SettingsModelLocalTests failures are on the rise #18517

New Issue
Closed
opened 2026-01-31 06:16:29 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:16:29 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Sep 21, 2022).

Windows Terminal version

Commit 1ce22a87e6

Windows build number

10.0.19044.1889

Other Software

No response

Steps to reproduce

!. Check out a recent version of the project.
2. Build it.
3. Run the unit tests.

Expected Behavior

All tests should pass.

Actual Behavior

A number of SettingsModelLocalTests are failing:

SettingsModelLocalTests::DeserializationTests::TestCloseOnExitParsing [Failed]
SettingsModelLocalTests::SerializationTests::Profile [Failed]
SettingsModelLocalTests::SerializationTests::Actions [Failed]
SettingsModelLocalTests::SerializationTests::LegacyFontSettings [Failed]

If I remember correctly, the first one has been around for a while now. I'm afraid I've just been ignoring it and hoping somebody else would notice. The others I think are fairly recent. Although I may be misremembering which are old and which are new.

Originally created by @j4james on GitHub (Sep 21, 2022). ### Windows Terminal version Commit 1ce22a87e6fc204b5fd98642723aa0a51a503749 ### Windows build number 10.0.19044.1889 ### Other Software _No response_ ### Steps to reproduce !. Check out a recent version of the project. 2. Build it. 3. Run the unit tests. ### Expected Behavior All tests should pass. ### Actual Behavior A number of `SettingsModelLocalTests` are failing: SettingsModelLocalTests::DeserializationTests::TestCloseOnExitParsing [Failed] SettingsModelLocalTests::SerializationTests::Profile [Failed] SettingsModelLocalTests::SerializationTests::Actions [Failed] SettingsModelLocalTests::SerializationTests::LegacyFontSettings [Failed] If I remember correctly, the first one has been around for a while now. I'm afraid I've just been ignoring it and hoping somebody else would notice. The others I think are fairly recent. Although I may be misremembering which are old and which are new.
claunia commented 2026-01-31 06:16:30 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Sep 21, 2022):

Looking at the test logs for those last three, it seems the failures are a result of a change in serialization of the font size from int to float (I suspect PR #14013).

The older one I suspect is the result of the new Automatic mode for CloseOnExit (PR #13560).

@j4james commented on GitHub (Sep 21, 2022): Looking at the test logs for those last three, it seems the failures are a result of a change in serialization of the font size from int to float (I suspect PR #14013). The older one I suspect is the result of the new `Automatic` mode for `CloseOnExit` (PR #13560).
claunia commented 2026-01-31 06:16:30 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 21, 2022):

I keep forgetting that we don't run them in the CI... 😞

@lhecker commented on GitHub (Sep 21, 2022): I keep forgetting that we don't run them in the CI... 😞
claunia commented 2026-01-31 06:16:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14064, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14064, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18517
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?