Entering the Settings menu in fullscreen can become stuck due to disabled keybinds #18522

@Swinkid commented on GitHub (Mar 16, 2023):

@raethkcj Can you try using F11 to escape? I've just tried to replicate your issue and was able to escape using the F11 key... unless you've remapped it maybe?

@Swinkid commented on GitHub (Mar 16, 2023): @raethkcj Can you try using F11 to escape? I've just tried to replicate your issue and was able to escape using the F11 key... unless you've remapped it maybe?

claunia commented

@raethkcj commented on GitHub (Mar 19, 2023):

F11 does indeed work, but was not what I used to enter fullscreen mode. There's no intuitive reason for two keybinds for the exact same function to work differently.

@raethkcj commented on GitHub (Mar 19, 2023): F11 does indeed work, but was not what I used to enter fullscreen mode. There's no intuitive reason for two keybinds for the exact same function to work differently.

claunia commented

@Swinkid commented on GitHub (Mar 20, 2023):

F11 does indeed work, but was not what I used to enter fullscreen mode. There's no intuitive reason for two keybinds for the exact same function to work differently.

I totally agree. @zadjii-msft thoughts on how this can be changed? Willing to assist implementation....

@Swinkid commented on GitHub (Mar 20, 2023): > F11 does indeed work, but was not what I used to enter fullscreen mode. There's no intuitive reason for two keybinds for the exact same function to work differently. I totally agree. @zadjii-msft thoughts on how this can be changed? Willing to assist implementation....

claunia commented

@zadjii-msft commented on GitHub (Mar 20, 2023):

Hmm. That's a good question. #10121 looks like where we hooked up the keybindings / actions to the settings UI. Maybe the closeTab handler checks to see if the selected tab is a TerminalTab, and the settings tab fails that...

@zadjii-msft commented on GitHub (Mar 20, 2023): Hmm. That's a good question. #10121 looks like where we hooked up the keybindings / actions to the settings UI. Maybe the closeTab handler checks to see if the selected tab is a `TerminalTab`, and the settings tab fails that...

claunia commented

@zadjii-msft commented on GitHub (Mar 20, 2023):

Hmm. There's nothing in TerminalPage::_HandleCloseTab that immediately jumps out as what's wrong here. I'd probably step through that with a debugger and see what's wrong.

@zadjii-msft commented on GitHub (Mar 20, 2023): Hmm. There's nothing in `TerminalPage::_HandleCloseTab` that immediately jumps out as what's wrong here. I'd probably step through that with a debugger and see what's wrong.

claunia commented

210414e5a8/src/cascadia/TerminalSettingsModel/defaults.json (L379)
?

@michalnpl commented on GitHub (Apr 21, 2023):

Isn't Ctrl+w not working because by default because of

When changed to

{ "command": "closeTab", "keys": "ctrl+w" },

and regenerate \src\cascadia\TerminalSettingsModel\Generated Files\defaults.h it works just fine with described workflow.

However, pressing Alt on settings page (fullscreen or not) freezes the UI because the program seems to go into infinite loop infinite loop here:

210414e5a8/src/cascadia/TerminalApp/TerminalWindow.cpp (L883)

@michalnpl commented on GitHub (Apr 21, 2023): Isn't **Ctrl+w** not working because by default because of https://github.com/microsoft/terminal/blob/210414e5a8182eaa3e7f1ed2d07da50edf80e242/src/cascadia/TerminalSettingsModel/defaults.json#L379 ? When changed to ` { "command": "closeTab", "keys": "ctrl+w" },` and regenerate **\src\cascadia\TerminalSettingsModel\Generated Files\defaults.h** it works just fine with described workflow. However, pressing **Alt** on settings page (fullscreen or not) freezes the UI because the program seems to go into infinite loop infinite loop here: https://github.com/microsoft/terminal/blob/210414e5a8182eaa3e7f1ed2d07da50edf80e242/src/cascadia/TerminalApp/TerminalWindow.cpp#L883

claunia commented

@zadjii-msft commented on GitHub (Apr 21, 2023):

However, pressing Alt on settings page (fullscreen or not) freezes the UI because the program seems to go into infinite loop infinite loop

wat

That doesn't make sense

ah butts.

in #15189 we should have added a break after the focusedObject = _root.try_as(); line.

@zadjii-msft commented on GitHub (Apr 21, 2023): > However, pressing Alt on settings page (fullscreen or not) freezes the UI because the program seems to go into infinite loop infinite loop wat That doesn't make sense ah butts. in #15189 we should have added a `break` after the `focusedObject = _root.try_as();` line.

claunia commented

@michalnpl commented on GitHub (Apr 21, 2023):

@zadjii-msft I tried adding the necessary breaks, and Alt no longer freezes the settings page, but Alt+Enter will not make it go fullscreen.

Separately, when you try F11 on the settings page to go full screen, there will be Access violation reading location 0x0000000000000000, but that's unrelated, and I already have a fix for that; I just need to file an issue and can submit a PR.

@michalnpl commented on GitHub (Apr 21, 2023): @zadjii-msft I tried adding the necessary breaks, and **Alt** no longer freezes the settings page, but **Alt+Enter** will not make it go fullscreen. Separately, when you try F11 on the settings page to go full screen, there will be **Access violation reading location 0x0000000000000000**, but that's unrelated, and I already have a fix for that; I just need to file an issue and can submit a PR.

claunia commented

@zadjii-msft commented on GitHub (Apr 21, 2023):

Oh there's also a crash on trying to closeTab from the SUI tab. From #15196. That's a easy fix though

@zadjii-msft commented on GitHub (Apr 21, 2023): Oh there's also a crash on trying to closeTab from the SUI tab. From #15196. That's a easy fix though

claunia commented

@zadjii-msft commented on GitHub (Apr 21, 2023):

After fixing that crash though, I can't repro the original bug (Close the settings tab via closeTab bound to Ctrl+w). I dunno where this was fixed, I dunno if we really need to bisect it though. Might have just been #15189.

@zadjii-msft commented on GitHub (Apr 21, 2023): After fixing that crash though, I can't repro the original bug (Close the settings tab via `closeTab` bound to <kbd>Ctrl+w</kbd>). I dunno where this was fixed, I dunno if we really need to bisect it though. Might have just been #15189.

claunia commented

@michalnpl commented on GitHub (Apr 21, 2023):

I still can't close the tab with ctrl+w after fixing the crash because, in the main branch, there is no "ctrl+w" binding in defaults.json.

@michalnpl commented on GitHub (Apr 21, 2023): I still can't close the tab with **ctrl+w** after fixing the crash because, in the main branch, there is no "ctrl+w" binding in [**defaults.json**](https://github.com/microsoft/terminal/blob/210414e5a8182eaa3e7f1ed2d07da50edf80e242/src/cascadia/TerminalSettingsModel/defaults.json).

claunia commented

@zadjii-msft commented on GitHub (Apr 21, 2023):

I mean, sure. I'm assuming OP added the closeTab binding themselves to their settings.json.

@zadjii-msft commented on GitHub (Apr 21, 2023): I mean, sure. I'm assuming OP added the closeTab binding themselves to their `settings.json`.

claunia commented

@michalnpl commented on GitHub (Apr 21, 2023):

Yup, when it is added, it works just fine.

@michalnpl commented on GitHub (Apr 21, 2023): Yup, when it is added, it works just fine.

claunia commented