starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Atlas Engine: Way to get back spaces between lines? #18534

New Issue
Closed
opened 2026-01-31 06:16:57 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:16:57 +00:00
Owner
Copy Link

Originally created by @leimath on GitHub (Sep 24, 2022).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.16.220921001-preview

Windows build number

10.0.19044.0

Other Software

helix-editor

Steps to reproduce

Font: Overpass Mono

Expected Behavior

without atlas terminal

2022-09-24-000125

This is without Atlas Engine in the current terminal preview. In the helix editor there are some space around the 1.

Actual Behavior

with atlas engine

2022-09-24-000126

This is with Atlas Engine, latest terminal preview.

A small query -
Is there a way to get back the space above the 1? I understand that it is intentional that line-gaps are intentionally ignored as per the release notes. Or is there any advantage over not having the space around the one?

Originally created by @leimath on GitHub (Sep 24, 2022). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.16.220921001-preview ### Windows build number 10.0.19044.0 ### Other Software [helix-editor](https://github.com/helix-editor/helix) ### Steps to reproduce Font: [Overpass Mono](https://github.com/RedHatOfficial/Overpass) ### Expected Behavior ![without atlas terminal](https://user-images.githubusercontent.com/96306150/192085377-e0366cda-2557-4b1c-98f0-78d74eeb5863.jpg) ![2022-09-24-000125](https://user-images.githubusercontent.com/96306150/192086078-ebbdbbbc-a21d-464b-8ec8-8d822ec272c5.jpg) This is without Atlas Engine in the current terminal preview. In the helix editor there are some space around the 1. ### Actual Behavior ![with atlas engine](https://user-images.githubusercontent.com/96306150/192085388-b985e6e0-ea85-4e84-9680-ae2edc2d138b.jpg) ![2022-09-24-000126](https://user-images.githubusercontent.com/96306150/192086098-3a2b9768-7e93-4289-ab2e-98de0e50f644.jpg) This is with Atlas Engine, latest terminal preview. A small query - Is there a way to get back the space above the 1? I understand that it is intentional that line-gaps are intentionally ignored as per the release notes. Or is there any advantage over not having the space around the one?
claunia commented 2026-01-31 06:16:58 +00:00
Author
Owner
Copy Link

@leimath commented on GitHub (Sep 24, 2022):

Please close the issue if I misunderstood this feature.

@leimath commented on GitHub (Sep 24, 2022): Please close the issue if I misunderstood this feature.
claunia commented 2026-01-31 06:16:59 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Sep 24, 2022):

It's somewhat ridiculous how annoying it can be to deal with fonts... 😅
So some fonts incorrectly specify a line gap, even though they don't want one, and some fonts do specify one without which there's no proper line spacing. Additionally I assumed that terminals technically don't have any gaps between character cells anyways (https://github.com/microsoft/terminal/pull/14014). So what should we do now?

I'll try to download your font and try to find a solution that works for both, "Terminus TTF" and "Overpass Mono" simultaneously, but I suspect either of the two fonts will need to be broken, depending on whether we want to support line gaps or not.

@lhecker commented on GitHub (Sep 24, 2022): It's somewhat ridiculous how annoying it can be to deal with fonts... 😅 So some fonts incorrectly specify a line gap, even though they don't want one, and some fonts do specify one without which there's no proper line spacing. Additionally I assumed that terminals technically don't have any gaps between character cells anyways (https://github.com/microsoft/terminal/pull/14014). So what should we do now? I'll try to download your font and try to find a solution that works for both, "Terminus TTF" and "Overpass Mono" simultaneously, but I suspect either of the two fonts will need to be broken, depending on whether we want to support line gaps or not.
claunia commented 2026-01-31 06:16:59 +00:00
Author
Owner
Copy Link

@ninlil commented on GitHub (Sep 26, 2022):

The same occurs with "Comic Code" ($0 "demo-purchase" available from https://www.myfonts.com/products/demo-regular-comic-code-474333 - actually to the point of cutting of the top 1 or 2 rows of pixels on high characters (like "f" and "8")

Yes, I understand that "technically" characters fill an entire "cell", but IMO:

  • the release-version works just fine (i.e as the font says)
  • there is no need to ignore it due to "visual considerations" like empty space between blocks (the user chooses the font)
  • if you really want it the add an option to enable/disable the extra line-height
  • or just add a custom "line-height" setting to allow users to have extra spacing between lines (some fonts are really tight, and some people have hard time reading -> "Accessability-feature")

So, please don't cut this extra line-height

@ninlil commented on GitHub (Sep 26, 2022): The same occurs with "Comic Code" ($0 "demo-purchase" available from https://www.myfonts.com/products/demo-regular-comic-code-474333 - actually to the point of cutting of the top 1 or 2 rows of pixels on high characters (like "f" and "8") Yes, I understand that "technically" characters fill an entire "cell", but IMO: * the release-version works just fine (i.e as the font says) * there is no need to ignore it due to "visual considerations" like empty space between blocks (the user chooses the font) * if you really want it the add an option to enable/disable the extra line-height * or just add a custom "line-height" setting to allow users to have extra spacing between lines (some fonts are really tight, and some people have hard time reading -> "Accessability-feature") So, please don't cut this extra line-height
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-AtlasEngine In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18534
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?