starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

We should block resources from web URLs #18608

New Issue
Closed
opened 2026-01-31 06:19:11 +00:00 by claunia · 14 comments
claunia commented 2026-01-31 06:19:11 +00:00
Owner
Copy Link

Originally created by @mailinglists35 on GitHub (Oct 6, 2022).

Windows Terminal version

1.16.2641.0

Windows build number

10.0.19044.2075

Other Software

WSL1 ubuntu 22.04LTS

Steps to reproduce

open windows terminal preview

Expected Behavior

just show the terminal, not attempt to connect to the internet

Actual Behavior

image

Originally created by @mailinglists35 on GitHub (Oct 6, 2022). ### Windows Terminal version 1.16.2641.0 ### Windows build number 10.0.19044.2075 ### Other Software WSL1 ubuntu 22.04LTS ### Steps to reproduce open windows terminal preview ### Expected Behavior just show the terminal, not attempt to connect to the internet ### Actual Behavior ![image](https://user-images.githubusercontent.com/2054302/194290373-10ae6dd5-3401-44c4-9f39-5255829d7b01.png)
claunia commented 2026-01-31 06:19:13 +00:00
Author
Owner
Copy Link

@mailinglists35 commented on GitHub (Oct 6, 2022):

the type of tab seem to not have any significance. it behaves the same if the default session is cmd.exe as well.

@mailinglists35 commented on GitHub (Oct 6, 2022): the type of tab seem to not have any significance. it behaves the same if the default session is cmd.exe as well.
claunia commented 2026-01-31 06:19:13 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 6, 2022):

We don't have any code that passively attempts to establish a connection anywhere.

If your firewall application blocks further execution of the calling application, this could be a good way for us to find out what it's doing. If that's the case, can you use Task Manager and collect a dump file from WindowsTerminal.exe?

Thanks!

@DHowett commented on GitHub (Oct 6, 2022): We don't have any code that passively attempts to establish a connection _anywhere_. If your firewall application blocks further execution of the calling application, this could be a good way for us to find out what it's doing. If that's the case, can you use Task Manager and collect a dump file from WindowsTerminal.exe? Thanks!
claunia commented 2026-01-31 06:19:13 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 6, 2022):

185.125.190.29 belongs to Canonical and is pointed to by ubuntu.com. I believe the online connection is mis-attributed to us and is actually caused by your WSL setup. This wouldn't be surprising for me as Ubuntu's MOTD contains advertisements for its products. You could try running sudo run-parts /etc/update-motd.d/ to test this.

@lhecker commented on GitHub (Oct 6, 2022): 185.125.190.29 belongs to Canonical and is pointed to by ubuntu.com. I believe the online connection is mis-attributed to us and is actually caused by your WSL setup. This wouldn't be surprising for me as Ubuntu's MOTD contains advertisements for its products. You could try running `sudo run-parts /etc/update-motd.d/` to test this.
claunia commented 2026-01-31 06:19:14 +00:00
Author
Owner
Copy Link

@mailinglists35 commented on GitHub (Oct 7, 2022):

at first I was inclined to dismiss this with suspecting canonical, but I am intrigued by the fact that the firewall triggers even if all wsl sessions stopped and changing default tab to cmd.exe.

sudo run-parts /etc/update-motd.d/ does not seem to trigger the firewall prompt.

image

@mailinglists35 commented on GitHub (Oct 7, 2022): at first I was inclined to dismiss this with suspecting canonical, but I am intrigued by the fact that the firewall triggers even if all wsl sessions stopped and changing default tab to cmd.exe. `sudo run-parts /etc/update-motd.d/` does not seem to trigger the firewall prompt. ![image](https://user-images.githubusercontent.com/2054302/194555597-c1f7436e-0926-409c-a06e-fbfbf1d9fcc4.png)
claunia commented 2026-01-31 06:19:14 +00:00
Author
Owner
Copy Link

@mailinglists35 commented on GitHub (Oct 7, 2022):

also, if wsl does establish the connection itself, how can it technically get in the windowsterminal.exe process network space?

I've had previous firewall prompts for example when doing apt updates for the first time, which did show up in firewall as their own .exe processes, not as windowsterminal.exe

@mailinglists35 commented on GitHub (Oct 7, 2022): also, if wsl does establish the connection itself, how can it technically get in the windowsterminal.exe process network space? I've had previous firewall prompts for example when doing apt updates for the first time, which did show up in firewall as their own .exe processes, not as windowsterminal.exe
claunia commented 2026-01-31 06:19:14 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 12, 2022):

I'm removing the Issue-Bug tag since we have no code that calls canonical.com neither here in this repository nor in any internal bits. We should still figure out why it happens, but I personally can't consider this as a bug anymore.

@lhecker commented on GitHub (Oct 12, 2022): I'm removing the Issue-Bug tag since we have no code that calls canonical.com neither here in this repository nor in any internal bits. We should still figure out why it happens, but I personally can't consider this as a bug anymore.
claunia commented 2026-01-31 06:19:14 +00:00
Author
Owner
Copy Link

@c4bler commented on GitHub (Jan 9, 2023):

This is an issue in Windows 11 where the default cmd.exe is bound to Windows Terminal.

If the dns server is down but the rest of the network is not, cmd.exe flat out fails to open (hangs on what I assume is awaiting response to a tcp connection, likely telemetry but this is a guess). This does not help when trying to diagnose the dns server being down.

@c4bler commented on GitHub (Jan 9, 2023): This is an issue in Windows 11 where the default cmd.exe is bound to Windows Terminal. If the dns server is down but the rest of the network is not, cmd.exe flat out fails to open (hangs on what I assume is awaiting response to a tcp connection, likely telemetry but this is a guess). This does not help when trying to diagnose the dns server being down.
claunia commented 2026-01-31 06:19:15 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 9, 2023):

@c4bler Are you also seeing WindowsTerminal.exe reaching out to the server hosting ubuntu.com?

@DHowett commented on GitHub (Jan 9, 2023): @c4bler Are you also seeing WindowsTerminal.exe reaching out to the server hosting `ubuntu.com`?
claunia commented 2026-01-31 06:19:15 +00:00
Author
Owner
Copy Link

@ejdaly commented on GitHub (Jan 24, 2023):

Am seeing the same behaviour - but only when I have a profile defined for source: CanonicalGroupLimited.Ubuntu_...

Hiding that profile stops the request - but it fires if I open the Windows Terminal Settings.

Commenting out that profile stops the request altogether.

(And commenting it back in, the request fires again as soon as the settings.json is saved).

@ejdaly commented on GitHub (Jan 24, 2023): Am seeing the same behaviour - but only when I have a profile defined for `source: CanonicalGroupLimited.Ubuntu_...` Hiding that profile stops the request - but it fires if I open the Windows Terminal Settings. Commenting out that profile stops the request altogether. (And commenting it back in, the request fires again as soon as the settings.json is saved).
claunia commented 2026-01-31 06:19:15 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 24, 2023):

Interesting!

Can you share the icon and backgroundImage paths for those profiles? You should be able to pull it from the settings UI.

@DHowett commented on GitHub (Jan 24, 2023): _Interesting!_ Can you share the `icon` and `backgroundImage` paths for those profiles? You should be able to pull it from the settings UI.
claunia commented 2026-01-31 06:19:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 24, 2023):

omfg

Is this just because their icon is defined as a web resource, so when we load the settings for that profile, we load the icon from the web?

image

Cause I'd bet it is 🤦

We all good closing this out as Resolution-External?

@zadjii-msft commented on GitHub (Jan 24, 2023): omfg Is this just because their icon is defined as a web resource, so when we load the settings for that profile, we load the icon _from the web_? ![image](https://user-images.githubusercontent.com/18356694/214408155-07460b57-ec4d-48b5-b5cb-1d59e9bb24be.png) Cause I'd bet it is 🤦 We all good closing this out as Resolution-External?
claunia commented 2026-01-31 06:19:16 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 24, 2023):

Oh heck.

@DHowett commented on GitHub (Jan 24, 2023): _Oh heck._
claunia commented 2026-01-31 06:19:16 +00:00
Author
Owner
Copy Link

@ejdaly commented on GitHub (Jan 27, 2023):

Yep that's it 😂

(Firewall blocking that request in screenshot below, so no icon...)

image

@ejdaly commented on GitHub (Jan 27, 2023): Yep that's it 😂 (Firewall blocking that request in screenshot below, so no icon...) ![image](https://user-images.githubusercontent.com/1850849/215015586-dd804f08-6de4-43c0-b423-0c8a7b077b2e.png)
claunia commented 2026-01-31 06:19:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 23, 2023):

Thanks for all the info, sorry for leaving this on read.

We've collectively decided to repurpose this to "we should block web resources". Mostly for the reason that we don't necessarily want fragment authors to put tracking pixels in their fragments.

This will also require that we do #10359 first, so as to not explode Canonical (or anyone else using this).

@zadjii-msft commented on GitHub (Aug 23, 2023): Thanks for all the info, sorry for leaving this on read. We've collectively decided to repurpose this to "we should block web resources". Mostly for the reason that we don't necessarily want fragment authors to put tracking pixels in their fragments. This will also require that we do #10359 first, so as to not explode Canonical (or anyone else using this).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Feature Needs-Tag-Fix Product-Terminal this-will-be-a-breaking-change
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18608
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?