starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Multiline Paste Warning should be Editable #18654

New Issue
Open
opened 2026-01-31 06:20:27 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 06:20:27 +00:00
Owner
Copy Link

Originally created by @romero126 on GitHub (Oct 11, 2022).

Description of the new feature/enhancement

image

Teams and other programs often add Headers or additional text to the Copy/Paste. I propose we make the MultiLine Warning dialog editable so we can modify the contents prior to confirming the paste.

Proposed technical implementation details (optional)

I propose one of two solutions.

  1. Add an Edit button to allow us to edit the contents of the paste.
  2. Convert the text to a Textbox so we can Edit prior to confirming.

I am thinking a button can go right here.
image

Originally created by @romero126 on GitHub (Oct 11, 2022). # Description of the new feature/enhancement ![image](https://user-images.githubusercontent.com/28855373/195186047-bb5df9eb-2030-4eb8-bf9d-2f946943b44e.png) Teams and other programs often add Headers or additional text to the Copy/Paste. I propose we make the MultiLine Warning dialog editable so we can modify the contents prior to confirming the paste. # Proposed technical implementation details (optional) I propose one of two solutions. 1. Add an Edit button to allow us to edit the contents of the paste. 2. Convert the text to a Textbox so we can Edit prior to confirming. I am thinking a button can go right here. ![image](https://user-images.githubusercontent.com/28855373/195186813-82c3e93a-97fe-4853-b527-612b6de081b9.png)
claunia added the Help WantedIssue-TaskProduct-TerminalArea-UserInterface labels 2026-01-31 06:20:27 +00:00
claunia commented 2026-01-31 06:20:28 +00:00
Author
Owner
Copy Link

@ninmonkey commented on GitHub (Oct 12, 2022):

Do you have largePasteWarning and multiLinePasteWarning set to false?
https://learn.microsoft.com/en-us/windows/terminal/customize-settings/interaction

edit: Oops, Misunderstood it.

@ninmonkey commented on GitHub (Oct 12, 2022): Do you have `largePasteWarning` and `multiLinePasteWarning` set to false? <https://learn.microsoft.com/en-us/windows/terminal/customize-settings/interaction> edit: Oops, Misunderstood it.
claunia commented 2026-01-31 06:20:28 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 12, 2022):

Honestly that sounds like a great idea IMO if it's not too difficult to implement!

@lhecker commented on GitHub (Oct 12, 2022): Honestly that sounds like a great idea IMO if it's not too difficult to implement!
claunia commented 2026-01-31 06:20:28 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 12, 2022):

We discussed this today and we had the following concerns:

  • Text input fields in content dialogs might not work in XAML islands at all (especially on Windows 10).
  • The text in this dialog is currently truncated to around 5 lines IIRC. This is important as a user should be able to paste long strings of text, but XAML can't deal well with such long strings being shown on the screen. An additional edit button could be added to only opt into editing the pasted text if the user wishes to do so.
@lhecker commented on GitHub (Oct 12, 2022): We discussed this today and we had the following concerns: * Text input fields in content dialogs might not work in XAML islands at all (especially on Windows 10). * _zadjii-msft edit_: This _might_ be possible to hack around? https://github.com/microsoft/microsoft-ui-xaml/issues/3804#issuecomment-1475279329 has a theory. * The text in this dialog is currently truncated to around 5 lines IIRC. This is important as a user should be able to paste long strings of text, but XAML can't deal well with such long strings being shown on the screen. An additional edit button could be added to only opt into editing the pasted text if the user wishes to do so.
claunia commented 2026-01-31 06:20:28 +00:00
Author
Owner
Copy Link

@jasontherrien commented on GitHub (Oct 13, 2022):

This would be great to clean up Teams banners too

image

@jasontherrien commented on GitHub (Oct 13, 2022): This would be great to clean up Teams banners too ![image](https://user-images.githubusercontent.com/29232291/195687636-9e710e4d-81d8-457d-9aef-0a1bebbe42eb.png)
claunia commented 2026-01-31 06:20:28 +00:00
Author
Owner
Copy Link

@romero126 commented on GitHub (Oct 13, 2022):

@lhecker I think thats where I was hoping you would go with this.

Add a button to the UI, to crack open a mini editor of some kind (a dialogbox with text editing, and a confirm button)

This should hit all of the edge cases including xaml since UI's handle textbox elements slightly differently than Text fields.

It doesn't need anything fancy (unless you want to add syntax detection/highlighting maybe monaco/vscode formatting) just something simple to edit a paste.

And of course the ability to turn the "edit" button on or off via config.

@romero126 commented on GitHub (Oct 13, 2022): @lhecker I think thats where I was hoping you would go with this. Add a button to the UI, to crack open a mini editor of some kind (a dialogbox with text editing, and a confirm button) This should hit all of the edge cases including xaml since UI's handle textbox elements slightly differently than Text fields. It doesn't need anything fancy (unless you want to add syntax detection/highlighting maybe monaco/vscode formatting) just something simple to edit a paste. And of course the ability to turn the "edit" button on or off via config.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18654
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?