starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Float values in settings are too precise (especially for people who don't know IEEE854) #1866

New Issue
Closed
opened 2026-01-30 22:40:29 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 22:40:29 +00:00
Owner
Copy Link

Originally created by @hugo-vrijswijk on GitHub (Jun 22, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version (if applicable): 0.2.1715.0

Any other software? No

Steps to reproduce

  1. Open settings
  2. Set acrylicOpacity to 0.7
  3. Close Terminal
  4. Open terminal again
  5. Observe acrylicOpacity setting now being set to 0.69999998807907104

Expected behavior

acrylicOpacity should remain on 0.7

Actual behavior

acrylicOpacity has a floating point error.

Originally created by @hugo-vrijswijk on GitHub (Jun 22, 2019). Originally assigned to: @zadjii-msft on GitHub. # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18362.175] Windows Terminal version (if applicable): 0.2.1715.0 Any other software? No ``` # Steps to reproduce 1. Open settings 2. Set `acrylicOpacity` to `0.7` 3. Close Terminal 4. Open terminal again 5. Observe `acrylicOpacity` setting now being set to `0.69999998807907104` # Expected behavior `acrylicOpacity` should remain on `0.7` # Actual behavior `acrylicOpacity` has a floating point error.
claunia added the Area-SettingsIssue-BugResolution-DuplicateProduct-Terminal labels 2026-01-30 22:40:29 +00:00
claunia commented 2026-01-30 22:40:30 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 24, 2019):

jsoncpp's default floating point precision is a little too ... precise. Probably something we can constrain.

@DHowett-MSFT commented on GitHub (Jun 24, 2019): *jsoncpp*'s default floating point precision is a little too ... precise. Probably something we can constrain.
claunia commented 2026-01-30 22:40:30 +00:00
Author
Owner
Copy Link

@Willsatroyd commented on GitHub (Jun 27, 2019):

This behaviour can be observed for any values other than 0.25, 0.5, 0.75 or 1.

@Willsatroyd commented on GitHub (Jun 27, 2019): This behaviour can be observed for any values other than 0.25, 0.5, 0.75 or 1.
claunia commented 2026-01-30 22:40:30 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 8, 2019):

Should we just switch these things to integral percent?

@DHowett-MSFT commented on GitHub (Aug 8, 2019): Should we just switch these things to integral percent?
claunia commented 2026-01-30 22:40:31 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 16, 2019):

So this hasn't been technically fixed. However, I believe it's been practically fixed by #2475. Since we're no longer in the business of serializing the user's settings, then we won't be serializing floats incorrectly anymore.

@zadjii-msft commented on GitHub (Sep 16, 2019): So this hasn't been _technically_ fixed. However, I believe it's been _practically_ fixed by #2475. Since we're no longer in the business of serializing the user's settings, then we won't be serializing floats incorrectly anymore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1866
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?