starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

One-stop font color (theme) tweak-through-app-layers feasibility at config.json #18678

New Issue
Closed
opened 2026-01-31 06:21:06 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:21:06 +00:00
Owner
Copy Link

Originally created by @kazuf3 on GitHub (Oct 13, 2022).

Description of the new feature/enhancement

TL; DR
Make color theme tweaks one-stop at config.json.

Currently there are many choices where user make the font color selection in Terminal.
For example, an user may pick font color in their CUI text editor, shell config, Tmux config or Terminal config.
Let's say a user picks solarized dark theme in one's config.json, but his different layers of apps overwrite them respectively, so one won't see solarized dark theme in his editor.

Proposed technical implementation details (optional)

Pass current color theme variables from config.json into corresponding environment variables to WSL2.

Originally created by @kazuf3 on GitHub (Oct 13, 2022). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement TL; DR Make color theme tweaks one-stop at `config.json`. Currently there are many choices where user make the font color selection in Terminal. For example, an user may pick font color in their CUI text editor, shell config, Tmux config or Terminal config. Let's say a user picks solarized dark theme in one's `config.json`, but his different layers of apps overwrite them respectively, so one won't see solarized dark theme in his editor. <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) Pass current color theme variables from `config.json` into corresponding environment variables to WSL2. <!-- A clear and concise description of what you want to happen. -->
claunia added the Issue-FeatureArea-OutputNeeds-Tag-FixProduct-Terminal labels 2026-01-31 06:21:06 +00:00
claunia commented 2026-01-31 06:21:07 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 18, 2022):

I could be wrong, but I don't think there's a reasonable way to accomplish this. Windows Terminal lets you define the 16 colors in the color table, right? So if the connected shell requests "black" or "bright black", I assume the shell resolves it using the color table we provided and outputs the text in the desired color.

Now, if the shell outputs text in a specific RGB format, we can't really get in the way of that. Tmux, for example, would probably require some kind of initialization such that the color scheme from the Windows Terminal profile is converted and injected into Tmux's config file so that it uses that.

To make things worse, if there's one tmux.exe, how would this work with multiple WT profiles running tmux across different panes/tabs?

I like the idea and appreciate the feedback request, but I'm going to close this as not planned. Happy to reopen it if I'm wrong though (totally possible).

@carlos-zamora commented on GitHub (Oct 18, 2022): I could be wrong, but I don't think there's a reasonable way to accomplish this. Windows Terminal lets you define the 16 colors in the color table, right? So if the connected shell requests "black" or "bright black", I assume the shell resolves it using the color table we provided and outputs the text in the desired color. Now, if the shell outputs text in a specific RGB format, we can't really get in the way of that. Tmux, for example, would probably require some kind of initialization such that the color scheme from the Windows Terminal profile is converted and injected into Tmux's config file so that it uses that. To make things worse, if there's one tmux.exe, how would this work with multiple WT profiles running tmux across different panes/tabs? I like the idea and appreciate the feedback request, but I'm going to close this as not planned. Happy to reopen it if I'm wrong though (totally possible).
claunia commented 2026-01-31 06:21:07 +00:00
Author
Owner
Copy Link

@kazuf3 commented on GitHub (Oct 18, 2022):

@carlos-zamora

gotcha.

Could you confirm that there are no way/plans to pass environment variables from config.json to WSL2 guest, not limited to this use case? At least it would help pass color scheme to editors inside of WSL2 guest.

@kazuf3 commented on GitHub (Oct 18, 2022): @carlos-zamora gotcha. Could you confirm that there are no way/plans to pass environment variables from `config.json` to WSL2 guest, not limited to this use case? At least it would help pass color scheme to editors inside of WSL2 guest.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Feature Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?