starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ssh <start typing hostname> --- the hostname is invisible. No matter what color scheme I select. #18707

New Issue
Closed
opened 2026-01-31 06:21:57 +00:00 by claunia · 13 comments
claunia commented 2026-01-31 06:21:57 +00:00
Owner
Copy Link

Originally created by @mgarrett69 on GitHub (Oct 17, 2022).

Originally assigned to: @DHowett on GitHub.

Windows Terminal version

1.16.2642.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

Just open a windows terminal and issue a ssh command.

(also seen when I ran [environment]::OsVersion -- the [environment] part of the string is invisible)

Expected Behavior

Here is the copy/paste of what I typed into the terminal (and what came back when I hit enter)

PS C:\Users\migarret\Work Folders\Downloads> ssh imola1
Warning: Permanently added 'xx.xx.xx.xx' (ED25519) to the list of known hosts.
Last login: Mon Oct 17 15:20:33 2022 from xx.xx.xx.xx
AvereOS_2022.08.0

[root@imola1 ~]#

Actual Behavior

image

Originally created by @mgarrett69 on GitHub (Oct 17, 2022). Originally assigned to: @DHowett on GitHub. ### Windows Terminal version 1.16.2642.0 ### Windows build number 10.0.22621.0 ### Other Software _No response_ ### Steps to reproduce Just open a windows terminal and issue a ssh command. (also seen when I ran [environment]::OsVersion -- the [environment] part of the string is invisible) ### Expected Behavior Here is the copy/paste of what I typed into the terminal (and what came back when I hit enter) PS C:\Users\migarret\Work Folders\Downloads> ssh imola1 Warning: Permanently added 'xx.xx.xx.xx' (ED25519) to the list of known hosts. Last login: Mon Oct 17 15:20:33 2022 from xx.xx.xx.xx AvereOS_2022.08.0 [root@imola1 ~]# ### Actual Behavior ![image](https://user-images.githubusercontent.com/3707340/196268853-7b020408-eb12-48ef-b64a-63362ad61f6a.png)
claunia added the Issue-QuestionNeeds-TriageIssue-BugResolution-Answered labels 2026-01-31 06:21:58 +00:00
claunia commented 2026-01-31 06:21:59 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 17, 2022):

Huh. This might be an alternate reality version of this note, which applies to background colors (they're handled by the same code.)

All the same, can you share your settings.json?

@DHowett commented on GitHub (Oct 17, 2022): _Huh._ This might be an alternate reality version of [this note, which applies to background colors](https://learn.microsoft.com/en-us/windows/terminal/troubleshooting#my-colors-look-strange-there-are-black-bars-on-my-screen) (they're handled by the same code.) All the same, can you share your `settings.json`?
claunia commented 2026-01-31 06:21:59 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 17, 2022):

(And, perhaps, would you grab the following powershell output?

$PSVersionTable

Get-Module PSReadline | Format-List *
@DHowett commented on GitHub (Oct 17, 2022): (And, perhaps, would you grab the following powershell output? ``` $PSVersionTable Get-Module PSReadline | Format-List * ```
claunia commented 2026-01-31 06:21:59 +00:00
Author
Owner
Copy Link

@237dmitry commented on GitHub (Oct 17, 2022):

The main trouble is in the PSReadline options and $PSStyle parameters that know nothing about colorschemes. Everything requires configuration.

(also seen when I ran [environment]::OsVersion -- the [environment] part of the string is invisible)

Select with the mouse or set it to the clipboard:

$PSversionTable | Out-String | Set-Clipboard

You can change default foreground color of PSReadline:

Set-PSReadLineOption -Color @{'Default' = "`e[38;5;16m"}

Screenshot 2022-10-18 000646

@237dmitry commented on GitHub (Oct 17, 2022): The main trouble is in the PSReadline options and $PSStyle parameters that know nothing about colorschemes. Everything requires configuration. > (also seen when I ran [environment]::OsVersion -- the [environment] part of the string is invisible) Select with the mouse or set it to the clipboard: ```powershell $PSversionTable | Out-String | Set-Clipboard ``` You can change default foreground color of PSReadline: ```powershell Set-PSReadLineOption -Color @{'Default' = "`e[38;5;16m"} ``` ![Screenshot 2022-10-18 000646](https://user-images.githubusercontent.com/78153320/196283810-1b6faa48-8671-4dfe-9131-6be372a347c1.png)
claunia commented 2026-01-31 06:21:59 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 17, 2022):

@237dmitry you're right that it's configurable, but also... this text should be showing up in the "default foreground" color. I marked your original comments as off-topic since they may confuse users into thinking that to see text by default they would need to do some configuring. Still, I appreciate you adding additional info to this bug report!

The default foreground and background in every color scheme should absolutely be readable and require no Terminal or shell configuration. 🙂

@DHowett commented on GitHub (Oct 17, 2022): @237dmitry you're right that it's configurable, but also... this text should be showing up in the "default foreground" color. I marked your original comments as off-topic since they may confuse users into thinking that **to see text by default** they would need to do some configuring. Still, I appreciate you adding additional info to this bug report! The default foreground and background in every color scheme should absolutely be readable and require no Terminal or shell configuration. 🙂
claunia commented 2026-01-31 06:22:00 +00:00
Author
Owner
Copy Link

@237dmitry commented on GitHub (Oct 17, 2022):

this text should be showing up in the "default foreground"

I think, PSReadline Team does not think about it. If you launch pwsh without profile pwsh -NoProfile and see output of Get-PSReadlineOptions there is:

DefaultTokenColor                      : "`e[37m"    # White!

I do not know this parameter changes depend on base 16 colors or not. Rather not. This is static value -- user knows better how to tune host.

@237dmitry commented on GitHub (Oct 17, 2022): > this text should be showing up in the "default foreground" I think, PSReadline Team does not think about it. If you launch pwsh without profile `pwsh -NoProfile` and see output of `Get-PSReadlineOptions` there is: ``` DefaultTokenColor : "`e[37m" # White! ``` I do not know this parameter changes depend on base 16 colors or not. Rather not. This is static value -- user knows better how to tune host.
claunia commented 2026-01-31 06:22:00 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 17, 2022):

Ah, that's a very good point! The default configuration of PowerShell does display white-on-default-bg. Bah. Thank you!

@DHowett commented on GitHub (Oct 17, 2022): Ah, that's a very good point! The default configuration of PowerShell _does_ display white-on-default-bg. _Bah._ Thank you!
claunia commented 2026-01-31 06:22:00 +00:00
Author
Owner
Copy Link

@mgarrett69 commented on GitHub (Oct 18, 2022):

Name                           Value                                                                                                                                         
----                           -----                                                                                                                                         
PSVersion                      5.1.22621.608                                                                                                                                 
PSEdition                      Desktop                                                                                                                                       
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                                                       
BuildVersion                   10.0.22621.608                                                                                                                                
CLRVersion                     4.0.30319.42000                                                                                                                               
WSManStackVersion              3.0                                                                                                                                           
PSRemotingProtocolVersion      2.3                                                                                                                                           
SerializationVersion           1.1.0.1                       

PS C:\Users\migarret\Work Folders\Downloads> Get-Module PSReadline | Format-List *


LogPipelineExecutionDetails : False
Name                        : PSReadLine
Path                        : C:\Program Files\WindowsPowerShell\Modules\PSReadLine\2.0.0\PSReadLine.psm1
ImplementingAssembly        :
Definition                  : function PSConsoleHostReadLine
                              {
                                  Microsoft.PowerShell.Core\Set-StrictMode -Off
                                  [Microsoft.PowerShell.PSConsoleReadLine]::ReadLine($host.Runspace, $ExecutionContext)
                              }

Description                 : Great command line editing in the PowerShell console host
Guid                        : 5714753b-2afd-4492-a5fd-01d9e2cff8b5
HelpInfoUri                 : https://aka.ms/powershell51-help
ModuleBase                  : C:\Program Files\WindowsPowerShell\Modules\PSReadLine\2.0.0
PrivateData                 :
Tags                        : {}
ProjectUri                  :
IconUri                     :
LicenseUri                  :
ReleaseNotes                :
RepositorySourceLocation    :
Version                     : 2.0.0
ModuleType                  : Script
Author                      : Microsoft Corporation
AccessMode                  : ReadWrite
ClrVersion                  : 4.0.0
CompanyName                 : Microsoft Corporation
Copyright                   : (c) Microsoft Corporation. All rights reserved.
DotNetFrameworkVersion      : 4.6.1
ExportedFunctions           : {[PSConsoleHostReadLine, PSConsoleHostReadLine]}
Prefix                      :
ExportedCmdlets             : {[Get-PSReadLineKeyHandler, Get-PSReadLineKeyHandler], [Get-PSReadLineOption, Get-PSReadLineOption], [Remove-PSReadLineKeyHandler,
                              Remove-PSReadLineKeyHandler], [Set-PSReadLineKeyHandler, Set-PSReadLineKeyHandler]...}
ExportedCommands            : {[Get-PSReadLineKeyHandler, Get-PSReadLineKeyHandler], [Get-PSReadLineOption, Get-PSReadLineOption], [Remove-PSReadLineKeyHandler,
                              Remove-PSReadLineKeyHandler], [Set-PSReadLineKeyHandler, Set-PSReadLineKeyHandler]...}
FileList                    : {}
CompatiblePSEditions        : {}
ModuleList                  : {}
NestedModules               : {Microsoft.PowerShell.PSReadLine}
PowerShellHostName          :
PowerShellHostVersion       :
PowerShellVersion           : 5.0
ProcessorArchitecture       : None
Scripts                     : {}
RequiredAssemblies          : {}
RequiredModules             : {}
RootModule                  : PSReadLine.psm1
ExportedVariables           : {}
ExportedAliases             : {}
ExportedWorkflows           : {}
ExportedDscResources        : {}
SessionState                : System.Management.Automation.SessionState
OnRemove                    :
ExportedFormatFiles         : {C:\Program Files\WindowsPowerShell\Modules\PSReadLine\2.0.0\PSReadLine.format.ps1xml}
ExportedTypeFiles           : {}

settings.zip

@mgarrett69 commented on GitHub (Oct 18, 2022): ``` Name Value ---- ----- PSVersion 5.1.22621.608 PSEdition Desktop PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...} BuildVersion 10.0.22621.608 CLRVersion 4.0.30319.42000 WSManStackVersion 3.0 PSRemotingProtocolVersion 2.3 SerializationVersion 1.1.0.1 ``` ``` PS C:\Users\migarret\Work Folders\Downloads> Get-Module PSReadline | Format-List * LogPipelineExecutionDetails : False Name : PSReadLine Path : C:\Program Files\WindowsPowerShell\Modules\PSReadLine\2.0.0\PSReadLine.psm1 ImplementingAssembly : Definition : function PSConsoleHostReadLine { Microsoft.PowerShell.Core\Set-StrictMode -Off [Microsoft.PowerShell.PSConsoleReadLine]::ReadLine($host.Runspace, $ExecutionContext) } Description : Great command line editing in the PowerShell console host Guid : 5714753b-2afd-4492-a5fd-01d9e2cff8b5 HelpInfoUri : https://aka.ms/powershell51-help ModuleBase : C:\Program Files\WindowsPowerShell\Modules\PSReadLine\2.0.0 PrivateData : Tags : {} ProjectUri : IconUri : LicenseUri : ReleaseNotes : RepositorySourceLocation : Version : 2.0.0 ModuleType : Script Author : Microsoft Corporation AccessMode : ReadWrite ClrVersion : 4.0.0 CompanyName : Microsoft Corporation Copyright : (c) Microsoft Corporation. All rights reserved. DotNetFrameworkVersion : 4.6.1 ExportedFunctions : {[PSConsoleHostReadLine, PSConsoleHostReadLine]} Prefix : ExportedCmdlets : {[Get-PSReadLineKeyHandler, Get-PSReadLineKeyHandler], [Get-PSReadLineOption, Get-PSReadLineOption], [Remove-PSReadLineKeyHandler, Remove-PSReadLineKeyHandler], [Set-PSReadLineKeyHandler, Set-PSReadLineKeyHandler]...} ExportedCommands : {[Get-PSReadLineKeyHandler, Get-PSReadLineKeyHandler], [Get-PSReadLineOption, Get-PSReadLineOption], [Remove-PSReadLineKeyHandler, Remove-PSReadLineKeyHandler], [Set-PSReadLineKeyHandler, Set-PSReadLineKeyHandler]...} FileList : {} CompatiblePSEditions : {} ModuleList : {} NestedModules : {Microsoft.PowerShell.PSReadLine} PowerShellHostName : PowerShellHostVersion : PowerShellVersion : 5.0 ProcessorArchitecture : None Scripts : {} RequiredAssemblies : {} RequiredModules : {} RootModule : PSReadLine.psm1 ExportedVariables : {} ExportedAliases : {} ExportedWorkflows : {} ExportedDscResources : {} SessionState : System.Management.Automation.SessionState OnRemove : ExportedFormatFiles : {C:\Program Files\WindowsPowerShell\Modules\PSReadLine\2.0.0\PSReadLine.format.ps1xml} ExportedTypeFiles : {} ``` [settings.zip](https://github.com/microsoft/terminal/files/9814861/settings.zip)
claunia commented 2026-01-31 06:22:00 +00:00
Author
Owner
Copy Link

@mgarrett69 commented on GitHub (Oct 18, 2022):

PS C:\Users\migarret\Work Folders\Downloads> Get-PSReadlineOptions
Get-PSReadlineOptions : The term 'Get-PSReadlineOptions' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the
name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ Get-PSReadlineOptions
+ ~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Get-PSReadlineOptions:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

PS C:\Users\migarret\Work Folders\Downloads> Set-PSReadLineOption -Color @{'Default' = "`e[38;5;16m"}
Set-PSReadLineOption : 'e[38;5;16m' is not a valid color value.  It must be a ConsoleColor, ANSI escape sequence, or RGB value with optional leading '#'.
At line:1 char:1
+ Set-PSReadLineOption -Color @{'Default' = "`e[38;5;16m"}
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Set-PSReadLineOption], ArgumentException
    + FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.SetPSReadLineOption
@mgarrett69 commented on GitHub (Oct 18, 2022): ``` PS C:\Users\migarret\Work Folders\Downloads> Get-PSReadlineOptions Get-PSReadlineOptions : The term 'Get-PSReadlineOptions' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At line:1 char:1 + Get-PSReadlineOptions + ~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : ObjectNotFound: (Get-PSReadlineOptions:String) [], CommandNotFoundException + FullyQualifiedErrorId : CommandNotFoundException PS C:\Users\migarret\Work Folders\Downloads> Set-PSReadLineOption -Color @{'Default' = "`e[38;5;16m"} Set-PSReadLineOption : 'e[38;5;16m' is not a valid color value. It must be a ConsoleColor, ANSI escape sequence, or RGB value with optional leading '#'. At line:1 char:1 + Set-PSReadLineOption -Color @{'Default' = "`e[38;5;16m"} + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : NotSpecified: (:) [Set-PSReadLineOption], ArgumentException + FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.SetPSReadLineOption ```
claunia commented 2026-01-31 06:22:01 +00:00
Author
Owner
Copy Link

@mgarrett69 commented on GitHub (Oct 18, 2022):

Let me know if I missed any of the output you wanted. As you can see, I caught errors when trying a few of the suggestions above.

And, for what it's worth, my background is grey, so even white lettering should not be invisible,,, I think.

@mgarrett69 commented on GitHub (Oct 18, 2022): Let me know if I missed any of the output you wanted. As you can see, I caught errors when trying a few of the suggestions above. And, for what it's worth, my background is grey, so even white lettering should not be invisible,,, I think.
claunia commented 2026-01-31 06:22:01 +00:00
Author
Owner
Copy Link

@elsaco commented on GitHub (Oct 19, 2022):

@mgarrett69 it's Get-PSReadLineOption not Get-PSReadLineOptions

@elsaco commented on GitHub (Oct 19, 2022): @mgarrett69 it's `Get-PSReadLineOption` not `Get-PSReadLineOptions`
claunia commented 2026-01-31 06:22:01 +00:00
Author
Owner
Copy Link

@mgarrett69 commented on GitHub (Oct 20, 2022):

Thanks elsaco

PS C:\Users\migarret\Work Folders\Downloads> Get-PSReadLineOption

EditMode : Windows
AddToHistoryHandler : System.Func`2[System.String,System.Object]
HistoryNoDuplicates : True
HistorySavePath : C:\Users\migarret\AppData\Roaming\Microsoft\Windows\PowerShell\PSReadLine\ConsoleHost_history.txt
HistorySaveStyle : SaveIncrementally
HistorySearchCaseSensitive : False
HistorySearchCursorMovesToEnd : False
MaximumHistoryCount : 4096
ContinuationPrompt : >>
ExtraPromptLineCount : 0
PromptText : {> }
BellStyle : Audible
DingDuration : 50
DingTone : 1221
CommandsToValidateScriptBlockArguments : {ForEach-Object, %, Invoke-Command, icm...}
CommandValidationHandler :
CompletionQueryItems : 100
MaximumKillRingCount : 10
ShowToolTips : True
ViModeIndicator : None
WordDelimiters : ;:,.[]{}()/|^&*-=+'"–—―
AnsiEscapeTimeout : 100
CommandColor : "$([char]0x1b)[93m"
CommentColor : "$([char]0x1b)[32m"
ContinuationPromptColor : "$([char]0x1b)[37m"
DefaultTokenColor : "$([char]0x1b)[37m"
EmphasisColor : "$([char]0x1b)[96m"
ErrorColor : "$([char]0x1b)[91m"
KeywordColor : "$([char]0x1b)[92m"
MemberColor : "$([char]0x1b)[97m"
NumberColor : "$([char]0x1b)[97m"
OperatorColor : "$([char]0x1b)[90m"
ParameterColor : "$([char]0x1b)[90m"
SelectionColor : "$([char]0x1b)[30;47m"
StringColor : "$([char]0x1b)[36m"
TypeColor : "$([char]0x1b)[37m"
VariableColor : "$([char]0x1b)[92m"

@mgarrett69 commented on GitHub (Oct 20, 2022): Thanks elsaco PS C:\Users\migarret\Work Folders\Downloads> Get-PSReadLineOption EditMode : Windows AddToHistoryHandler : System.Func`2[System.String,System.Object] HistoryNoDuplicates : True HistorySavePath : C:\Users\migarret\AppData\Roaming\Microsoft\Windows\PowerShell\PSReadLine\ConsoleHost_history.txt HistorySaveStyle : SaveIncrementally HistorySearchCaseSensitive : False HistorySearchCursorMovesToEnd : False MaximumHistoryCount : 4096 ContinuationPrompt : >> ExtraPromptLineCount : 0 PromptText : {> } BellStyle : Audible DingDuration : 50 DingTone : 1221 CommandsToValidateScriptBlockArguments : {ForEach-Object, %, Invoke-Command, icm...} CommandValidationHandler : CompletionQueryItems : 100 MaximumKillRingCount : 10 ShowToolTips : True ViModeIndicator : None WordDelimiters : ;:,.[]{}()/\|^&*-=+'"–—― AnsiEscapeTimeout : 100 CommandColor : "$([char]0x1b)[93m" CommentColor : "$([char]0x1b)[32m" ContinuationPromptColor : "$([char]0x1b)[37m" DefaultTokenColor : "$([char]0x1b)[37m" EmphasisColor : "$([char]0x1b)[96m" ErrorColor : "$([char]0x1b)[91m" KeywordColor : "$([char]0x1b)[92m" MemberColor : "$([char]0x1b)[97m" NumberColor : "$([char]0x1b)[97m" OperatorColor : "$([char]0x1b)[90m" ParameterColor : "$([char]0x1b)[90m" SelectionColor : "$([char]0x1b)[30;47m" StringColor : "$([char]0x1b)[36m" TypeColor : "$([char]0x1b)[37m" VariableColor : "$([char]0x1b)[92m"
claunia commented 2026-01-31 06:22:02 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 20, 2022):

Alright, so the root cause for this one is that the white color¹ in your default color scheme, Campbell, is set to the same color as the background. Now, you told me that this worked before Terminal 1.15 . . . and I'll get to that.

Anyway, PowerShell is explicitly requesting white and it doesn't know that your background is also white. Crap.

We've got a couple ways around this.

One is this feature that's currently available in preview builds that automatically detects when two colors have poor (or even catastrophic!) contrast and darkens or lightens the foreground color as appropriate to make it visible. Eventually, we'll enable it by default. That re-landed in #13343 and was enhanced in #13512.

The other is for you to change the white color (and bright white) to be dark; effectively, make a flipped version of the Campbell scheme where white and black are actually swapped.

¹ that is, color 37. you can see in your PSReadlineOptions that DefaultTokenColor is (blah blah blah) **37** m 

² why it's asking for 37 is... a long and ultimately disappointing story. The console only used to support 16 colors but all terminals since, say, 1981 have supported 18. PowerShell used the tools available to them and declared the "default" token color to be "white" (rather than "let the terminal decide what is best for visibility")

Now for the kicker. This worked in Terminal 1.14 (actually, this worked in all versions of Terminal between 0.1 (inclusive) and 1.15 (exclusive)!) In 1.15, however, we tore off in PR #13352 a band-aid that we had previously applied to PowerShell (originally applied in #6810).

Well, that band-aid was fixing two problems. One, the actual problem. Two, this.

We expressly ignored any requests for CSI 40 (black background) and CSI 37 (white foreground) from PowerShell... because they used it erroneously all the time.

In so doing, we hid this issue where their default token color is, in fact, 37. It should be 39.

Now that we're respecting PowerShell's color choices again, we're bound to run into more cases like this.

@mgarrett69 realized that he never tested other color schemes because of our poor and confusing UI for selecting/editing them. 1.16 didn't do so much to help, because the buttons that make it clear that there's actions to take are "below the fold." We should keep ideating there.

Tagged for team discussion so we can assess:

  • reintroducing the color quirk
  • enabling "color nudging" by default again
  • what to do about the color schemes UI
@DHowett commented on GitHub (Oct 20, 2022): Alright, so the root cause for this one is that the `white` color¹ in your default color scheme, Campbell, is set to the same color as the `background`. Now, you told me that this worked before Terminal 1.15 . . . and I'll get to that. Anyway, PowerShell is explicitly requesting `white` and it doesn't know that your background is also white. _Crap._ We've got a couple ways around this. One is this feature that's currently available in preview builds that automatically detects when two colors have poor (or even catastrophic!) contrast and darkens or lightens the foreground color as appropriate to make it visible. Eventually, we'll enable it by default. That re-landed in #13343 and was enhanced in #13512. The other is for you to change the `white` color (and bright white) to be dark; effectively, make a flipped version of the Campbell scheme where white and black are actually swapped. ¹ that is, color `37`. you can see in your PSReadlineOptions that `DefaultTokenColor` is `(blah blah blah) **37** m`  ² why it's asking for `37` is... a long and ultimately disappointing story. The console only used to support 16 colors but all terminals since, say, 1981 have supported _18_. PowerShell used the tools available to them and declared the "default" token color to be "white" (rather than "let the terminal decide what is best for visibility") --- Now for the kicker. This worked in Terminal 1.14 (actually, this worked in all versions of Terminal between 0.1 (inclusive) and 1.15 (exclusive)!) In 1.15, however, we tore off in PR #13352 a band-aid that we had previously applied to PowerShell (originally applied in #6810). Well, that band-aid was fixing two problems. One, the actual problem. Two, _this_. We expressly ignored any requests for CSI `40` (black background) and CSI `37` (white foreground) from PowerShell... because they used it erroneously all the time. In so doing, we _hid_ this issue where their default token color is, in fact, `37`. It should be `39`. Now that we're respecting PowerShell's color choices again, we're bound to run into more cases like this. --- @mgarrett69 realized that he never tested other color schemes because of our poor and confusing UI for selecting/editing them. 1.16 didn't do so much to help, because the buttons that make it clear that there's actions to take are "below the fold." We should keep ideating there. --- Tagged for team discussion so we can assess: - reintroducing the color quirk - enabling "color nudging" by default again - what to do about the color schemes UI
claunia commented 2026-01-31 06:22:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2022):

We talked more with the PsReadline folks today. overall, we felt like the best option wasn't to keep patching an edge case with more heuristics. That would just shift the dissatisfaction around to different users in an elaborate game of wack-a-mole. They acknowledged that yea, the default PsReadline settings aren't configured for a light scheme, they're set up for a dark scheme (for more historical context: https://github.com/PowerShell/PSReadLine/issues/464). They're gonna go ahead and update their docs to better clarify that users who prefer a light scheme should change their PsReadLine settings to match. That's tracked in: https://github.com/MicrosoftDocs/PowerShell-Docs/issues/9358

As an immediate workaround, you should be able to set "adjustIndistinguishableColors": "indexed" to force the Terminal to manually adjust the text colors to ensure there's enough contrast in this use case.

@zadjii-msft commented on GitHub (Oct 25, 2022): We talked more with the PsReadline folks today. overall, we felt like the best option wasn't to keep patching an edge case with more heuristics. That would just shift the dissatisfaction around to different users in an elaborate game of wack-a-mole. They acknowledged that yea, the default PsReadline settings aren't configured for a light scheme, they're set up for a dark scheme (for more historical context: https://github.com/PowerShell/PSReadLine/issues/464). They're gonna go ahead and update their docs to better clarify that users who prefer a light scheme should change their PsReadLine settings to match. That's tracked in: https://github.com/MicrosoftDocs/PowerShell-Docs/issues/9358 As an immediate workaround, you should be able to set `"adjustIndistinguishableColors": "indexed"` to force the Terminal to manually adjust the text colors to ensure there's enough contrast in this use case.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Issue-Question Needs-Triage Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18707
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?