starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Audit FAIL_FASTs across the code #18759

New Issue
Open
opened 2026-01-31 06:23:32 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:23:32 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Oct 27, 2022).

Back in 2018 we switched every NTASSERT/ASSERT/NT_ASSERT in these components to a FAIL_FAST, unequivocally, because if we cared enough to check it, we should care enough to die for it.
I think that’s good and valuable, and it has its place.

Now that these components are shared with Terminal (who seeks to host multiple copies of each of them in parallel), and now that a11y has taken a bigger bet on them performing sanely and safely,
I’m wondering if we should scale back a little bit on the take down the entire process if something lifts off into space stance.

We’re seeing a good number of crashes due to accessibility that I think should just be “oh, the API returned an error code, NVDA can recover”. We once saw reports that resizing the window when an unexpected DBCS half lands in the buffer (#4907) caused a crash.

They’re programming errors, for sure, but our users probably want things to be more reliable.

Should, or could, we surface those as exceptions and let the caller recover wherever possible?
Should we just internally recover?

Let's find out.

Generated as of 2022-10-27 ab04067e49

How did I generate this? 
rg -n FAIL_FAST_IF\`( --no-heading | % {
	$p=$_ -split ":";
	$pa=$p[0] -replace "\\","/";
	$ln=$p[1];
	[pscustomobject]@{File=$pa;Line=$ln}
} | group File | sort -Descending Count | % {
	"## $($_.Name)`n";
	$_.Group | % {
		"https://github.com/microsoft/terminal/blob/$(git rev-parse HEAD)/src/$($_.File)#L$($_.Line)"
	};
	"`n"
}

host/screenInfo.cpp

ab04067e49/src/host/screenInfo.cpp (L193)
ab04067e49/src/host/screenInfo.cpp (L382-L383)
ab04067e49/src/host/screenInfo.cpp (L402-L403)
ab04067e49/src/host/screenInfo.cpp (L421-L422)
ab04067e49/src/host/screenInfo.cpp (L453-L454)
ab04067e49/src/host/screenInfo.cpp (L472-L473)
ab04067e49/src/host/screenInfo.cpp (L600)
ab04067e49/src/host/screenInfo.cpp (L905-L907)
ab04067e49/src/host/screenInfo.cpp (L1161)

host/cmdline.cpp

ab04067e49/src/host/cmdline.cpp (L284)
ab04067e49/src/host/cmdline.cpp (L448)
ab04067e49/src/host/cmdline.cpp (L483)
ab04067e49/src/host/cmdline.cpp (L519)
ab04067e49/src/host/cmdline.cpp (L651)
ab04067e49/src/host/cmdline.cpp (L665)
ab04067e49/src/host/cmdline.cpp (L677)
ab04067e49/src/host/cmdline.cpp (L685)
ab04067e49/src/host/cmdline.cpp (L766)
ab04067e49/src/host/cmdline.cpp (L1000)

host/_stream.cpp

ab04067e49/src/host/_stream.cpp (L252)
ab04067e49/src/host/_stream.cpp (L429)
ab04067e49/src/host/_stream.cpp (L608)
ab04067e49/src/host/_stream.cpp (L664)
ab04067e49/src/host/_stream.cpp (L974-L979)
ab04067e49/src/host/_stream.cpp (L1187)

host/inputBuffer.cpp

ab04067e49/src/host/inputBuffer.cpp (L376)
ab04067e49/src/host/inputBuffer.cpp (L513-L518)
ab04067e49/src/host/inputBuffer.cpp (L717-L718)
ab04067e49/src/host/inputBuffer.cpp (L784)
ab04067e49/src/host/inputBuffer.cpp (L785)

propsheet/fontdlg.cpp

ab04067e49/src/propsheet/fontdlg.cpp (L704)
ab04067e49/src/propsheet/fontdlg.cpp (L891)
ab04067e49/src/propsheet/fontdlg.cpp (L1143)
ab04067e49/src/propsheet/fontdlg.cpp (L1355)
ab04067e49/src/propsheet/fontdlg.cpp (L1498)
ab04067e49/src/propsheet/fontdlg.cpp (L1590)

host/utils.cpp

ab04067e49/src/host/utils.cpp (L176-L179)
ab04067e49/src/host/utils.cpp (L231-L232)

interactivity/win32/icon.cpp

ab04067e49/src/interactivity/win32/icon.cpp (L238-L241)
ab04067e49/src/interactivity/win32/icon.cpp (L265)
ab04067e49/src/interactivity/win32/icon.cpp (L288)
ab04067e49/src/interactivity/win32/icon.cpp (L320)

host/readDataCooked.cpp

ab04067e49/src/host/readDataCooked.cpp (L323)
ab04067e49/src/host/readDataCooked.cpp (L330-L333)
ab04067e49/src/host/readDataCooked.cpp (L1079)

host/settings.cpp

ab04067e49/src/host/settings.cpp (L355-L358)

host/history.cpp

ab04067e49/src/host/history.cpp (L41)
ab04067e49/src/host/history.cpp (L66)
ab04067e49/src/host/history.cpp (L92)
ab04067e49/src/host/history.cpp (L197)

host/srvinit.cpp

ab04067e49/src/host/srvinit.cpp (L827-L829)

host/misc.cpp

ab04067e49/src/host/misc.cpp (L25)
ab04067e49/src/host/misc.cpp (L245)
ab04067e49/src/host/misc.cpp (L272)

interactivity/win32/window.cpp

ab04067e49/src/interactivity/win32/window.cpp (L129)
ab04067e49/src/interactivity/win32/window.cpp (L531)
ab04067e49/src/interactivity/win32/window.cpp (L638)

host/readDataDirect.cpp

ab04067e49/src/host/readDataDirect.cpp (L74)
ab04067e49/src/host/readDataDirect.cpp (L77)
ab04067e49/src/host/readDataDirect.cpp (L181)

server/ProcessList.cpp

ab04067e49/src/server/ProcessList.cpp (L36)
ab04067e49/src/server/ProcessList.cpp (L88)
ab04067e49/src/server/ProcessList.cpp (L91)

host/selectionInput.cpp

ab04067e49/src/host/selectionInput.cpp (L25)
ab04067e49/src/host/selectionInput.cpp (L271)
ab04067e49/src/host/selectionInput.cpp (L336)

tsf/TfEditSession.cpp

ab04067e49/src/tsf/TfEditSession.cpp (L70)
ab04067e49/src/tsf/TfEditSession.cpp (L693)
ab04067e49/src/tsf/TfEditSession.cpp (L1030)

server/ObjectHandle.cpp

ab04067e49/src/server/ObjectHandle.cpp (L228)
ab04067e49/src/server/ObjectHandle.cpp (L242)
ab04067e49/src/server/ObjectHandle.cpp (L267)

host/CommandListPopup.cpp

ab04067e49/src/host/CommandListPopup.cpp (L58)
ab04067e49/src/host/CommandListPopup.cpp (L244)

interactivity/win32/windowio.cpp

ab04067e49/src/interactivity/win32/windowio.cpp (L69)
ab04067e49/src/interactivity/win32/windowio.cpp (L992)

host/conimeinfo.cpp

ab04067e49/src/host/conimeinfo.cpp (L338)
ab04067e49/src/host/conimeinfo.cpp (L418)

host/input.cpp

ab04067e49/src/host/input.cpp (L199)
ab04067e49/src/host/input.cpp (L276)

host/consoleInformation.cpp

ab04067e49/src/host/consoleInformation.cpp (L72)
ab04067e49/src/host/consoleInformation.cpp (L84)

host/readDataRaw.cpp

ab04067e49/src/host/readDataRaw.cpp (L77-L79)

tsf/TfDispAttr.cpp

ab04067e49/src/tsf/TfDispAttr.cpp (L102)
ab04067e49/src/tsf/TfDispAttr.cpp (L115)

host/inputReadHandleData.cpp

ab04067e49/src/host/inputReadHandleData.cpp (L64)

host/directio.cpp

ab04067e49/src/host/directio.cpp (L196)
ab04067e49/src/host/directio.cpp (L239)

host/ConsoleArguments.cpp

ab04067e49/src/host/ConsoleArguments.cpp (L351)
ab04067e49/src/host/ConsoleArguments.cpp (L552)

propsheet/registry.cpp

ab04067e49/src/propsheet/registry.cpp (L309)
ab04067e49/src/propsheet/registry.cpp (L781)

server/WaitBlock.cpp

ab04067e49/src/server/WaitBlock.cpp (L243)

host/writeData.cpp

ab04067e49/src/host/writeData.cpp (L122)

propsheet/misc.cpp

ab04067e49/src/propsheet/misc.cpp (L470)

interactivity/base/ServiceLocator.cpp

ab04067e49/src/interactivity/base/ServiceLocator.cpp (L38)

host/stream.cpp

ab04067e49/src/host/stream.cpp (L76)

host/dbcs.cpp

ab04067e49/src/host/dbcs.cpp (L95)

server/IoSorter.cpp

ab04067e49/src/server/IoSorter.cpp (L91)

types/sgrStack.cpp

ab04067e49/src/types/sgrStack.cpp (L95)

Originally created by @DHowett on GitHub (Oct 27, 2022). > Back in 2018 we switched every `NTASSERT`/`ASSERT`/`NT_ASSERT` in these components to a `FAIL_FAST`, unequivocally, because if we cared enough to check it, we should care enough to die for it. > I think that’s good and valuable, and it has its place. > > Now that these components are shared with Terminal (who seeks to host multiple copies of each of them in parallel), and now that a11y has taken a bigger bet on them performing sanely and safely, > I’m wondering if we should scale back a little bit on the take down the entire process if something lifts off into space stance. > > We’re seeing a good number of crashes due to accessibility that I think should just be “oh, the API returned an error code, NVDA can recover”. We once saw reports that resizing the window when an unexpected DBCS half lands in the buffer (#4907) caused a crash. > > They’re programming errors, for sure, but our users probably want things to be more reliable. Should, or could, we surface those as exceptions and let the caller recover wherever possible? Should we just internally recover? Let's find out. --- Generated as of 2022-10-27 ab04067e49a9cf9eee36335d46eefbe13db72050 <details> <summary>How did I generate this?</summary> ```powershell rg -n FAIL_FAST_IF\`( --no-heading | % { $p=$_ -split ":"; $pa=$p[0] -replace "\\","/"; $ln=$p[1]; [pscustomobject]@{File=$pa;Line=$ln} } | group File | sort -Descending Count | % { "## $($_.Name)`n"; $_.Group | % { "https://github.com/microsoft/terminal/blob/$(git rev-parse HEAD)/src/$($_.File)#L$($_.Line)" }; "`n" } ``` </details> --- ## host/screenInfo.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L193 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L382-L383 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L402-L403 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L421-L422 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L453-L454 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L472-L473 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L600 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L905-L907 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/screenInfo.cpp#L1161 ## host/cmdline.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L284 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L448 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L483 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L519 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L651 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L665 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L677 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L685 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L766 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/cmdline.cpp#L1000 ## host/_stream.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/_stream.cpp#L252 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/_stream.cpp#L429 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/_stream.cpp#L608 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/_stream.cpp#L664 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/_stream.cpp#L974-L979 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/_stream.cpp#L1187 ## host/inputBuffer.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/inputBuffer.cpp#L376 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/inputBuffer.cpp#L513-L518 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/inputBuffer.cpp#L717-L718 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/inputBuffer.cpp#L784 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/inputBuffer.cpp#L785 ## propsheet/fontdlg.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/fontdlg.cpp#L704 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/fontdlg.cpp#L891 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/fontdlg.cpp#L1143 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/fontdlg.cpp#L1355 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/fontdlg.cpp#L1498 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/fontdlg.cpp#L1590 ## host/utils.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/utils.cpp#L176-L179 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/utils.cpp#L231-L232 ## interactivity/win32/icon.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/icon.cpp#L238-L241 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/icon.cpp#L265 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/icon.cpp#L288 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/icon.cpp#L320 ## host/readDataCooked.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/readDataCooked.cpp#L323 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/readDataCooked.cpp#L330-L333 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/readDataCooked.cpp#L1079 ## host/settings.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/settings.cpp#L355-L358 ## host/history.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/history.cpp#L41 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/history.cpp#L66 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/history.cpp#L92 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/history.cpp#L197 ## host/srvinit.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/srvinit.cpp#L827-L829 ## host/misc.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/misc.cpp#L25 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/misc.cpp#L245 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/misc.cpp#L272 ## interactivity/win32/window.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/window.cpp#L129 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/window.cpp#L531 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/window.cpp#L638 ## host/readDataDirect.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/readDataDirect.cpp#L74 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/readDataDirect.cpp#L77 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/readDataDirect.cpp#L181 ## server/ProcessList.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/ProcessList.cpp#L36 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/ProcessList.cpp#L88 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/ProcessList.cpp#L91 ## host/selectionInput.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/selectionInput.cpp#L25 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/selectionInput.cpp#L271 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/selectionInput.cpp#L336 ## tsf/TfEditSession.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/tsf/TfEditSession.cpp#L70 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/tsf/TfEditSession.cpp#L693 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/tsf/TfEditSession.cpp#L1030 ## server/ObjectHandle.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/ObjectHandle.cpp#L228 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/ObjectHandle.cpp#L242 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/ObjectHandle.cpp#L267 ## host/CommandListPopup.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/CommandListPopup.cpp#L58 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/CommandListPopup.cpp#L244 ## interactivity/win32/windowio.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/windowio.cpp#L69 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/win32/windowio.cpp#L992 ## host/conimeinfo.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/conimeinfo.cpp#L338 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/conimeinfo.cpp#L418 ## host/input.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/input.cpp#L199 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/input.cpp#L276 ## host/consoleInformation.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/consoleInformation.cpp#L72 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/consoleInformation.cpp#L84 ## host/readDataRaw.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/readDataRaw.cpp#L77-L79 ## tsf/TfDispAttr.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/tsf/TfDispAttr.cpp#L102 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/tsf/TfDispAttr.cpp#L115 ## host/inputReadHandleData.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/inputReadHandleData.cpp#L64 ## host/directio.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/directio.cpp#L196 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/directio.cpp#L239 ## host/ConsoleArguments.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/ConsoleArguments.cpp#L351 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/ConsoleArguments.cpp#L552 ## propsheet/registry.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/registry.cpp#L309 https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/registry.cpp#L781 ## server/WaitBlock.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/WaitBlock.cpp#L243 ## host/writeData.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/writeData.cpp#L122 ## propsheet/misc.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/propsheet/misc.cpp#L470 ## interactivity/base/ServiceLocator.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/interactivity/base/ServiceLocator.cpp#L38 ## host/stream.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/stream.cpp#L76 ## host/dbcs.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/dbcs.cpp#L95 ## server/IoSorter.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/server/IoSorter.cpp#L91 ## types/sgrStack.cpp https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/types/sgrStack.cpp#L95
claunia added the Product-ConhostNeeds-Tag-FixSeverity-CrashArea-CodeHealth labels 2026-01-31 06:23:33 +00:00
claunia commented 2026-01-31 06:23:33 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 27, 2022):

now that a11y has taken a bigger bet on them

For the record, all of the a11y-related crashes were removed in #13250, I believe.

@carlos-zamora commented on GitHub (Oct 27, 2022): > now that a11y has taken a bigger bet on them For the record, all of the a11y-related crashes were removed in #13250, I believe.
claunia commented 2026-01-31 06:23:34 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 2, 2022):

_stream.cpp:618 was removed in 86928bb48d.

@DHowett commented on GitHub (Nov 2, 2022): `_stream.cpp:618` was removed in 86928bb48d9963101af1f302d5939c7486cd822e.
claunia commented 2026-01-31 06:23:34 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Mar 14, 2023):

Removed ab04067e49/src/host/inputReadHandleData.cpp (L23) in anticipation for #14991.

@lhecker commented on GitHub (Mar 14, 2023): Removed https://github.com/microsoft/terminal/blob/ab04067e49a9cf9eee36335d46eefbe13db72050/src/host/inputReadHandleData.cpp#L23 in anticipation for #14991.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Needs-Tag-Fix Product-Conhost Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18759
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?