starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Code Health: follow ups from connection restarting #18812

New Issue
Closed
opened 2026-01-31 06:25:10 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 06:25:10 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Nov 3, 2022).

Originally assigned to: @zadjii-msft on GitHub.

From #14060. See also https://github.com/microsoft/terminal/pull/14060#pullrequestreview-1165989506

The control shouldn't be responsible for restarting the connection itself. It should request a new one from the app.

  • Move this code to the page, and bubble an event to request a new connection
  • Revert this
  • Investigate only clearing the buffer to scrollback, instead of inheritCursoring
Originally created by @zadjii-msft on GitHub (Nov 3, 2022). Originally assigned to: @zadjii-msft on GitHub. From #14060. See also https://github.com/microsoft/terminal/pull/14060#pullrequestreview-1165989506 The control shouldn't be responsible for restarting the connection itself. It should request a new one from the app. * [ ] Move [this code](https://github.com/sotteson1/terminal/blob/62888a5a0f2ccda00b53e52e96537fd67213e4ab/src/cascadia/TerminalControl/ControlCore.cpp#L415-L420) to the page, and bubble an event to request a new connection * [ ] Revert [this](https://github.com/sotteson1/terminal/blob/62888a5a0f2ccda00b53e52e96537fd67213e4ab/src/cascadia/TerminalConnection/ConnectionStateHolder.h#L89-L95) * [ ] Investigate only clearing the buffer to scrollback, instead of `inheritCursor`ing
claunia commented 2026-01-31 06:25:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 6, 2022):

I very much want to punt this to 1.18. There's a lot of stuff that I built for tear-out which will make this a lot easier to manage.

Now, we have to like, raise an event up to the Pane (who is hanging on to the Profile for this control), to ask the TerminalPage to build a new connection (because TPage alone knows how), then wire that back into the control

But tearout branches have more elaborate ConnectionInformation that we could just stash in the ControlCore and reuse immediately to build a new connection.

I wonder how painful that "backport" would be...

dev/migrie/b/cxn-restarting-attempt-1-backport has the start of this

@zadjii-msft commented on GitHub (Dec 6, 2022): I very much want to punt this to 1.18. There's a lot of stuff that I built for tear-out which will make this a lot easier to manage. Now, we have to like, raise an event up to the `Pane` (who is hanging on to the `Profile` for this control), to ask the `TerminalPage` to build a new connection (because TPage alone knows how), then wire that back into the control But tearout branches have more elaborate `ConnectionInformation` that we could just stash in the `ControlCore` and reuse immediately to build a new connection. I wonder how painful that "backport" would be... `dev/migrie/b/cxn-restarting-attempt-1-backport` has the start of this
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-TerminalConnection In-PR Issue-Task Needs-Tag-Fix Product-Terminal Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?