starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Voice Access] [Find(Ctrl+Shift+F)]: Voice Access users are not able to activate 'Find' edit field with its placeholder value. #18907

New Issue
Closed
opened 2026-01-31 06:27:54 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:27:54 +00:00
Owner
Copy Link

Originally created by @Shubham786786 on GitHub (Nov 16, 2022).

Windows Terminal version

1.17.3052.0

Windows build number

Windows 11 Version 22H2 (OS Build 25206.1000)

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal.
  2. Open find pop-up window with 'Ctrl+Shift+F' keys.
  3. Open Voice Access by 'Settings > Accessibility > Speech > Turn on Voice Access.
  4. Give command as 'Click' by Voice Access on the page to access 'Find' edit field.
  5. Observe the issue.

User Experience: -
Voice Access users will not be able to focus and hence access the find edit fields with visible name, if the accessible name defined for the edit field does not contain its visible placeholder name

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/label-in-name.html

Attachments:
Voice Access users are not able to activate 'Find' edit field with its placeholder value..zip

Expected Behavior

Accessible name for the edit field should start with visible placeholder text, it should be defined as 'Find, Search text', so that VA users can access it with 'Click' command.

https://nam06.safelinks.protection.outlook.com/?url=https:%2f%2fwww.osgwiki.com%2fwiki%2fVoiceAccess_Testing&data=05%7c01%7cv-chisha%40microsoft.com%7cad1aa7ab3c63420978a708da31b8e712%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c637876967593170034%7cUnknown%7cTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7c3000%7c%7c%7c&sdata=vx8nL3zR6xV5J7ImC%2BkIAygjzuu5wOXDwim31oXAtpc%3D&reserved=0

Actual Behavior

Voice Access users are not able to activate 'Find' edit field with its placeholder value, it's because incorrect accessible name as 'Search text' is defined for the 'Find' edit field.

Notes:

  1. Similar is the case with the combo boxes present throughout the application as users are not able to select the combo box with the currently selected value.
    NOTE1- Actions-Combo Box.zip
Originally created by @Shubham786786 on GitHub (Nov 16, 2022). ### Windows Terminal version 1.17.3052.0 ### Windows build number Windows 11 Version 22H2 (OS Build 25206.1000) ### Other Software _No response_ ### Steps to reproduce 1. Open Windows Terminal. 2. Open find pop-up window with 'Ctrl+Shift+F' keys. 3. Open Voice Access by 'Settings > Accessibility > Speech > Turn on Voice Access. 4. Give command as 'Click' by Voice Access on the page to access 'Find' edit field. 5. Observe the issue. **User Experience: -** Voice Access users will not be able to focus and hence access the find edit fields with visible name, if the accessible name defined for the edit field does not contain its visible placeholder name **Guideline Reference:** https://www.w3.org/WAI/WCAG21/Understanding/label-in-name.html **Attachments:** [Voice Access users are not able to activate 'Find' edit field with its placeholder value..zip](https://github.com/microsoft/terminal/files/10019688/Voice.Access.users.are.not.able.to.activate.Find.edit.field.with.its.placeholder.value.zip) ### Expected Behavior Accessible name for the edit field should start with visible placeholder text, it should be defined as 'Find, Search text', so that VA users can access it with 'Click' command. https://nam06.safelinks.protection.outlook.com/?url=https:%2f%2fwww.osgwiki.com%2fwiki%2fVoiceAccess_Testing&data=05%7c01%7cv-chisha%40microsoft.com%7cad1aa7ab3c63420978a708da31b8e712%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c637876967593170034%7cUnknown%7cTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7c3000%7c%7c%7c&sdata=vx8nL3zR6xV5J7ImC%2BkIAygjzuu5wOXDwim31oXAtpc%3D&reserved=0 ### Actual Behavior Voice Access users are not able to activate 'Find' edit field with its placeholder value, it's because incorrect accessible name as 'Search text' is defined for the 'Find' edit field. **Notes:** 1. Similar is the case with the combo boxes present throughout the application as users are not able to select the combo box with the currently selected value. [NOTE1- Actions-Combo Box.zip](https://github.com/microsoft/terminal/files/10029283/NOTE1-.Actions-Combo.Box.zip)
claunia commented 2026-01-31 06:27:57 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Dec 8, 2022):

Hi @Shubham786786. I'm a bit confused regarding the additional notes from the issue above:

  1. Similar is the case with the combo boxes present throughout the application as users are not able to select the combo box with the currently selected value.

The UIA tree for the combo box in the actions page looks as follows:
image

I specifically want to highlight the following notes from the image above:

  • "Action" is the name of the combo box
  • "Add a scroll mark" is the name of the internal list item

As the user changes the selected list item, "Add a scroll mark" is correctly replaced, but "Action" remains the same. As of now, this is by design, because the user is setting the action, so this seems to make sense.

My question is, what are we supposed to do here? Is the name of the combo box supposed to match that of the selected item? If so, won't that be confusing because the user then loses context over what the combo box represents (in this case, an action)?

@carlos-zamora commented on GitHub (Dec 8, 2022): Hi @Shubham786786. I'm a bit confused regarding the additional notes from the issue above: > 1. Similar is the case with the combo boxes present throughout the application as users are not able to select the combo box with the currently selected value. The UIA tree for the combo box in the actions page looks as follows: <img width="169" alt="image" src="https://user-images.githubusercontent.com/11050425/206572180-174d8679-9765-4ad4-af5a-054f31f8a057.png"> I specifically want to highlight the following notes from the image above: - "Action" is the name of the combo box - "Add a scroll mark" is the name of the internal list item As the user changes the selected list item, "Add a scroll mark" is correctly replaced, but "Action" remains the same. As of now, this is by design, because the user is setting the action, so this seems to make sense. My question is, what are we supposed to do here? Is the name of the combo box supposed to match that of the selected item? If so, won't that be confusing because the user then loses context over what the combo box represents (in this case, an action)?
claunia commented 2026-01-31 06:27:57 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Dec 9, 2022):

Additionally, I took a look at the Settings App in Windows and I've noticed the following setting:
image

Is represented as such:
image

This is pretty similar to our current design where the name of the combo box is the "setting" but the selected value appears as a child list item.

@carlos-zamora commented on GitHub (Dec 9, 2022): Additionally, I took a look at the Settings App in Windows and I've noticed the following setting: <img width="698" alt="image" src="https://user-images.githubusercontent.com/11050425/206753877-41624b89-540c-43cd-b18c-81fbcc0776a2.png"> Is represented as such: <img width="234" alt="image" src="https://user-images.githubusercontent.com/11050425/206753924-1faab55a-2fd2-4eea-bd95-dcc12974fe66.png"> This is pretty similar to our current design where the name of the combo box is the "setting" but the selected value appears as a child list item.
claunia commented 2026-01-31 06:27:57 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14519, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14519, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11ySev2 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Product-Terminal Resolution-Fix-Committed WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?