Add the setting "confirmCloseAllTabs" to the UI #18930

Closed
opened 2026-01-31 06:28:47 +00:00 by claunia · 2 comments
Owner

Originally created by @ElitePheonix2009 on GitHub (Nov 20, 2022).

Description of the new feature/enhancement

The setting "confirmCloseAllTabs" should be added to the ui so that it can be easily found.

Proposed technical implementation details (optional)

Originally created by @ElitePheonix2009 on GitHub (Nov 20, 2022). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> The setting "confirmCloseAllTabs" should be added to the ui so that it can be easily found. # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
Author
Owner

@zadjii-msft commented on GitHub (Nov 21, 2022):

Huh, we didn't have one for this one. Good catch!

There was some discussion about this in #10000

  • these might not make sense in SUI. I think we'd prefer to add a checkbox or something to the warning dialogs saying "don't show this again". So maybe we want to deprecate these settings?
  • zadjii note: I think these do make sense in the SUI. We need to expose ways to reveal the state of the application, including if these warnings have been disabled. I'd put these under "Interaction"
@zadjii-msft commented on GitHub (Nov 21, 2022): Huh, we didn't have one for this one. Good catch! There was some discussion about this in #10000 > - these might not make sense in SUI. I think we'd prefer to add a checkbox or something to the warning dialogs saying "don't show this again". So maybe we want to deprecate these settings? > - largePasteWarning > - multiLinePasteWarning > - confirmCloseAllTabs (see also https://github.com/microsoft/terminal/issues/14413) > - zadjii note: I think these do make sense in the SUI. We need to expose ways to reveal the state of the application, including if these warnings have been disabled. I'd put these under "Interaction"
Author
Owner

@ghost commented on GitHub (Dec 14, 2022):

:tada:This issue was addressed in #14419, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.🎉

Handy links:

@ghost commented on GitHub (Dec 14, 2022): :tada:This issue was addressed in #14419, which has now been successfully released as `Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.3464.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#18930