starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Corrupted last error after deprecated/unsupported API calls #19003

New Issue
Open
opened 2026-01-31 06:30:51 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 06:30:51 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Dec 2, 2022).

Windows Terminal version

No response

Windows build number

10.0.19044.2006

Other Software

No response

Steps to reproduce

Basically the problem is nicely described in this SO answer.

3c78e01ab5/src/server/ApiDispatchersInternal.cpp (L22)
ServerDeprecatedApi uses E_NOTIMPL (0x80004001), which on its way to the caller suffers several transformations and becomes 0x00004001, which is not a valid Windows error code.

It is quite unfortunate, given that the whole idea is to make it clear to the caller that the call is deprecated/not implemented.

Perhaps the function could use a different code that won't get fubared beyond recognition?
Given that it is passed to RtlNtStatusToDosError on its way, it probably should be NTSTATUS in the first place, either just raw STATUS_NOT_IMPLEMENTED or packed into HRESULT as HRESULT_FROM_NT(STATUS_NOT_IMPLEMENTED).

Expected Behavior

After an unsupported call:

  • GetLastError() should return a sensible value, e.g. ERROR_INVALID_FUNCTION or ERROR_CALL_NOT_IMPLEMENTED
  • (optionally) RtlGetLastNtStatus() should return a sensible value, e.g. STATUS_NOT_IMPLEMENTED

Actual Behavior

  • GetLastError() returns 0x0004001, which is an invalid error code.
  • RtlGetLastNtStatus() returns 0xC0074001, which is the same invalid win32 error code with STATUS_SEVERITY_ERROR and FACILITY_NTWIN32 bits.
Originally created by @alabuzhev on GitHub (Dec 2, 2022). ### Windows Terminal version _No response_ ### Windows build number 10.0.19044.2006 ### Other Software _No response_ ### Steps to reproduce Basically the problem is nicely described in [this SO answer](https://stackoverflow.com/a/61475022). https://github.com/microsoft/terminal/blob/3c78e01ab5a025290b8953a6dc0f2695c76c223e/src/server/ApiDispatchersInternal.cpp#L22 `ServerDeprecatedApi` uses `E_NOTIMPL` (0x80004001), which on its way to the caller suffers several transformations and becomes 0x00004001, which is not a valid Windows error code. It is quite unfortunate, given that the whole idea is to make it clear to the caller that the call is deprecated/not implemented. Perhaps the function could use a different code that won't get fubared beyond recognition? Given that it is passed to `RtlNtStatusToDosError` on its way, it probably should be `NTSTATUS` in the first place, either just raw `STATUS_NOT_IMPLEMENTED` or packed into HRESULT as `HRESULT_FROM_NT(STATUS_NOT_IMPLEMENTED)`. ### Expected Behavior After an unsupported call: - `GetLastError()` should return a sensible value, e.g. `ERROR_INVALID_FUNCTION` or `ERROR_CALL_NOT_IMPLEMENTED` - (optionally) `RtlGetLastNtStatus()` should return a sensible value, e.g. `STATUS_NOT_IMPLEMENTED` ### Actual Behavior - `GetLastError()` returns 0x0004001, which is an invalid error code. - `RtlGetLastNtStatus()` returns 0xC0074001, which is the same invalid win32 error code with `STATUS_SEVERITY_ERROR` and `FACILITY_NTWIN32` bits.
claunia added the Help WantedProduct-ConhostIssue-BugPriority-3Area-Server labels 2026-01-31 06:30:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Help Wanted Issue-Bug Priority-3 Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19003
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?