starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.15+] timeout in a batch script instantly exits a defterm window #19019

New Issue
Closed
opened 2026-01-31 06:31:21 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:31:21 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Dec 6, 2022).

Oh god this is so much worse in 1.15. It doesn't timeout at all, it instantly exits!

echo foo
@rem set /p id=Enter ID: 
timeout /t 10
echo bar
exit 1234

image

Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/issues/12951#issuecomment-1338357561

Originally created by @zadjii-msft on GitHub (Dec 6, 2022). Oh god this is so much worse in 1.15. It doesn't timeout at all, it instantly exits! ```cmd echo foo @rem set /p id=Enter ID: timeout /t 10 echo bar exit 1234 ``` ![image](https://user-images.githubusercontent.com/18356694/205757385-aa1719f2-cffd-41ee-8d9b-a8ec19051610.png) _Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/issues/12951#issuecomment-1338357561_
claunia added the Issue-BugNeeds-Tag-FixProduct-TerminalPriority-1Area-DefApp labels 2026-01-31 06:31:21 +00:00
claunia commented 2026-01-31 06:31:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 6, 2022):

OH oh oh I bet this has to do with focus events. That's my guess - timeout will bail on input. Like, any input? That I'm not sure about. But I bet the regression between 1.12 when this was filed, and now (1.15/16/17) is the focus event stuff, and I bet eveything is immediately getting a focus event in the input queue right off the bat.

I'll need to go inspect timeout's source to confirm. That's my hypothesis.

Notably, this doesn't repro the same if you actually "restart" the batch script, until you press a key:
image

I noticed this when I restored the Terminal from being quit, and this defterm window came back (presumably, without the focus event). This might be related to #13514

Okay, my hypothesis was wrong. Looks like timeout does filter FOCUS events out... even if it does have some other horrifying code in it.

@zadjii-msft commented on GitHub (Dec 6, 2022): ~OH oh oh I bet this has to do with focus events. That's my guess - `timeout` will bail on input. Like, any input? That I'm not sure about. But I bet the regression between 1.12 when this was filed, and now (1.15/16/17) is the focus event stuff, and I bet eveything is immediately getting a focus event in the input queue right off the bat.~ I'll need to go inspect `timeout`'s source to confirm. That's my hypothesis. Notably, this doesn't repro the same if you actually "restart" the batch script, until you press a key: ![image](https://user-images.githubusercontent.com/18356694/205942092-7f79e221-790c-47cc-8ee5-9df8cf558c8a.png) I noticed this when I restored the Terminal from being quit, and this defterm window came back ~(presumably, without the focus event)~. This might be related to #13514 Okay, my hypothesis was wrong. Looks like `timeout` does filter FOCUS events out... even if it does have some other horrifying code in it.
claunia commented 2026-01-31 06:31:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 20, 2023):

Uh, this looks fixed. At least in 1.19.whatever.this.selfhost.build.is

@zadjii-msft commented on GitHub (Sep 20, 2023): Uh, this looks fixed. At least in 1.19.whatever.this.selfhost.build.is
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-DefApp Issue-Bug Needs-Tag-Fix Priority-1 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?