starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

New Tab Menu overlaps Close Dialog #19051

New Issue
Closed
opened 2026-01-31 06:32:26 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 06:32:26 +00:00
Owner
Copy Link

Originally created by @Lo0oG on GitHub (Dec 12, 2022).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

Have more than one tab open and then click on the down arrow next to the new tab button to make the tab menu option appear. Then click on the close window.

Expected Behavior

New tab menu should not overlap close dialog

Actual Behavior

Some of the close dialog is hidden behind the new tab menu.
image

Originally created by @Lo0oG on GitHub (Dec 12, 2022). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce Have more than one tab open and then click on the down arrow next to the new tab button to make the tab menu option appear. Then click on the close window. ### Expected Behavior New tab menu should not overlap close dialog ### Actual Behavior Some of the close dialog is hidden behind the new tab menu. ![image](https://user-images.githubusercontent.com/50969206/207101427-b1416dcc-c389-4e39-b187-3da4b54beed3.png)
claunia commented 2026-01-31 06:32:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 12, 2022):

What OS, Terminal version are you on/? I can't repro this locally on 10.0.25267.1001. This might be an OS bug that was fixed, or it might have even been fixed in the Terminal itself...

@zadjii-msft commented on GitHub (Dec 12, 2022): What OS, Terminal version are you on/? I can't repro this locally on `10.0.25267.1001`. This might be an OS bug that was fixed, or it might have even been fixed in the Terminal itself...
claunia commented 2026-01-31 06:32:28 +00:00
Author
Owner
Copy Link

@Lo0oG commented on GitHub (Dec 12, 2022):

Sorry for missing those out initially.
Terminal is 1.15.2874.0
OS is 10.0.19044

@Lo0oG commented on GitHub (Dec 12, 2022): Sorry for missing those out initially. Terminal is 1.15.2874.0 OS is 10.0.19044
claunia commented 2026-01-31 06:32:28 +00:00
Author
Owner
Copy Link

@elsaco commented on GitHub (Dec 12, 2022):

@Lo0oG try adding a 3rd tab or more and the drop-down moves further left. It overlaps when there are only 2 tabs open:

close_all_tabs

Test was done on Windows 10.

@elsaco commented on GitHub (Dec 12, 2022): @Lo0oG try adding a 3rd tab or more and the drop-down moves further left. It overlaps when there are only 2 tabs open: ![close_all_tabs](https://user-images.githubusercontent.com/3933920/207116488-2fa09294-8eb4-461a-87d1-c213679bf351.png) Test was done on Windows 10.
claunia commented 2026-01-31 06:32:29 +00:00
Author
Owner
Copy Link

@Lo0oG commented on GitHub (Dec 12, 2022):

Yes, if the window is big enough or there are more tabs then the menu does not cover the dialog, but you can't really call that a fix.
Also, the menu doesn't get greyed out when the rest of the window does, but that's just a minor issue.

@Lo0oG commented on GitHub (Dec 12, 2022): Yes, if the window is big enough or there are more tabs then the menu does not cover the dialog, but you can't really call that a fix. Also, the menu doesn't get greyed out when the rest of the window does, but that's just a minor issue.
claunia commented 2026-01-31 06:32:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 12, 2022):

Yea, okay, I'm seeing this on my 19041 VM as well. I reckon this was probably a XAML islands bug that got sorted out between Windows 10 and Windows 11. I can try and dig up the internal bug number if we really need, but that might take a while for something of fairly low value. There's almost no chance that this gets backported to Windows 10, unfortunately 😕

Interesting catch though! The Flyout is always in the "topmost" layer of our window. I reckon this is due to the ContentDialog not dismissing any Popups in the PopupRoot, so the flyout ends up sticking around over the window.

@zadjii-msft commented on GitHub (Dec 12, 2022): Yea, okay, I'm seeing this on my 19041 VM as well. I reckon this was probably a XAML islands bug that got sorted out between Windows 10 and Windows 11. I can try and dig up the internal bug number if we really need, but that might take a while for something of fairly low value. There's almost no chance that this gets backported to Windows 10, unfortunately 😕 Interesting catch though! The Flyout is always in the "topmost" layer of our window. I reckon this is due to the ContentDialog not dismissing any Popups in the PopupRoot, so the flyout ends up sticking around over the window.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Attention Needs-Triage Resolution-External Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?