starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Using Narrator on a newly opened tab hits an assert #19054

New Issue
Closed
opened 2026-01-31 06:32:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 06:32:30 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Dec 13, 2022).

Windows Terminal version

main at 68cce101b

Windows build number

25267.1001

Other Software

No response

Steps to reproduce

  1. Turn on Narrator
  2. Open a debug build of Windows Terminal
  3. (if necessary) Click on Windows Terminal

Expected Behavior

No assert should occur

Actual Behavior

We're calling a Viewport::CompareInBounds({0,-20}, {0,8}, true).
First line in there is IsInBounds({0,-20}, true).

Obviously, {0,-20} is out of bounds, so we IsInBounds() returns false and fails the assert.

Call stack:

 	Microsoft.Terminal.Control.dll!Microsoft::Console::Types::Viewport::CompareInBounds(const til::point first, const til::point second, bool allowEndExclusive) Line 372	C++
 	Microsoft.Terminal.Control.dll!Microsoft::Console::Types::UiaTextRangeBase::_expandToEnclosingUnit(TextUnit unit) Line 296	C++
 	Microsoft.Terminal.Control.dll!Microsoft::Console::Types::UiaTextRangeBase::ExpandToEnclosingUnit(TextUnit unit) Line 273	C++

If you're curious, we're apparently trying to expand by word.

Originally created by @carlos-zamora on GitHub (Dec 13, 2022). ### Windows Terminal version `main` at 68cce101b ### Windows build number 25267.1001 ### Other Software _No response_ ### Steps to reproduce 1. Turn on Narrator 2. Open a debug build of Windows Terminal 3. (if necessary) Click on Windows Terminal ### Expected Behavior No assert should occur ### Actual Behavior We're calling a `Viewport::CompareInBounds({0,-20}, {0,8}, true)`. First line in there is `IsInBounds({0,-20}, true)`. Obviously, `{0,-20}` is out of bounds, so we `IsInBounds()` returns false and fails the assert. Call stack: ``` Microsoft.Terminal.Control.dll!Microsoft::Console::Types::Viewport::CompareInBounds(const til::point first, const til::point second, bool allowEndExclusive) Line 372 C++ Microsoft.Terminal.Control.dll!Microsoft::Console::Types::UiaTextRangeBase::_expandToEnclosingUnit(TextUnit unit) Line 296 C++ Microsoft.Terminal.Control.dll!Microsoft::Console::Types::UiaTextRangeBase::ExpandToEnclosingUnit(TextUnit unit) Line 273 C++ ``` If you're curious, we're apparently trying to expand by word.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19054
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?