Add Settings Page #1907

Closed
opened 2026-01-30 22:41:41 +00:00 by claunia · 5 comments
Owner

Originally created by @ThePharaohArt on GitHub (Jun 22, 2019).

Summary of the new feature/enhancement

Users who do not want to tinker in the js file to get the desired settings would have a better time in the settings enabling or disabling certain features. Or changing the font much more easily.

Proposed technical implementation details (optional)

When clicking on the settings option it should open up a page where one would be able to easily change their settings as they please via a GUI and not through a JS text editor.

Originally created by @ThePharaohArt on GitHub (Jun 22, 2019). # Summary of the new feature/enhancement <!-- Add a proper settings page for Windows Terminal A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). -->Users who do not want to tinker in the js file to get the desired settings would have a better time in the settings enabling or disabling certain features. Or changing the font much more easily. # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. --> When clicking on the settings option it should open up a page where one would be able to easily change their settings as they please via a GUI and not through a JS text editor.
Author
Owner

@imjasonmiller commented on GitHub (Jun 22, 2019):

Users who do not want to tinker in the js file ...

Aren't most active users of the terminal familiar with .json files? It makes it much easier to share settings with other users and devices. They briefly touched on this during this talk and mentioned that it was a big ask from the community.
I can imagine that the current implementation might allow developers to move faster as well.

@imjasonmiller commented on GitHub (Jun 22, 2019): > Users who do not want to tinker in the js file ... Aren't most active users of the terminal familiar with `.json` files? It makes it much easier to share settings with other users and devices. They briefly touched on this during [this talk](https://www.youtube.com/watch?v=KMudkRcwjCw&t=1040) and mentioned that it was a big ask from the community. I can imagine that the current implementation might allow developers to move faster as well.
Author
Owner

@josh-degraw commented on GitHub (Jun 22, 2019):

@imjasonmiller I personally don't mind that the config is in json, for me the issue is knowing what can go where. The schema documentation page took me a while to find and was less clear than it could be, and there were things I'd seen other people try with the terminal but couldn't find out how to do it.

What I would love is basically just a wrapper on top of the config file, in a similar way as how VsCode handles configuration. You can use the GUI if you want, or if you prefer or need more advanced config you can open the json file.

Another annoyance for me was that when I hit settings it launched visual studio, and I thought my system was trying to relaunch that after rebooting, so I hit settings again a couple of times and it launched like 5 instances of Visual Studio before it actually opened.

I'm aware that's because VS is the default for that on my machine for some reason, which I will change, but it was still a confusion/hassle.

@josh-degraw commented on GitHub (Jun 22, 2019): @imjasonmiller I personally don't mind that the config is in json, for me the issue is knowing what can go where. The schema documentation page took me a while to find and was less clear than it could be, and there were things I'd seen other people try with the terminal but couldn't find out how to do it. What I would love is basically just a wrapper on top of the config file, in a similar way as how VsCode handles configuration. You can use the GUI if you want, or if you prefer or need more advanced config you can open the json file. Another annoyance for me was that when I hit settings it launched visual studio, and I thought my system was trying to relaunch that after rebooting, so I hit settings again a couple of times and it launched like 5 instances of Visual Studio before it actually opened. I'm aware that's because VS is the default for that on my machine for some reason, which I will change, but it was still a confusion/hassle.
Author
Owner

@csm10495 commented on GitHub (Jun 22, 2019):

I'm going to agree that a settings GUI would be nicer than a json file. I guess if someone really wants to mess with the raw file, they still could. A GUI works better for me since its easier to read and layout than a raw file. We can also have descriptions for the different options.

... reminds me of the similar changes that were made to VS Code to have a settings GUI instead of just a raw json.

@csm10495 commented on GitHub (Jun 22, 2019): I'm going to agree that a settings GUI would be nicer than a json file. I guess if someone really wants to mess with the raw file, they still could. A GUI works better for me since its easier to read and layout than a raw file. We can also have descriptions for the different options. ... reminds me of the similar changes that were made to VS Code to have a settings GUI instead of just a raw json.
Author
Owner

@cinnamon-msft commented on GitHub (Jun 24, 2019):

#1564

@cinnamon-msft commented on GitHub (Jun 24, 2019): #1564
Author
Owner

@Nyameliaaaa commented on GitHub (Jan 16, 2020):

I believe that users who even use the terminal can tinker in raw json, so this is useless.

@Nyameliaaaa commented on GitHub (Jan 16, 2020): I believe that users who even use the terminal can tinker in raw json, so this is useless.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1907