starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.17] Setting the $theme.tabRow.background to #00000000 results in double titlebar #19080

New Issue
Closed
opened 2026-01-31 06:33:13 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 06:33:13 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Dec 15, 2022).

Originally assigned to: @zadjii-msft on GitHub.

MicrosoftTeams-image (4)
Originally created by @carlos-zamora on GitHub (Dec 15, 2022). Originally assigned to: @zadjii-msft on GitHub. <img width="104" alt="MicrosoftTeams-image (4)" src="https://user-images.githubusercontent.com/11050425/207742017-9d3412af-d59b-43ff-8f0e-43b8b2e984da.png">
claunia added the Resolution-Fix-CommittedIssue-BugProduct-TerminalArea-Theming labels 2026-01-31 06:33:13 +00:00
claunia commented 2026-01-31 06:33:14 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 15, 2022):

GAH GOD I thought I fixed that. Regressed probably in the last few commits of #13935

@zadjii-msft commented on GitHub (Dec 15, 2022): GAH GOD I thought I fixed that. Regressed probably in the last few commits of #13935
claunia commented 2026-01-31 06:33:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 4, 2023):

Uh shoot I'm not seeing this

image

That's on 1.17.3481.0.

Maybe I need a different set of settings?

@zadjii-msft commented on GitHub (Jan 4, 2023): Uh shoot I'm not seeing this ![image](https://user-images.githubusercontent.com/18356694/210573934-65dac8f2-0cfc-463f-8c91-0fed9a64dadc.png) That's on `1.17.3481.0`. Maybe I need a different set of settings?
claunia commented 2026-01-31 06:33:15 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 9, 2023):

So, I've noticed that I only see this after a settings reload... or sometimes when locking/unlocking my workstation. There's some interplay between the different window styles we go through on the way to "no titlebar."

@DHowett commented on GitHub (Jan 9, 2023): So, I've noticed that I only see this after a settings reload... or sometimes when locking/unlocking my workstation. There's some interplay between the different window styles we go through on the way to "no titlebar."
claunia commented 2026-01-31 06:33:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 9, 2023):

what settings tho

@zadjii-msft commented on GitHub (Jan 9, 2023): what settings tho
claunia commented 2026-01-31 06:33:15 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 9, 2023):

This is all I've got in the themes department:

    "theme": "Cool Things",
    "themes": 
    [
        {
            "name": "Cool Things",
            "tab": 
            {
                "background": "terminalBackground",
                "showCloseButton": "always",
                "unfocusedBackground": null
            },
            "tabRow": 
            {
                "background": "#00000000",
                "unfocusedBackground": null
            }
        }
    ],
    "alwaysShowTabs": true,
    "showTabsInTitlebar": true,
@DHowett commented on GitHub (Jan 9, 2023): This is all I've got in the themes department: ```json "theme": "Cool Things", "themes": [ { "name": "Cool Things", "tab": { "background": "terminalBackground", "showCloseButton": "always", "unfocusedBackground": null }, "tabRow": { "background": "#00000000", "unfocusedBackground": null } } ], "alwaysShowTabs": true, "showTabsInTitlebar": true, ```
claunia commented 2026-01-31 06:33:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 19, 2023):

FUDGE okay, that does repro for me, with
image

I'll figure that out. I bet there's a weird interaction between the #00000000 and the null

@zadjii-msft commented on GitHub (Jan 19, 2023): FUDGE okay, that does repro for me, with ![image](https://user-images.githubusercontent.com/18356694/213565417-44e8121d-01b2-477a-8a8a-18978b5e641c.png) I'll figure that out. I bet there's a weird interaction between the `#00000000` and the `null`
claunia commented 2026-01-31 06:33:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 19, 2023):

Yep, that's what does it.

If the window is inactive when the settings are changed, the NCIW will use the current TitlebarBrush to determine if we need to totally obscure the titlebar or not. For this theme, the ThemeColor is null, so the NCIW evaluates that as opaque, so it decides it's fine to have a titlebar.

Easiest way to do this is probably expose another property out of applogic to make this easy.

@zadjii-msft commented on GitHub (Jan 19, 2023): Yep, that's what does it. If the window is inactive when the settings are changed, the NCIW will use the _current_ `TitlebarBrush` to determine if we need to totally obscure the titlebar or not. For this theme, the ThemeColor is null, so the NCIW evaluates that as opaque, so it decides it's fine to have a titlebar. Easiest way to do this is probably expose another property out of applogic to make this easy.
claunia commented 2026-01-31 06:33:16 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 19, 2023):

Thanks for digging through my bad bug reports haha

@DHowett commented on GitHub (Jan 19, 2023): Thanks for digging through my bad bug reports haha
claunia commented 2026-01-31 06:33:16 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14708, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14708, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?