starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-19 05:41:47 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Exception when exiting the terminal (NavigationView::RevokeNavigationViewItemRevokers) #19086

New Issue
Closed
opened 2026-01-31 06:33:24 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 06:33:24 +00:00
Owner
Copy Link

Originally created by @skyline75489 on GitHub (Dec 15, 2022).

Originally assigned to: @PankajBhojwani on GitHub.

Windows Terminal version

286fdfea79

Windows build number

10.0.22623.1028

Other Software

No response

Steps to reproduce

  • Debug the terminal (release build
  • Exit the terminal while VS is attached.

Expected Behavior

No crash

Actual Behavior

Crashed at https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/App.cpp#L66

屏幕截图 2022-12-15 135058

Not really a bit deal. Just trying out the latest dev build and see this. Might as well report it.

Originally created by @skyline75489 on GitHub (Dec 15, 2022). Originally assigned to: @PankajBhojwani on GitHub. ### Windows Terminal version 286fdfea798201c68e6b1d7e11ae746a913df26e ### Windows build number 10.0.22623.1028 ### Other Software _No response_ ### Steps to reproduce * Debug the terminal (release build * Exit the terminal while VS is attached. ### Expected Behavior No crash ### Actual Behavior Crashed at https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/App.cpp#L66 ![屏幕截图 2022-12-15 135058](https://user-images.githubusercontent.com/4710575/207783395-82957960-7b27-4992-8775-41d3c05c0639.png) Not really a bit deal. Just trying out the latest dev build and see this. Might as well report it.
claunia commented 2026-01-31 06:33:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 15, 2022):

Yikes. Do you have a whole stack trace we can look at/?

@zadjii-msft commented on GitHub (Dec 15, 2022): Yikes. Do you have a whole stack trace we can look at/?
claunia commented 2026-01-31 06:33:26 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Dec 15, 2022):

Sadly no. Should've captured the stack, too. Maybe someone in the future will provide more information.

@skyline75489 commented on GitHub (Dec 15, 2022): Sadly no. Should've captured the stack, too. Maybe someone in the future will provide more information.
claunia commented 2026-01-31 06:33:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 15, 2022):

I may have just hit this:

 	KernelBase.dll!00007ffb4414c0ec()	Unknown
 	vcruntime140.dll!00007ffb2d1d64c0()	Unknown
 	Microsoft.UI.Xaml.dll!winrt::throw_hresult(const winrt::hresult result) Line 4892	C++
 	[Inline Frame] Microsoft.UI.Xaml.dll!winrt::check_hresult(const winrt::hresult) Line 4962	C++
 	Microsoft.UI.Xaml.dll!winrt::impl::consume_Windows_UI_Xaml_IDependencyObject<winrt::Microsoft::UI::Xaml::Controls::NavigationViewItem>::GetValue(const winrt::Windows::UI::Xaml::DependencyProperty & dp) Line 868	C++
 	Microsoft.UI.Xaml.dll!NavigationView::RevokeNavigationViewItemRevokers(const winrt::Microsoft::UI::Xaml::Controls::NavigationViewItem & nvi) Line 3445	C++
 	Microsoft.UI.Xaml.dll!NavigationView::ClearAllNavigationViewItemRevokers() Line 3436	C++
 	Microsoft.UI.Xaml.dll!NavigationView::UnhookEventsAndClearFields(bool isFromDestructor) Line 186	C++
 	Microsoft.UI.Xaml.dll!NavigationView::~NavigationView() Line 112	C++
 	[External Code]	
 	Microsoft.UI.Xaml.dll!winrt::implements<NavigationView,winrt::Microsoft::UI::Xaml::Controls::NavigationView,winrt::Microsoft::UI::Xaml::Controls::INavigationView2,winrt::composable,winrt::composing,winrt::Windows::UI::Xaml::Controls::IContentControlOverrides,winrt::Windows::UI::Xaml::Controls::IControlOverrides,winrt::Windows::UI::Xaml::Controls::IControlOverrides6,winrt::Windows::UI::Xaml::IFrameworkElementOverrides,winrt::Windows::UI::Xaml::IFrameworkElementOverrides2,winrt::Windows::UI::Xaml::IUIElementOverrides,winrt::Windows::UI::Xaml::IUIElementOverrides7,winrt::Windows::UI::Xaml::IUIElementOverrides8,winrt::Windows::UI::Xaml::IUIElementOverrides9,IReferenceTrackerExtension>::Release() Line 7802	C++
 	[External Code]	
>	TerminalApp.dll!winrt::TerminalApp::implementation::App::Close() Line 66	C++
 	TerminalApp.dll!winrt::impl::produce<winrt::TerminalApp::implementation::App,winrt::Windows::Foundation::IClosable>::Close() Line 1082	C++
 	WindowsTerminal.exe!winrt::impl::consume_Windows_Foundation_IClosable<winrt::TerminalApp::App>::Close() Line 121	C++
 	WindowsTerminal.exe!AppHost::~AppHost() Line 150	C++
 	WindowsTerminal.exe!wWinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, wchar_t * __formal, int __formal) Line 193	C++
 	[External Code]

I was exiting, with VS attached, two tabs (one pwsh(active), one SUI), close dialog open. Weird.

@zadjii-msft commented on GitHub (Dec 15, 2022): I may have just hit this: ``` KernelBase.dll!00007ffb4414c0ec() Unknown vcruntime140.dll!00007ffb2d1d64c0() Unknown Microsoft.UI.Xaml.dll!winrt::throw_hresult(const winrt::hresult result) Line 4892 C++ [Inline Frame] Microsoft.UI.Xaml.dll!winrt::check_hresult(const winrt::hresult) Line 4962 C++ Microsoft.UI.Xaml.dll!winrt::impl::consume_Windows_UI_Xaml_IDependencyObject<winrt::Microsoft::UI::Xaml::Controls::NavigationViewItem>::GetValue(const winrt::Windows::UI::Xaml::DependencyProperty & dp) Line 868 C++ Microsoft.UI.Xaml.dll!NavigationView::RevokeNavigationViewItemRevokers(const winrt::Microsoft::UI::Xaml::Controls::NavigationViewItem & nvi) Line 3445 C++ Microsoft.UI.Xaml.dll!NavigationView::ClearAllNavigationViewItemRevokers() Line 3436 C++ Microsoft.UI.Xaml.dll!NavigationView::UnhookEventsAndClearFields(bool isFromDestructor) Line 186 C++ Microsoft.UI.Xaml.dll!NavigationView::~NavigationView() Line 112 C++ [External Code] Microsoft.UI.Xaml.dll!winrt::implements<NavigationView,winrt::Microsoft::UI::Xaml::Controls::NavigationView,winrt::Microsoft::UI::Xaml::Controls::INavigationView2,winrt::composable,winrt::composing,winrt::Windows::UI::Xaml::Controls::IContentControlOverrides,winrt::Windows::UI::Xaml::Controls::IControlOverrides,winrt::Windows::UI::Xaml::Controls::IControlOverrides6,winrt::Windows::UI::Xaml::IFrameworkElementOverrides,winrt::Windows::UI::Xaml::IFrameworkElementOverrides2,winrt::Windows::UI::Xaml::IUIElementOverrides,winrt::Windows::UI::Xaml::IUIElementOverrides7,winrt::Windows::UI::Xaml::IUIElementOverrides8,winrt::Windows::UI::Xaml::IUIElementOverrides9,IReferenceTrackerExtension>::Release() Line 7802 C++ [External Code] > TerminalApp.dll!winrt::TerminalApp::implementation::App::Close() Line 66 C++ TerminalApp.dll!winrt::impl::produce<winrt::TerminalApp::implementation::App,winrt::Windows::Foundation::IClosable>::Close() Line 1082 C++ WindowsTerminal.exe!winrt::impl::consume_Windows_Foundation_IClosable<winrt::TerminalApp::App>::Close() Line 121 C++ WindowsTerminal.exe!AppHost::~AppHost() Line 150 C++ WindowsTerminal.exe!wWinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, wchar_t * __formal, int __formal) Line 193 C++ [External Code] ``` I was exiting, with VS attached, two tabs (one pwsh(active), one SUI), close dialog open. Weird.
claunia commented 2026-01-31 06:33:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 15, 2022):

RevokeNavigationViewItemRevokers

this sounds familiar...

I wonder if we're just hitting it in a different place or with different timing due to the removal of Toolkit XamlApplication?

@DHowett commented on GitHub (Dec 15, 2022): > RevokeNavigationViewItemRevokers _this sounds familiar..._ I wonder if we're just hitting it in a different place or with different timing due to the removal of Toolkit XamlApplication?
claunia commented 2026-01-31 06:33:26 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Dec 16, 2022):

@zadjii-msft Your stack looks about the same as what I saw. Guess it's the same one.

@skyline75489 commented on GitHub (Dec 16, 2022): @zadjii-msft Your stack looks about the same as what I saw. Guess it's the same one.
claunia commented 2026-01-31 06:33:27 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Jan 17, 2023):

Turns out that this is a XAML issue. Closing as resolution-external.

@PankajBhojwani commented on GitHub (Jan 17, 2023): Turns out that this is a [XAML issue](https://github.com/microsoft/microsoft-ui-xaml/pull/7592). Closing as resolution-external.
claunia commented 2026-01-31 06:33:27 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 17, 2023):

Is it though? I thought we ingested a 2.7 build that had fixed this? Or am I just misremembering?

@zadjii-msft commented on GitHub (Jan 17, 2023): Is it though? I thought we ingested a 2.7 build that had fixed this? Or am I just misremembering?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Issue-Bug Product-Terminal Resolution-External Severity-Blocking Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19086
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?