starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash: access violation in WM_SETTINGCHANGE with lParam == 0 #19189

New Issue
Closed
opened 2026-01-31 06:36:19 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 06:36:19 +00:00
Owner
Copy Link

Originally created by @jboelter on GitHub (Jan 8, 2023).

Windows Terminal version

developer build

Windows build number

10.0.22621.963

Other Software

N/A

Steps to reproduce

Using the "Switch User" feature of Windows and ran into an issue with a WM_SETTINGCHANGE getting fired at IslandWindow.cpp with wParam == 0 and lParam == 0. This in turn crashes while constructing the string on this line:

const std::wstring param{ (wchar_t*)lparam };

21a62c5fef/src/cascadia/WindowsTerminal/IslandWindow.cpp (L661-L677)

The docs also suggest that NULL is a valid parameter for lParam.

https://learn.microsoft.com/en-us/windows/win32/winmsg/wm-settingchange

lParam

When the system sends this message as a result of a SystemParametersInfo call, lParam is a pointer to a string that indicates the area containing the system parameter that was changed. This parameter does not usually indicate which specific system parameter changed. (Note that some applications send this message with lParam set to NULL.) In general, when you receive this message, you should check and reload any system parameter settings that are used by your application.

Expected Behavior

No crash.

Actual Behavior

crash due to access violation (nullptr)

Originally created by @jboelter on GitHub (Jan 8, 2023). ### Windows Terminal version developer build ### Windows build number 10.0.22621.963 ### Other Software N/A ### Steps to reproduce Using the "Switch User" feature of Windows and ran into an issue with a `WM_SETTINGCHANGE` getting fired at `IslandWindow.cpp` with `wParam == 0` and `lParam == 0`. This in turn crashes while constructing the string on this line: ```cpp const std::wstring param{ (wchar_t*)lparam }; ``` https://github.com/microsoft/terminal/blob/21a62c5fefa36c619bd15bc80d43f54b4d878a5d/src/cascadia/WindowsTerminal/IslandWindow.cpp#L661-L677 The docs also suggest that NULL is a valid parameter for lParam. https://learn.microsoft.com/en-us/windows/win32/winmsg/wm-settingchange > lParam > > When the system sends this message as a result of a [SystemParametersInfo](https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-systemparametersinfoa) call, lParam is a pointer to a string that indicates the area containing the system parameter that was changed. This parameter does not usually indicate which specific system parameter changed. (Note that some applications send this message with lParam set to NULL.) In general, when you receive this message, you should check and reload any system parameter settings that are used by your application. ### Expected Behavior No crash. ### Actual Behavior crash due to access violation (nullptr)
claunia added the Resolution-Fix-CommittedIssue-BugProduct-TerminalArea-Windowing labels 2026-01-31 06:36:19 +00:00
claunia commented 2026-01-31 06:36:21 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14653, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14653, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19189
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?