starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.17] Dark titlebar in light theme #19259

New Issue
Closed
opened 2026-01-31 06:38:17 +00:00 by claunia · 12 comments
claunia commented 2026-01-31 06:38:17 +00:00
Owner
Copy Link

Originally created by @angelog0 on GitHub (Jan 25, 2023).

Windows Terminal version

1.17.1023

Windows build number

10.0.19045.2546

Other Software

No response

Steps to reproduce

Start WT. it shows up as in the attachment, i.e. with a black background in the window title bar

wt_start

Expected Behavior

After I click on another window app or on the Desktop it shows up as in the attachment which I would expect and prefer , i.e. with a white background in the window title bar. Notice WT does not return to look as in the first start above (black background in window title bar)

wt_after

Actual Behavior

See above.

Originally created by @angelog0 on GitHub (Jan 25, 2023). ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.19045.2546 ### Other Software _No response_ ### Steps to reproduce Start WT. it shows up as in the attachment, i.e. with a black background in the window title bar ![wt_start](https://user-images.githubusercontent.com/35931460/214687149-c091aea8-b139-4eb7-a7b7-d3164d3f4612.png) ### Expected Behavior **After** I click on another window app or on the Desktop it shows up as in the attachment which I would expect and prefer , i.e. with a **white** background in the window title bar. Notice WT does not return to look as in the first start above (black background in window title bar) ![wt_after](https://user-images.githubusercontent.com/35931460/214688234-c43a6b65-5748-4ac0-abc7-58cebd4bd36b.png) ### Actual Behavior See above.
claunia commented 2026-01-31 06:38:18 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 25, 2023):

Would you mind sharing your settings.json?

@DHowett commented on GitHub (Jan 25, 2023): Would you mind sharing your `settings.json`?
claunia commented 2026-01-31 06:38:19 +00:00
Author
Owner
Copy Link

@angelog0 commented on GitHub (Jan 25, 2023):

Now attached.

wt-settings.tar.gz

@angelog0 commented on GitHub (Jan 25, 2023): Now attached. [wt-settings.tar.gz](https://github.com/microsoft/terminal/files/10503951/wt-settings.tar.gz)
claunia commented 2026-01-31 06:38:19 +00:00
Author
Owner
Copy Link

@angelog0 commented on GitHub (Jan 25, 2023):

BTW, I had (just now uninstalled) WT-1.15 (no-preview) and it had changed my settings.json removing ALL my comments and adding some other stuff SILENTLY. Luckily I have a backup of that file... I often leave as comment old configurations and alternative to statements and references to WEB and other docs where I find suggestions etc..

@angelog0 commented on GitHub (Jan 25, 2023): BTW, I had (just now uninstalled) WT-1.15 (no-preview) and it had changed my `settings.json` removing ALL my comments and adding some other stuff SILENTLY. Luckily I have a backup of that file... I often leave as comment old configurations and alternative to statements and references to WEB and other docs where I find suggestions etc..
claunia commented 2026-01-31 06:38:19 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 25, 2023):

@angelog0 Thet's tracked in #8991

@zadjii-msft commented on GitHub (Jan 25, 2023): @angelog0 Thet's tracked in #8991
claunia commented 2026-01-31 06:38:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 25, 2023):

        {
            "name": "system2",
            "window": {
                "applicationTheme": "system"
            },
            "tab": {
                "background": "terminalBackground",
                "showCloseButton": "hover",
                "unfocusedBackground": "#00000000"
            }
        },

I'd reckon this is due to your OS being in dark theme, the Terminal being in system, and us finally obeying the app theme when it comes to the titlebar (#14536).

If you change system to light in your theme, is that more what you're looking for/?

@zadjii-msft commented on GitHub (Jan 25, 2023): ```json { "name": "system2", "window": { "applicationTheme": "system" }, "tab": { "background": "terminalBackground", "showCloseButton": "hover", "unfocusedBackground": "#00000000" } }, ``` I'd reckon this is due to your OS being in dark theme, the Terminal being in `system`, and us finally obeying the app theme when it comes to the titlebar (#14536). If you change `system` to `light` in your `theme`, is that more what you're looking for/?
claunia commented 2026-01-31 06:38:20 +00:00
Author
Owner
Copy Link

@angelog0 commented on GitHub (Jan 26, 2023):

@zadjii-msft I tried this:

{
            "name": "system2",
            "window": {
                "applicationTheme": "light"
            },
            "tab": {
                "background": "terminalBackground",
                "showCloseButton": "hover",
                "unfocusedBackground": "#00000000"
            }
        },

but it does not work: same result...

@angelog0 commented on GitHub (Jan 26, 2023): @zadjii-msft I tried this: ``` { "name": "system2", "window": { "applicationTheme": "light" }, "tab": { "background": "terminalBackground", "showCloseButton": "hover", "unfocusedBackground": "#00000000" } }, ``` but it does not work: same result...
claunia commented 2026-01-31 06:38:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 4, 2023):

10.0.19045.2546

Hmmmmmmm the API we use to change the titlebar color might not exist in Windows 10. Any chance you've got a Windows 11 machine you could test with?

@zadjii-msft commented on GitHub (Apr 4, 2023): > 10.0.19045.2546 Hmmmmmmm the API we use to change the titlebar color might not _exist_ in Windows 10. Any chance you've got a Windows 11 machine you could test with?
claunia commented 2026-01-31 06:38:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 4, 2023):

DWMWA_USE_IMMERSIVE_DARK_MODE
Use with DwmSetWindowAttribute. Allows the window frame for this window to be drawn in dark mode colors when the dark mode system setting is enabled. For compatibility reasons, all windows default to light mode regardless of the system setting. The pvAttribute parameter points to a value of type BOOL. TRUE to honor dark mode for the window, FALSE to always use light mode.

This value is supported starting with Windows 11 Build 22000.

emph. added

I think I'm gonna have to call this one by-design. I can't repro this with your theme on Win11, and it looks like that API is only officially supported on Win 11.

@zadjii-msft commented on GitHub (Apr 4, 2023): > `DWMWA_USE_IMMERSIVE_DARK_MODE` > Use with [DwmSetWindowAttribute](https://learn.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmsetwindowattribute). Allows the window frame for this window to be drawn in dark mode colors when the dark mode system setting is enabled. For compatibility reasons, all windows default to light mode regardless of the system setting. The pvAttribute parameter points to a value of type BOOL. TRUE to honor dark mode for the window, FALSE to always use light mode. > > **This value is supported starting with Windows 11 Build 22000.** _emph. added_ I think I'm gonna have to call this one by-design. I can't repro this with your theme on Win11, and it looks like that API is only officially supported on Win 11.
claunia commented 2026-01-31 06:38:21 +00:00
Author
Owner
Copy Link

@angelog0 commented on GitHub (Apr 5, 2023):

The big thinking heads at Microsoft thought that an AMD Ryzen 5 2400G with Radeon Vega Graphics is not enough to upgrade to Win11 so I still use Win10. Since this is a dual boot machine, soon I will left only GNU/Linux on it! Meanwhile I downgraded to WT 1.6 which does not seem to have the defect described in this ticket.

@angelog0 commented on GitHub (Apr 5, 2023): The big thinking **heads** at Microsoft thought that an `AMD Ryzen 5 2400G with Radeon Vega Graphics ` is not enough to upgrade to Win11 so I still use Win10. Since this is a dual boot machine, soon I will left only GNU/Linux on it! Meanwhile I _downgraded_ to WT 1.6 which does not seem to have the defect described in this ticket.
claunia commented 2026-01-31 06:38:21 +00:00
Author
Owner
Copy Link

@angelog0 commented on GitHub (Apr 5, 2023):

You mark off-topic all comments you don't like. This is an hypocrisy.

Obviously even this will be marked off-topic if not worse...

@angelog0 commented on GitHub (Apr 5, 2023): You mark off-topic all comments you don't like. This is an **hypocrisy**. Obviously even this will be marked off-topic if not worse...
claunia commented 2026-01-31 06:38:21 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 5, 2023):

Your comment about the system requirements of Windows 11 and the size of our heads IS off-topic, @angelog0. The topic of this issue is the titlebar color, and the topic of this repository is the Windows Terminal and Windows Console Host. If you want a forum in which to air your grievances about things that are not Windows Terminal, the Windows Console Host, or the titlebar color of Windows Terminal or the Windows Console Host I will gladly redirect you to Reddit.

@DHowett commented on GitHub (Apr 5, 2023): Your comment about the system requirements of Windows 11 and the size of our heads _IS_ off-topic, @angelog0. The topic of this issue is the titlebar color, and the topic of this repository is the Windows Terminal and Windows Console Host. If you want a forum in which to air your grievances about things that are not Windows Terminal, the Windows Console Host, or the titlebar color of Windows Terminal or the Windows Console Host I will gladly redirect you to [Reddit](https://old.reddit.com).
claunia commented 2026-01-31 06:38:21 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 5, 2023):

(This change you're asking about actually isn't version-specific. Your tab row is set to light theme, which suggests that your application is set to light theme. I think we should offer title bar customization alongside tab row customization probably. We found that out while triaging a later issue than this one.)

@DHowett commented on GitHub (Apr 5, 2023): (This change you're asking about actually isn't version-specific. Your tab row is set to light theme, which suggests that your application is set to light theme. I think we should offer title bar customization alongside tab row customization probably. We found that out while triaging a later issue than this one.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Issue-Bug Product-Terminal Resolution-By-Design Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?