starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

White borders are back in 1.17 #19274

New Issue
Open
opened 2026-01-31 06:38:44 +00:00 by claunia · 13 comments
claunia commented 2026-01-31 06:38:44 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jan 27, 2023).

This problem is back in v1.17, I guess due to the recent changes around theming. The grey border is there to start with until you switch to another window and back (presumably it's part of the dark theme and doesn't get repainted until switching). Once you switch back it is white and will stay so even after closing/re-opening.

Steps to reproduce:

  • Delete settings.json and state.json
  • Open Terminal and switch to light theme
  • Border is grey
  • Alt tab to another window then back again
  • Border is now forever white

Originally posted by @harristom in https://github.com/microsoft/terminal/issues/6620#issuecomment-1406570765

Originally created by @zadjii-msft on GitHub (Jan 27, 2023). > This problem is back in v1.17, I guess due to the recent changes around theming. The grey border is there to start with until you switch to another window and back (presumably it's part of the dark theme and doesn't get repainted until switching). Once you switch back it is white and will stay so even after closing/re-opening. > > Steps to reproduce: > * Delete settings.json and state.json > * Open Terminal and switch to light theme > * Border is grey > * Alt tab to another window then back again > * Border is now forever white _Originally posted by @harristom in https://github.com/microsoft/terminal/issues/6620#issuecomment-1406570765_
claunia added the Help WantedIssue-BugPriority-3Product-TerminalArea-Theming labels 2026-01-31 06:38:45 +00:00
claunia commented 2026-01-31 06:38:46 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 27, 2023):

1000% this is due to one of the last commits in #14536.

@harristom Which OS version are you on? Just to make sure I fix it for the right platform(s)

@zadjii-msft commented on GitHub (Jan 27, 2023): 1000% this is due to one of the last commits in #14536. @harristom Which OS version are you on? Just to make sure I fix it for the right platform(s)
claunia commented 2026-01-31 06:38:47 +00:00
Author
Owner
Copy Link

@harristom commented on GitHub (Jan 27, 2023):

Windows 10

@harristom commented on GitHub (Jan 27, 2023): Windows 10
claunia commented 2026-01-31 06:38:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 4, 2023):

Wait hold on, this is by design now? more or less. To try and tease this apart, I think there's two parts to this thread:

  • Part the first: The main issue here seems that when you switch to terminal light theme, the borders are white. Which is by-design now. We've got all these new toggles for different theme properties, we should probably actually respect the user's selected theme for the window. This is changed in 1.17, but seems like it changed to be more correct.
  • Part the second: "When I switch the terminal theme on Win10, the window border doesn't update till the window is unfocused/refocused", and I'm guessing that's a NCPAINT issue - we previously noted that the SetWindowAttribute thing in TerminalThemeHelpers needed to be before a NCPAINT. I'm betting that on win11, where that API is officially supported, they actually do force the NCPAINT when the API is called. On win 10, not so much.

Does all that make sense/?

@zadjii-msft commented on GitHub (Apr 4, 2023): Wait hold on, this is by design now? more or less. To try and tease this apart, I think there's two parts to this thread: * Part the first: The main issue here seems that when you switch to terminal light theme, the borders are white. Which is by-design now. We've got all these new toggles for different theme properties, we should probably actually respect the user's selected theme for the window. This is changed in 1.17, but seems like it changed to be more correct. * Part the second: "When I switch the terminal theme on Win10, the window border doesn't update till the window is unfocused/refocused", and I'm guessing that's a `NCPAINT` issue - we previously noted that the `SetWindowAttribute` thing in TerminalThemeHelpers needed to be before a `NCPAINT`. I'm betting that on win11, where that API is officially supported, they actually do force the `NCPAINT` when the API is called. On win 10, not so much. Does all that make sense/?
claunia commented 2026-01-31 06:38:47 +00:00
Author
Owner
Copy Link

@harristom commented on GitHub (Apr 7, 2023):

Is it definitely by design? As mentioned in the original report and the PR fixing it the white border makes the Terminal look out of place compared to other apps which all use a grey border. Obviously it's only a very minor issue but it makes the app look out of place and hard to tell whether it has focus (since for other apps a darker border means focussed and a lighter one means unfocussed whereas Terminal is doing the opposite).

@harristom commented on GitHub (Apr 7, 2023): Is it definitely by design? As mentioned in the [original report](https://github.com/microsoft/terminal/issues/6620) and the [PR fixing it](https://github.com/microsoft/terminal/pull/6624) the white border makes the Terminal look out of place compared to other apps which all use a grey border. Obviously it's only a very minor issue but it makes the app look out of place and hard to tell whether it has focus (since for other apps a darker border means focussed and a lighter one means unfocussed whereas Terminal is doing the opposite).
claunia commented 2026-01-31 06:38:48 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Apr 21, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Apr 21, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:38:48 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Apr 21, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Apr 21, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:38:48 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Apr 21, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Apr 21, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:38:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 21, 2023):

Sorry, the bot went haywire. As usual. I think this is worth talking about :)

@DHowett commented on GitHub (Apr 21, 2023): Sorry, the bot went haywire. As usual. I think this is worth talking about :)
claunia commented 2026-01-31 06:38:48 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Apr 26, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Apr 26, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:38:49 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Apr 26, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Apr 26, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:38:49 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Apr 26, 2023):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@microsoft-github-policy-service[bot] commented on GitHub (Apr 26, 2023): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 06:38:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 19, 2023):

Hey just found this camping in the backlog. This has kinda turned into a complex space now.

  • Before 1.17, we'd always use the dark theme border for the Terminal window, even in light mode.
    • (personally, I agree that was preferable, but that's my opinion)
  • Now in 1.17, we'll use the border color that matches the window.applicationTheme. In light mode, that means a white border.
  • BUT NOW IN 1.18: we added a pair of window.frame and window.unfocusedFrame theme properties in #15441. This will let a user override the frame color and use whatever.
    • UNFORTUNATELY, that API doesn't work on Windows 10, so this isn't necessarily immediately helpful for you, but it does work

I dunno how I feel about reverting the "the window frame follows the OS theme" bit (back to "always use the dark border"). I feel like this is more correct now, even if UWPs and Win32 apps have been using different borders for years.

@zadjii-msft commented on GitHub (Sep 19, 2023): Hey just found this camping in the backlog. This has kinda turned into a complex space now. * Before 1.17, we'd always use the dark theme border for the Terminal window, even in light mode. * (personally, I agree that was preferable, but that's my opinion) * Now in 1.17, we'll use the border color that matches the `window.applicationTheme`. In light mode, that means a white border. * BUT NOW IN 1.18: we added a pair of `window.frame` and `window.unfocusedFrame` theme properties in #15441. This will let a user override the frame color and use _whatever_. * UNFORTUNATELY, that API doesn't work on Windows 10, so this isn't necessarily immediately helpful for you, but it does _work_ I dunno how I feel about reverting the "the window frame follows the OS theme" bit (back to "always use the dark border"). I feel like this is _more correct_ now, even if UWPs and Win32 apps have been using different borders for years.
claunia commented 2026-01-31 06:38:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 2, 2023):

discussion notes:

  • Sure, we should revert this back. So that null for window.border will always use the Dark theme border
  • While we're here, if people do use window.border on Windows 10, we should try to compute the lightness and use that to figure out what theme border to use (since the real RGB color API won't work there)
@zadjii-msft commented on GitHub (Oct 2, 2023): discussion notes: * Sure, we should revert this back. So that `null` for `window.border` will always use the Dark theme border * While we're here, if people do use `window.border` on Windows 10, we should try to compute the lightness and use that to figure out what theme border to use (since the real RGB color API won't work there)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Help Wanted Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?