starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"Open in Terminal" menu option should open in PowerShell or Ubuntu depending on folder location #19278

New Issue
Open
opened 2026-01-31 06:38:54 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 06:38:54 +00:00
Owner
Copy Link

Originally created by @satvikpendem on GitHub (Jan 28, 2023).

Description of the new feature/enhancement

Not sure if this is an enhancement versus an actual bug, but if have my default WSL distro be Ubuntu, and I click "Open in Terminal" in a Windows folder, I expect it to open up the PowerShell terminal, not the Ubuntu one. Vice versa if I have the default terminal as PowerShell and I click "Open in Terminal" in an Ubuntu folder, like in the below folders.

In other words, Terminal should know the context in which I'd want each terminal to open up.

image

Proposed technical implementation details (optional)

Originally created by @satvikpendem on GitHub (Jan 28, 2023). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Not sure if this is an enhancement versus an actual bug, but if have my default WSL distro be Ubuntu, and I click "Open in Terminal" in a Windows folder, I expect it to open up the *PowerShell* terminal, not the Ubuntu one. Vice versa if I have the default terminal as PowerShell and I click "Open in Terminal" in an Ubuntu folder, like in the below folders. In other words, Terminal should know the context in which I'd want each terminal to open up. ![image](https://user-images.githubusercontent.com/42670561/215248711-7115c3e4-071a-432c-aa64-f942e98fdc10.png) <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
claunia added the Issue-FeatureHelp WantedProduct-TerminalArea-ShellExtension labels 2026-01-31 06:38:54 +00:00
claunia commented 2026-01-31 06:38:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 29, 2023):

This is a neat idea! However, I think we'd probably end up getting stuck trying to pick the "right" profile for each scenarios. E.g. what about someone with both Windows PowerShell and PowerShell 7? Or multiple WSL distros?

I think it'll be easier for us to just let folks pick the profile they want to open instead, That's tracked in /dup #6111

@zadjii-msft commented on GitHub (Jan 29, 2023): This is a neat idea! However, I think we'd probably end up getting stuck trying to pick the "right" profile for each scenarios. E.g. what about someone with both Windows PowerShell and PowerShell 7? Or multiple WSL distros? I think it'll be easier for us to just let folks pick the profile they want to open instead, That's tracked in /dup #6111
claunia commented 2026-01-31 06:38:55 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 29, 2023):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jan 29, 2023): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 06:38:55 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 30, 2023):

I actually think this is really clever and worth discussing more 😄

If the user has our stock profiles or any of the autodetected ones, we can absolutely know which distribution should be used to launch in which WSL directory.

@DHowett commented on GitHub (Jan 30, 2023): I actually think this is really clever and worth discussing more :smile: If the user has our stock profiles or any of the autodetected ones, we can absolutely know which distribution should be used to launch in which WSL directory.
claunia commented 2026-01-31 06:38:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 31, 2023):

I'm confident that us guessing means we'll guess wrong.

  • what about folks with the Canonical WSL profiles?
  • What about little old me with my Command Prompt default profile?
  • What about me with my non-built-in default profile?
  • What if I have a WSL set as the default, and I do want to open WSL navigated to %USERPROFILE%, so I can do sane bash scripting on my Windows files?
@zadjii-msft commented on GitHub (Jan 31, 2023): I'm confident that us guessing means we'll guess wrong. * what about folks with the Canonical WSL profiles? * What about little old me with my Command Prompt default profile? * What about me with my non-built-in default profile? * What if I have a WSL set as the default, and I _do_ want to open WSL navigated to %USERPROFILE%, so I can do ~sane~ bash scripting on my Windows files?
claunia commented 2026-01-31 06:38:55 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 31, 2023):

Bullet point 4 is a bit beside the point - the shell extension changes the startingDirectory somewhat by design. 😄

For the rest: guessing wrong is low cost and I would posit rare. I guess the question is...

Is it more delightful for us to launch \\wsl\Debian\ paths into Debian under WSL automatically (before we have profile selection!) than it is annoying for us to not launch your default profile?

@DHowett commented on GitHub (Jan 31, 2023): Bullet point 4 is a bit beside the point - the shell extension changes the `startingDirectory` somewhat _by design._ :smile: For the rest: guessing wrong is low cost and I would posit rare. I guess the question is... Is it more delightful for us to launch `\\wsl\Debian\` paths into Debian under WSL automatically (before we have profile selection!) than it is annoying for us to not launch your default profile?
claunia commented 2026-01-31 06:38:56 +00:00
Author
Owner
Copy Link

@satvikpendem commented on GitHub (Feb 1, 2023):

I also suspect most users have the default PowerShell 7 and one WSL profile, so guessing correctly for most users would probably be accurate.

@satvikpendem commented on GitHub (Feb 1, 2023): I also suspect most users have the default PowerShell 7 and one WSL profile, so guessing correctly for most users would probably be accurate.
claunia commented 2026-01-31 06:38:56 +00:00
Author
Owner
Copy Link

@OldStarchy commented on GitHub (May 2, 2024):

Even if the guess is the wrong version of powershell (assuming you have more than one version installed) it would still at least give you a terminal in the correct directory. Currently the "Open in Terminal" option is 100% useless to me because it opens in WSL so I still have to go through roughly the same steps to open another terminal with powershell and navigate to the correct directory.

Opening the wrong powershell can more easily fixed by just manually running the correct pwsh command.

@OldStarchy commented on GitHub (May 2, 2024): Even if the guess is the wrong version of powershell (assuming you have more than one version installed) it would still at least give you a terminal in the correct directory. Currently the "Open in Terminal" option is 100% useless to me because it opens in WSL so I still have to go through roughly the same steps to open another terminal with powershell and navigate to the correct directory. Opening the wrong powershell can more easily fixed by just manually running the correct pwsh command.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-ShellExtension Help Wanted Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?