starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Line height appears off in WT #19299

New Issue
Closed
opened 2026-01-31 06:39:22 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 06:39:22 +00:00
Owner
Copy Link

Originally created by @igniscyan on GitHub (Feb 1, 2023).

Windows Terminal version

1.17.1023

Windows build number

10.0.22000.1455

Other Software

nvim 0.9.0 dev build

Steps to reproduce

Use the mononoki font, set font size to 10.

Expected Behavior

Sane default for line height (or a front facing option like in VSCode to automatically calculate line height) on the font

Actual Behavior

Line spacing is way too close on certain fonts. Mononoki is a great example, but I've found this issue on several I've tested.

image

This image shows the same font and same font size. Right is in VScode, left is in Windows terminal. The font is rendered useless in the latter.

Originally created by @igniscyan on GitHub (Feb 1, 2023). ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.22000.1455 ### Other Software nvim 0.9.0 dev build ### Steps to reproduce Use the mononoki font, set font size to 10. ### Expected Behavior Sane default for line height (or a front facing option like in VSCode to automatically calculate line height) on the font ### Actual Behavior Line spacing is _way_ too close on certain fonts. Mononoki is a great example, but I've found this issue on several I've tested. ![image](https://user-images.githubusercontent.com/26984470/216010244-d3c832d0-cf5d-462c-8446-771309e0b30e.png) This image shows the same font and same font size. Right is in VScode, left is in Windows terminal. The font is rendered useless in the latter.
claunia added the Needs-TriageIssue-BugNeeds-Attention labels 2026-01-31 06:39:22 +00:00
claunia commented 2026-01-31 06:39:24 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Feb 1, 2023):

The font file specifies a line height of 1.2 which we respect:
image

VS Code on the other hand ignores the font's line height and uses 1.35 by default. Here's the relevant code: 0291e43350/src/vs/editor/common/config/fontInfo.ts (L14)

As such I'd expect a line height difference of +12.5% in your screenshot, but yours shows a difference of 40%:
image

In fact, I can't reproduce such a big difference in line heights either:
image

Can you please check the following?

  • Did you perhaps override the line height in VS Code?
  • Is your mononoki font up to date? It got an update just a few months ago.
  • It's unlikely, but are you certain you're using the exact same font variant and font size in both applications?
@lhecker commented on GitHub (Feb 1, 2023): The font file specifies a line height of 1.2 which we respect: ![image](https://user-images.githubusercontent.com/2256941/216088099-603bb917-0d07-40c5-8d3f-ce27d5c924ef.png) VS Code on the other hand ignores the font's line height and uses 1.35 by default. Here's the relevant code: https://github.com/microsoft/vscode/blob/0291e43350e922a7b6cdb0227f9dd01e6e7cb8e2/src/vs/editor/common/config/fontInfo.ts#L14 As such I'd expect a line height difference of +12.5% in your screenshot, but yours shows a difference of 40%: ![image](https://user-images.githubusercontent.com/2256941/216091249-db336331-ee53-4bcf-a1d3-6fe08e21e745.png) In fact, I can't reproduce such a big difference in line heights either: ![image](https://user-images.githubusercontent.com/2256941/216089798-80cfd003-dd9e-4cb7-a08b-6fc3abb1a8be.png) Can you please check the following? * Did you perhaps override the line height in VS Code? * Is your mononoki font up to date? It got an update just a few months ago. * It's unlikely, but are you certain you're using the exact same font variant and font size in both applications?
claunia commented 2026-01-31 06:39:24 +00:00
Author
Owner
Copy Link

@igniscyan commented on GitHub (Feb 2, 2023):

@lhecker Embarrassingly, a reinstall seems to have solved the issue completely. Apologies for the redundant issue!

@igniscyan commented on GitHub (Feb 2, 2023): @lhecker Embarrassingly, a reinstall seems to have solved the issue completely. Apologies for the redundant issue!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Attention Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19299
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?