starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

start wt.exe with parameter fails in administrator mode #19398

New Issue
Open
opened 2026-01-31 06:42:07 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 06:42:07 +00:00
Owner
Copy Link

Originally created by @Matzeeee on GitHub (Feb 16, 2023).

Windows Terminal version

1.16.230126001

Windows build number

10.0.19045.2604

Other Software

No response

Steps to reproduce

Open cmd.exe and type "wt ping google.de".
image

Expected Behavior

Open wt with cmd.exe and execute "ping google.de".
image

Actual Behavior

If wt runs with option "run profile as administrator" cmd.exe opens but parameter (ping google.de) is not executed.
image
image

Originally created by @Matzeeee on GitHub (Feb 16, 2023). ### Windows Terminal version 1.16.230126001 ### Windows build number 10.0.19045.2604 ### Other Software _No response_ ### Steps to reproduce Open cmd.exe and type "wt ping google.de". ![image](https://user-images.githubusercontent.com/60921150/219412574-59faacd7-8d11-4719-b67a-745dd5b86725.png) ### Expected Behavior Open wt with cmd.exe and execute "ping google.de". ![image](https://user-images.githubusercontent.com/60921150/219412701-c62d890d-8f60-4792-9978-55e5ff769fda.png) ### Actual Behavior If wt runs with option "run profile as administrator" cmd.exe opens but parameter (ping google.de) is not executed. ![image](https://user-images.githubusercontent.com/60921150/219412885-2de783c8-3836-4ce9-b26a-aab5addb34e6.png) ![image](https://user-images.githubusercontent.com/60921150/219412971-57fd8b57-0a2d-41b0-878a-bf13e701369d.png)
claunia added the Help WantedIssue-BugProduct-TerminalPriority-2Area-Commandline labels 2026-01-31 06:42:08 +00:00
claunia commented 2026-01-31 06:42:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 16, 2023):

Welp. Okay that's wacky, unexpected, and tricky to resolve.

  • Your profiles default is set to elevate:true (profiles.defaults, not just the profile that is your default).
  • When you do wt ping 8.8.8.8, the Terminal opens, and tries to run with all your profiles.default profile's settings, except with the commandline explicitly set to pint 8.8.8.8.
  • After evaluating the settings, Terminal determines this new tab should be run elevated (in accordance with your settings) and then ShellExectute's itself, passing in the profile it should use to spawn the new tab.
    • In this step, it does NOT pass that overwritten commandline along
  • The elevated terminal spawns, and just uses the default commandline for the profile it was told (which was just profiles.defaults)

This one's tricky. We basically need to pick something sensible to happen here. The argument could probably go either way:

  • Should the terminal open elevated, running ping 8.8.8.8?
  • Or should it open unelevated?

I'd lean towards the second. Does that make sense to you @Matzeeee?

In that case, we'd want to modify ShouldImmediatelyHandoffToElevated / _maybeElevate in TerminalPage to ensure that the commandline is the same as the profile, before we decide to just elevate.

@zadjii-msft commented on GitHub (Feb 16, 2023): Welp. Okay that's wacky, unexpected, and tricky to resolve. * Your profiles default is set to `elevate:true` (`profiles.defaults`, not just the profile that is your default). * When you do `wt ping 8.8.8.8`, the Terminal opens, and tries to run with all your `profiles.default` profile's settings, except with the commandline explicitly set to `pint 8.8.8.8`. * After evaluating the settings, Terminal determines this new tab should be run elevated (in accordance with your settings) and then ShellExectute's itself, passing in the profile it should use to spawn the new tab. * In this step, it does NOT pass that overwritten commandline along * The elevated terminal spawns, and just uses the default commandline for the profile it was told (which was just profiles.defaults) This one's tricky. We basically need to pick something sensible to happen here. The argument could probably go either way: * Should the terminal open elevated, running `ping 8.8.8.8`? * Or should it open unelevated? I'd lean towards the second. Does that make sense to you @Matzeeee? <hr> In that case, we'd want to modify `ShouldImmediatelyHandoffToElevated` / `_maybeElevate` in `TerminalPage` to ensure that the commandline is the same as the profile, before we decide to just elevate.
claunia commented 2026-01-31 06:42:09 +00:00
Author
Owner
Copy Link

@Matzeeee commented on GitHub (Feb 16, 2023):

This one's tricky. We basically need to pick something sensible to happen here. The argument could probably go either way:

  • Should the terminal open elevated, running ping 8.8.8.8?
  • Or should it open unelevated?

I'd lean towards the second. Does that make sense to you @Matzeeee?

In that case, we'd want to modify ShouldImmediatelyHandoffToElevated / _maybeElevate in TerminalPage to ensure that the commandline is the same as the profile, before we decide to just elevate.

I expected the terminal to start elevated and then execute the command.

@Matzeeee commented on GitHub (Feb 16, 2023): > This one's tricky. We basically need to pick something sensible to happen here. The argument could probably go either way: > > * Should the terminal open elevated, running `ping 8.8.8.8`? > * Or should it open unelevated? > > I'd lean towards the second. Does that make sense to you @Matzeeee? > > In that case, we'd want to modify `ShouldImmediatelyHandoffToElevated` / `_maybeElevate` in `TerminalPage` to ensure that the commandline is the same as the profile, before we decide to just elevate. I expected the terminal to start elevated and then execute the command.
claunia commented 2026-01-31 06:42:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 5, 2023):

You know, we might be able to something like #15286 for this. Pre-evaluate the actual commandline, given the NewTerminalArgs, and pass that in to elevate-shim.

I'd worry about escaping that commandline though. That'd be scary.

@zadjii-msft commented on GitHub (May 5, 2023): You know, we might be able to something like #15286 for this. Pre-evaluate the actual commandline, given the NewTerminalArgs, and pass that in to elevate-shim. I'd worry about escaping that commandline though. That'd be scary.
claunia commented 2026-01-31 06:42:09 +00:00
Author
Owner
Copy Link

@Matzeeee commented on GitHub (Dec 16, 2024):

will this ever be fixed?

@Matzeeee commented on GitHub (Dec 16, 2024): will this ever be fixed?
claunia commented 2026-01-31 06:42:10 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Dec 17, 2024):

It seems it partially was fixed: wt pwsh now properly spawns PowerShell in an elevated tab. However, it seems something's wrong with parameter escaping, as mentioned above, because the entire commandline given to wt is passed as a "single argument string" that is interpreted as a command line path with spaces. Example:

Image

I'll keep this tab open and look into it after the holidays.

@lhecker commented on GitHub (Dec 17, 2024): It seems it partially was fixed: `wt pwsh` now properly spawns PowerShell in an elevated tab. However, it seems something's wrong with parameter escaping, as mentioned above, because the entire commandline given to `wt` is passed as a `"single argument string"` that is interpreted as a command line path with spaces. Example: ![Image](https://github.com/user-attachments/assets/46e90269-03e0-4400-9b28-579e16b1f77c) I'll keep this tab open and look into it after the holidays.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Commandline Help Wanted Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?