starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Windows Terminal crashes when changing the system dark/light mode #19399

New Issue
Closed
opened 2026-01-31 06:42:09 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 06:42:09 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Feb 16, 2023).

Windows Terminal version

1.17.1023

Windows build number

10.0.19044.2364

Other Software

No response

Steps to reproduce

  1. Start Windows Terminal
  2. Open the Settings UI
  3. Navigate to the Appearance tab
  4. Set the Theme to "Use Windows theme" and Save
  5. Leave the Settings UI open
  6. Open the Windows settings app
  7. Navigate to the Personalization > Colors section
  8. Switch the color scheme from Dark to Light (or vice versa)

Expected Behavior

Windows Terminal should update to match the system color scheme.

Actual Behavior

Windows Terminal crashes.

When running from within the VS debugger, I get an exception like this:

Unhandled exception at 0x00007FFBBDCEFE32 (KernelBase.dll) in WindowsTerminal.exe: 0xC000027B: An application-internal exception has occurred (parameters: 0x0000024A0FCC6090, 0x000000000000000C).

And a stack trace like this:

>	KernelBase.dll!RaiseFailFastException()	Unknown
 	combase.dll!RoFailFastWithErrorContextInternal2(HRESULT hrError, unsigned long cStowedExceptions, _STOWED_EXCEPTION_INFORMATION_V2 * * aStowedExceptionPointers) Line 1455	C++
 	Windows.UI.Xaml.dll!DirectUI::ErrorHelper::ProcessUnhandledError(DirectUI::ErrorInfo & errorInfo, unsigned int fSkipFailFastIfNoErrorContext, unsigned int * pfHandled) Line 616	C++
 	Windows.UI.Xaml.dll!DirectUI::ErrorHelper::ReportUnhandledError(HRESULT hrError) Line 502	C++
 	Windows.UI.Xaml.dll!CXcpDispatcher::Tick() Line 1455	C++
 	Windows.UI.Xaml.dll!CXcpDispatcher::OnReentrancyProtectedWindowMessage(HWND__ * msg, unsigned int lParam, unsigned __int64) Line 1041	C++
 	[Inline Frame] Windows.UI.Xaml.dll!CXcpDispatcher::ProcessMessage(HWND__ *) Line 890	C++
 	Windows.UI.Xaml.dll!CXcpDispatcher::WindowProc(HWND__ * hwnd, unsigned int msg, unsigned __int64 wParam, __int64 lParam) Line 839	C++
 	Windows.UI.Xaml.dll!CDeferredInvoke::DispatchQueuedMessage(bool * dispatchedWork, bool * hasMoreWork) Line 301	C++
 	[Inline Frame] Windows.UI.Xaml.dll!CXcpDispatcher::MessageTimerCallback() Line 1534	C++
 	Windows.UI.Xaml.dll!CXcpDispatcher::MessageTimerCallbackStatic(void * myUserData) Line 1526	C++
 	CoreMessaging.dll!Microsoft__CoreUI__Dispatch__TimeoutHandler$CallbackThunk(class System::Delegate *)	Unknown
 	CoreMessaging.dll!Microsoft::CoreUI::Dispatch::TimeoutManager::Callback_OnDispatch()	Unknown
 	CoreMessaging.dll!Microsoft::CoreUI::Dispatch::EventLoop::Callback_RunCoreLoop(struct Microsoft::CoreUI::Dispatch::RunMode,bool,bool &)	Unknown
 	CoreMessaging.dll!Microsoft::CoreUI::Dispatch::UserAdapter::OnUserDispatch()	Unknown
 	CoreMessaging.dll!Microsoft::CoreUI::Dispatch::UserAdapter_DoWork()	Unknown
 	CoreMessaging.dll!Microsoft::CoreUI::Dispatch::UserAdapter_WindowProc(struct HWND__ *,unsigned int,unsigned __int64,__int64)	Unknown
 	user32.dll!UserCallWinProcCheckWow()	Unknown
 	user32.dll!DispatchClientMessage()	Unknown
 	user32.dll!__fnDWORD()	Unknown
 	ntdll.dll!KiUserCallbackDispatcherContinue()	Unknown
 	win32u.dll!NtUserGetMessage()	Unknown
 	user32.dll!GetMessageW()	Unknown
 	WindowsTerminal.exe!wWinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, wchar_t * __formal, int __formal) Line 149	C++
 	[External Code]
Originally created by @j4james on GitHub (Feb 16, 2023). ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.19044.2364 ### Other Software _No response_ ### Steps to reproduce 1. Start Windows Terminal 2. Open the Settings UI 3. Navigate to the _Appearance_ tab 4. Set the _Theme_ to "Use Windows theme" and Save 5. Leave the Settings UI open 6. Open the Windows settings app 7. Navigate to the _Personalization_ > _Colors_ section 8. Switch the color scheme from _Dark_ to _Light_ (or vice versa) ### Expected Behavior Windows Terminal should update to match the system color scheme. ### Actual Behavior Windows Terminal crashes. When running from within the VS debugger, I get an exception like this: > Unhandled exception at 0x00007FFBBDCEFE32 (KernelBase.dll) in WindowsTerminal.exe: 0xC000027B: An application-internal exception has occurred (parameters: 0x0000024A0FCC6090, 0x000000000000000C). And a stack trace like this: ``` > KernelBase.dll!RaiseFailFastException() Unknown combase.dll!RoFailFastWithErrorContextInternal2(HRESULT hrError, unsigned long cStowedExceptions, _STOWED_EXCEPTION_INFORMATION_V2 * * aStowedExceptionPointers) Line 1455 C++ Windows.UI.Xaml.dll!DirectUI::ErrorHelper::ProcessUnhandledError(DirectUI::ErrorInfo & errorInfo, unsigned int fSkipFailFastIfNoErrorContext, unsigned int * pfHandled) Line 616 C++ Windows.UI.Xaml.dll!DirectUI::ErrorHelper::ReportUnhandledError(HRESULT hrError) Line 502 C++ Windows.UI.Xaml.dll!CXcpDispatcher::Tick() Line 1455 C++ Windows.UI.Xaml.dll!CXcpDispatcher::OnReentrancyProtectedWindowMessage(HWND__ * msg, unsigned int lParam, unsigned __int64) Line 1041 C++ [Inline Frame] Windows.UI.Xaml.dll!CXcpDispatcher::ProcessMessage(HWND__ *) Line 890 C++ Windows.UI.Xaml.dll!CXcpDispatcher::WindowProc(HWND__ * hwnd, unsigned int msg, unsigned __int64 wParam, __int64 lParam) Line 839 C++ Windows.UI.Xaml.dll!CDeferredInvoke::DispatchQueuedMessage(bool * dispatchedWork, bool * hasMoreWork) Line 301 C++ [Inline Frame] Windows.UI.Xaml.dll!CXcpDispatcher::MessageTimerCallback() Line 1534 C++ Windows.UI.Xaml.dll!CXcpDispatcher::MessageTimerCallbackStatic(void * myUserData) Line 1526 C++ CoreMessaging.dll!Microsoft__CoreUI__Dispatch__TimeoutHandler$CallbackThunk(class System::Delegate *) Unknown CoreMessaging.dll!Microsoft::CoreUI::Dispatch::TimeoutManager::Callback_OnDispatch() Unknown CoreMessaging.dll!Microsoft::CoreUI::Dispatch::EventLoop::Callback_RunCoreLoop(struct Microsoft::CoreUI::Dispatch::RunMode,bool,bool &) Unknown CoreMessaging.dll!Microsoft::CoreUI::Dispatch::UserAdapter::OnUserDispatch() Unknown CoreMessaging.dll!Microsoft::CoreUI::Dispatch::UserAdapter_DoWork() Unknown CoreMessaging.dll!Microsoft::CoreUI::Dispatch::UserAdapter_WindowProc(struct HWND__ *,unsigned int,unsigned __int64,__int64) Unknown user32.dll!UserCallWinProcCheckWow() Unknown user32.dll!DispatchClientMessage() Unknown user32.dll!__fnDWORD() Unknown ntdll.dll!KiUserCallbackDispatcherContinue() Unknown win32u.dll!NtUserGetMessage() Unknown user32.dll!GetMessageW() Unknown WindowsTerminal.exe!wWinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, wchar_t * __formal, int __formal) Line 149 C++ [External Code] ```
claunia commented 2026-01-31 06:42:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 5, 2023):

Hmmmmmmmmm I can't seem to repro this on main, nor can I on 1.18.833 (which predated the MUX 2.8 changes). Maybe this was a win10-specific bug?

@zadjii-msft commented on GitHub (Apr 5, 2023): Hmmmmmmmmm I can't seem to repro this on `main`, nor can I on 1.18.833 (which predated the MUX 2.8 changes). Maybe this was a win10-specific bug?
claunia commented 2026-01-31 06:42:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 5, 2023):

Woah okay yea, on win10, it did blast off into space crash. That's wild!

Other observations:

  • If I don't have the SUI open, we don't crash, but we also don't update the titlebar color. And things that seemingly should update the RequestedTheme (opening tabs, opening About) don't seem to. That's weird.
  • If the SUI is open, even on the main page, then the terminal crashes.
  • Interesting, switching the OS theme another time did cause the Terminal to hang. Loading dump now...
    • Huh, in this stack, the Terminal is hung trying to talk to the monarch to look to see if there's a quake window.
    • Well, that hang I don't think we need to worry about anymore. The monarch hung trying to delete a peasant that died, during the setting update, and then somehow... called back into itself? But we're not doing that in 1.18 anymore.
  • asdf

The fact that this is something that can be fixed by an OS update is... troubling...

@zadjii-msft commented on GitHub (Apr 5, 2023): Woah okay yea, on win10, it did ~blast off into space~ crash. That's wild! Other observations: * ~If I don't have the SUI open, we don't crash, but we also _don't update the titlebar color_. And things that seemingly _should_ update the RequestedTheme (opening tabs, opening About) don't seem to. That's weird.~ * If the SUI is open, even on the main page, then the terminal crashes. * Interesting, switching the OS theme another time did cause the Terminal to hang. Loading dump now... * Huh, in this stack, the Terminal is hung trying to talk to the monarch to look to see if there's a quake window. * Well, that hang I don't think we need to worry about anymore. The monarch hung trying to delete a peasant that died, during the setting update, and then somehow... called back into itself? But we're not doing that in 1.18 anymore. * asdf The fact that this is something that can be fixed by an OS update is... troubling...
claunia commented 2026-01-31 06:42:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 5, 2023):

BOY I don't know exactly how or why, but this is fixed in 1.18, even on windows 10. Just installing 1.18.833 on 19044 works like a charm. Probably due to restructuring how we determine if there's a quake window. I know that sounds insane.

@zadjii-msft commented on GitHub (Apr 5, 2023): BOY I don't know exactly how or why, but this is fixed in 1.18, even on windows 10. Just installing 1.18.833 on 19044 works like a charm. Probably due to restructuring how we determine if there's a quake window. I know that sounds insane.
claunia commented 2026-01-31 06:42:12 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Apr 5, 2023):

Can confirm that it's working for me now in the dev build. Thanks.

@j4james commented on GitHub (Apr 5, 2023): Can confirm that it's working for me now in the dev build. Thanks.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Issue-Bug Needs-Tag-Fix Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19399
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?