starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Rendering suggestions and some questions!!! #19427

New Issue
Closed
opened 2026-01-31 06:42:57 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 06:42:57 +00:00
Owner
Copy Link

Originally created by @xiaoyxue on GitHub (Feb 21, 2023).

Add the FPS enable/disable button, remove the "Using software rendering"

  1. About "Using software rendering", software rendering only cost the CPU performance, if a low-level CPU, this options totally reduce the computer's performance, if a high-level CPU whose GPU or standalone GPU totally can hold the rendering cost. So, I think this option is unnecessary.
  2. Add the FPS display which can help if need the "Redraw entire screen when display updates", and another question: here the entire "screen" is the terminal window or the whole display monitor screen? From my understanding, it should mean the editor space in the window.
  3. I want to how do you implement the cursor blinking in fixed frequency? Swap the frame and force vertical synchronization? Since this is related to point 2. Does the cursor blinking belong to the "display updates"? I just guess that when only cursor blinking, fix a low frequency, when texts are being written, fix a high frequency and if keyboard is active, no frame swapping happen. Is my guess correct?
  4. The same as #14888, he is totally correct

Proposed technical implementation details (optional)

Just add an FPS button

A clear and concise description of what you want to happen.

Just want to see the FPS and answer my questions, thanks!

Originally created by @xiaoyxue on GitHub (Feb 21, 2023). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Add the FPS enable/disable button, remove the "Using software rendering" 1. About "Using software rendering", software rendering only cost the CPU performance, if a low-level CPU, this options totally reduce the computer's performance, if a high-level CPU whose GPU or standalone GPU totally can hold the rendering cost. So, I think this option is unnecessary. 2. Add the FPS display which can help if need the "Redraw entire screen when display updates", and another question: here the entire "screen" is the terminal window or the whole display monitor screen? From my understanding, it should mean the editor space in the window. 3. I want to how do you implement the cursor blinking in fixed frequency? Swap the frame and force vertical synchronization? Since this is related to ***point 2***. Does the cursor blinking belong to the "display updates"? I just guess that when only cursor blinking, fix a low frequency, when texts are being written, fix a high frequency and if keyboard is active, no frame swapping happen. Is my guess correct? 4. The same as #14888, he is totally correct # Proposed technical implementation details (optional) Just add an FPS button ## A clear and concise description of what you want to happen. Just want to see the FPS and answer my questions, thanks!
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-31 06:42:57 +00:00
claunia commented 2026-01-31 06:42:58 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Feb 21, 2023):

  1. The software rendering option is a debugging aid and workaround for hardware issues and display driver bugs (see the comments in commit d01317c9db).
  2. There's already an issue for this (see #6025).
  3. As I understand it, cursor blinking is typically treated like any other screen update. The cursor cell is added to the set of screen coordinates that need refreshing, and it'll then be rendered on the next frame update. It might be more complicated in the new Atlas render engine though. But if you have further questions like this, the Discussions area is the best place to ask.
  4. If you want to indicate your support for an existing feature request, I'd recommend clicking on the 👍 button on that issue.
@j4james commented on GitHub (Feb 21, 2023): 1. The software rendering option is a debugging aid and workaround for hardware issues and display driver bugs (see the comments in commit d01317c9db7bdf43713d1641f13ab4b795bdb26b). 2. There's already an issue for this (see #6025). 3. As I understand it, cursor blinking is typically treated like any other screen update. The cursor cell is added to the set of screen coordinates that need refreshing, and it'll then be rendered on the next frame update. It might be more complicated in the new Atlas render engine though. But if you have further questions like this, the [Discussions](https://github.com/microsoft/terminal/discussions) area is the best place to ask. 4. If you want to indicate your support for an existing feature request, I'd recommend clicking on the 👍 button on that issue.
claunia commented 2026-01-31 06:42:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 21, 2023):

Thanks for always doing my job for me @j4james 😝 I'm not sure I've got anything else to add here. I'll mark this conversation as /dup #6025 for tracking purposes, but otherwise I'd move this to a Discussion. Thanks!

@zadjii-msft commented on GitHub (Feb 21, 2023): Thanks for always doing my job for me @j4james 😝 I'm not sure I've got anything else to add here. I'll mark this conversation as /dup #6025 for tracking purposes, but otherwise I'd move this to a Discussion. Thanks!
claunia commented 2026-01-31 06:42:58 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Feb 21, 2023):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (Feb 21, 2023): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 06:42:58 +00:00
Author
Owner
Copy Link

@microsoft-github-policy-service[bot] commented on GitHub (Feb 21, 2023):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service[bot] commented on GitHub (Feb 21, 2023): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19427
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?