Terminal hangs when exiting a debug tap session #19445

Closed
opened 2026-01-31 06:43:31 +00:00 by claunia · 3 comments
Owner

Originally created by @j4james on GitHub (Feb 23, 2023).

Windows Terminal version

1.17.1023

Windows build number

10.0.19044.2364

Other Software

No response

Steps to reproduce

  1. Make sure the debugFeatures option is enabled in the settings.
  2. Open a bash shell with a debug tab.
  3. Exit the shell with exit.

Expected Behavior

You should be left with the debug tab pane which you can then close.

Actual Behavior

The terminal hangs.

Running from within the debugger, the main thread appears to be blocked on the _createCloseLock in _ControlConnectionStateChangedHandler, but there didn't appear to be any other threads holding that lock. I didn't spend that much time investigating, though, so it's quite likely I missed something.

Originally created by @j4james on GitHub (Feb 23, 2023). ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.19044.2364 ### Other Software _No response_ ### Steps to reproduce 1. Make sure the `debugFeatures` option is enabled in the settings. 2. Open a bash shell with a debug tab. 3. Exit the shell with `exit`. ### Expected Behavior You should be left with the debug tab pane which you can then close. ### Actual Behavior The terminal hangs. Running from within the debugger, the main thread appears to be blocked on the `_createCloseLock` in `_ControlConnectionStateChangedHandler`, but there didn't appear to be any other threads holding that lock. I didn't spend that much time investigating, though, so it's quite likely I missed something.
Author
Owner

@DHowett commented on GitHub (Apr 5, 2023):

Promoted to P1, marked Sev-Crash (though it's a hang). 😄

@DHowett commented on GitHub (Apr 5, 2023): Promoted to P1, marked Sev-Crash (though it's a hang). :smile:
Author
Owner

@zadjii-msft commented on GitHub (Apr 5, 2023):

idly: I wonder if #14548 helps / hurts

@zadjii-msft commented on GitHub (Apr 5, 2023): idly: I wonder if #14548 helps / hurts
Author
Owner

@zadjii-msft commented on GitHub (Sep 19, 2023):

You know, I bet this was fixed by #15335. I can't repro this anymore, and the _createCloseLock was removed.

@zadjii-msft commented on GitHub (Sep 19, 2023): You know, I bet this was fixed by #15335. I can't repro this anymore, and the `_createCloseLock` was removed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19445