Windows Terminal can display brown but cant configure it in the settings json ? #19472

@237dmitry commented on GitHub (Feb 28, 2023):

i know its invalid

Why are you trying to define this property if you know that its name ( brown ) is invalid? And even if you write it in the configuration file, it will simply be ignored, and then, when the file is overwritten, this property will be deleted.

@237dmitry commented on GitHub (Feb 28, 2023): > i know its invalid Why are you trying to define this property if you know that its name ( `brown` ) is invalid? And even if you write it in the configuration file, it will simply be ignored, and then, when the file is overwritten, this property will be deleted.

claunia commented

@j4james commented on GitHub (Feb 28, 2023):

@Biakiss That's just the way terminals work. There are 16 customizable colors which applications can use if they want their output to match the user's preferred terminal color scheme. However, they can also choose to use explicit RGB values if they want to control the exact look of the application output.

If you don't like the application's choice of colors, you should take that up with the application authors. Although in this particular case, if you're using vim, I believe they already have theme configuration options which should allow you to set the colors exactly how you want them.

@j4james commented on GitHub (Feb 28, 2023): @Biakiss That's just the way terminals work. There are 16 customizable colors which applications can use if they want their output to match the user's preferred terminal color scheme. However, they can also choose to use explicit RGB values if they want to control the exact look of the application output. If you don't like the application's choice of colors, you should take that up with the application authors. Although in this particular case, if you're using vim, I believe they already have theme configuration options which should allow you to set the colors exactly how you want them.

claunia commented

@zadjii-msft commented on GitHub (Feb 28, 2023):

Yep, j4james hit it on the nose. However your vim colorscheme is defined, it's specifying that "brown" color manually. It's using either a 256-color value or straight up a rgb color, rather than relying on one of the 16 colors of the palette. I'd start by inspecting that vim color scheme, or trying a different one.

@zadjii-msft commented on GitHub (Feb 28, 2023): Yep, j4james hit it on the nose. However your `vim` colorscheme is defined, it's specifying that "brown" color manually. It's using either a 256-color value or straight up a rgb color, rather than relying on one of the 16 colors of the palette. I'd start by inspecting that vim color scheme, or trying a different one.

claunia commented

@ghost commented on GitHub (Feb 28, 2023):

@Biakiss That's just the way terminals work. There are 16 customizable colors which applications can use if they want their output to match the user's preferred terminal color scheme. However, they can also choose to use explicit RGB values if they want to control the exact look of the application output.

If you don't like the application's choice of colors, you should take that up with the application authors. Although in this particular case, if you're using vim, I believe they already have theme configuration options which should allow you to set the colors exactly how you want them.

Its not like i dont like the application colors i dont like that widows terminal doesnt give me the ability to customize them.

The solution here is simple if i set the background to dark the brown will turn to yellow and i can change the color of settings json.

My question is why does the terminal render a color and then it doesnt give an ability to give it a different hex value.

And this is why the issue is with the terminal itself and not vim.

@ghost commented on GitHub (Feb 28, 2023): > @Biakiss That's just the way terminals work. There are 16 customizable colors which applications can use if they want their output to match the user's preferred terminal color scheme. However, they can also choose to use explicit RGB values if they want to control the exact look of the application output. > > If you don't like the application's choice of colors, you should take that up with the application authors. Although in this particular case, if you're using vim, I believe they already have theme configuration options which should allow you to set the colors exactly how you want them. Its not like i dont like the application colors i dont like that widows terminal doesnt give me the ability to customize them. The solution here is simple if i set the background to dark the brown will turn to yellow and i can change the color of settings json. My question is why does the terminal render a color and then it doesnt give an ability to give it a different hex value. And this is why the issue is with the terminal itself and not vim.

claunia commented

@zadjii-msft commented on GitHub (Feb 28, 2023):

The solution here is simple if i set the background to dark the brown will turn to yellow and i can change the color of settings json

wait, what?

Can you just share your complete settings.json and whatever vim config you're using?

Colors in CLI applications are a little weird. Either an app can say

"I want one of the 16 colors of the color table¹"
"I want one of the 256 predefined colors"
"I want an RGB color"

Terminal can't change the second two sets of colors. However, the colorScheme in the Terminal controls the appearance of those first 16 colors. Those colors have "names" (brightRed, blue, cyan, etc), but it doesn't matter what the values of those colors are. An app can say "I want red" but you've set your scheme to Batman, and the app will get #e6dc44.

Our assertion that the vim scheme is using one of the 256 colors or an RGB color is due to the fact that the apparent "brown" color doesn't appear in your color scheme anywhere. So vim can't be requesting on of colors 0-16 to get that color.

<aside> perhaps the vim scheme is using the dim attribute?

There's also the background and foreground default colors available to CLI apps, but it's usually easiest to just refer to the 16-color table. ↩︎

@zadjii-msft commented on GitHub (Feb 28, 2023): > The solution here is simple if i set the background to dark the brown will turn to yellow and i can change the color of settings json wait, what? Can you just share your complete settings.json and whatever vim config you're using? <hr> Colors in CLI applications are a little weird. Either an app can say * "I want one of the 16 colors of the color table[^1]" * "I want one of the 256 predefined colors" * "I want an RGB color" Terminal can't change the second two sets of colors. However, the colorScheme in the Terminal controls the appearance of those first 16 colors. Those colors have "names" (brightRed, blue, cyan, etc), but it doesn't matter what the values of those colors are. An app can say "I want _red_" but you've set your scheme to [Batman](https://github.com/mbadolato/iTerm2-Color-Schemes#batman), and the app will get `#e6dc44`. Our assertion that the vim scheme is using one of the 256 colors or an RGB color is due to the fact that the apparent "brown" color _doesn't appear in your color scheme anywhere_. So vim can't be requesting on of colors 0-16 to get that color. \<aside> perhaps the vim scheme is using the dim attribute? [^1]: There's also the `background` and `foreground` default colors available to CLI apps, but it's usually easiest to just refer to the 16-color table.

claunia commented

@ghost commented on GitHub (Feb 28, 2023):

I guess its easier to show :

when i set the background dark vim uses a different colors, for the "dark" default

As you can see if i set the bring yellow to geeen i can force whatever color i want.

The issue is that with the default "light" theme this is a brown color, so i expect the windows terminal to either pick once of my colors or not be able to display the color at all.

I dont expect it to be able to render "brown" but not let me change it.

@ghost commented on GitHub (Feb 28, 2023): I guess its easier to show : when i set the background dark vim uses a different colors, for the "dark" default ![image](https://user-images.githubusercontent.com/107933013/221946892-a1f127ef-3e1a-4f0d-8624-58d614f90776.png) As you can see if i set the bring yellow to geeen i can force whatever color i want. ![image](https://user-images.githubusercontent.com/107933013/221947149-7054d15b-c14d-4718-8ffb-c4fec10c28ce.png) The issue is that with the default "light" theme this is a brown color, so i expect the windows terminal to either pick once of my colors or not be able to display the color at all. I dont expect it to be able to render "brown" but not let me change it.

claunia commented

@ghost commented on GitHub (Feb 28, 2023):

Or what am i saying is I want to use use only the colors I have defined to display everything.

@ghost commented on GitHub (Feb 28, 2023): Or what am i saying is I want to use use only the colors I have defined to display everything.

claunia commented

@zadjii-msft commented on GitHub (Feb 28, 2023):

If you execute :colo in vim, what does it display as the name of the vim color scheme?

@zadjii-msft commented on GitHub (Feb 28, 2023): If you execute `:colo` in `vim`, what does it display as the name of the vim color scheme?

claunia commented

@ghost commented on GitHub (Feb 28, 2023):

its default im not setting a color scheme on purpose, so i can use my terminal colors.

@ghost commented on GitHub (Feb 28, 2023): its default im not setting a color scheme on purpose, so i can use my terminal colors.

claunia commented

@ghost commented on GitHub (Feb 28, 2023):

Again this is not related to vim at all, its about how microsoft terminal renders colors.

@ghost commented on GitHub (Feb 28, 2023): Again this is not related to vim at all, its about how microsoft terminal renders colors.

claunia commented

@DHowett commented on GitHub (Feb 28, 2023):

Again this is not related to vim at all, its about how microsoft terminal renders colors.

Colors in CLI applications are a little weird. Either an app can say

"I want one of the 16 colors of the color table"

"I want one of the 256 predefined colors"

"I want an RGB color"

Terminal can't change the second two sets of colors.

emphasis mine

We're asking because we want to determine what kind of colors you're reporting that Terminal renders incorrectly.

@DHowett commented on GitHub (Feb 28, 2023): > Again this is not related to vim at all, its about how microsoft terminal renders colors. --- > Colors in CLI applications are a little weird. Either an app can say > * "I want one of the 16 colors of the color table" > * "I want one of the 256 predefined colors" > * "I want an RGB color" > > **Terminal can't change the second two sets of colors.** _emphasis mine_ --- We're asking because we want to determine what kind of colors you're reporting that Terminal renders incorrectly.

claunia commented

@zadjii-msft commented on GitHub (Feb 28, 2023):

There's also https://askubuntu.com/a/24548

If you are on a light terminal, the default is peachpuff.

If you are on a dark terminal, the default is ron.

You can tell which you have by typing :set background?.

(Vim guesses whether your terminal has a dark or light background based on the value of the TERM environment variable.)

I found this answer by going ":color Tab" and choosing each option, then comparing it to the default.

@zadjii-msft commented on GitHub (Feb 28, 2023): There's also https://askubuntu.com/a/24548 > If you are on a light terminal, the default is `peachpuff`. > > If you are on a dark terminal, the default is `ron`. > > You can tell which you have by typing `:set background?`. > > (Vim guesses whether your terminal has a dark or light background based on the value of the `TERM` environment variable.) > > I found this answer by going "`:color` <kbd>Tab</kbd>" and choosing each option, then comparing it to the default.

claunia commented