starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Quake Mode doesn't render sample Outlines.hlsl Pixel Shader correctly #19488

New Issue
Closed
opened 2026-01-31 06:44:51 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 06:44:51 +00:00
Owner
Copy Link

Originally created by @HoloWise on GitHub (Mar 5, 2023).

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22621.1325

Other Software

No response

Steps to reproduce

Apply sample Outlines.hlsl Pixel Shader using experimental.pixelShaderPath setting
Open regular Terminal window
Open Terminal in Quake mode
Observe the issue

Expected Behavior

Sample pixel shader is drawn the same way in both windows

Actual Behavior

Pixel Shader breaks in Quake mode

Regular Terminal window:
image

Quake Mode view
image

Originally created by @HoloWise on GitHub (Mar 5, 2023). ### Windows Terminal version 1.16.10262.0 ### Windows build number 10.0.22621.1325 ### Other Software _No response_ ### Steps to reproduce Apply sample [Outlines.hlsl Pixel Shader](https://github.com/microsoft/terminal/blob/main/samples/PixelShaders/Outlines.hlsl) using [experimental.pixelShaderPath setting](https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-appearance#pixel-shader-effects) Open regular Terminal window Open Terminal in Quake mode Observe the issue ### Expected Behavior Sample pixel shader is drawn the same way in both windows ### Actual Behavior Pixel Shader breaks in Quake mode Regular Terminal window: ![image](https://user-images.githubusercontent.com/36460595/222972671-ec693acf-5e0d-4775-8b2c-a4079a2b49d6.png) Quake Mode view ![image](https://user-images.githubusercontent.com/36460595/222972722-6f1576b0-7557-4ce2-9a66-ff8bdd650971.png)
claunia added the Area-RenderingIssue-BugIn-PRNeeds-Tag-FixProduct-Terminal labels 2026-01-31 06:44:51 +00:00
claunia commented 2026-01-31 06:44:53 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Mar 8, 2023):

Hi @HoloWise! This seems to be an issue with our implementation of the Outlines.hlsl shader, so we'd be happy to update our demo with one that works better. If you have any expertise in HLSL, we would love your help.

@carlos-zamora commented on GitHub (Mar 8, 2023): Hi @HoloWise! This seems to be an issue with our implementation of the Outlines.hlsl shader, so we'd be happy to update our demo with one that works better. If you have any expertise in HLSL, we would love your help.
claunia commented 2026-01-31 06:44:53 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Mar 9, 2023):

I gave it a shot, but the result might not be exactly what you're looking for. If you could try out the new Outlines.hlsl from my PR (https://github.com/microsoft/terminal/pull/14971) and leave a comment, that'd be great!

@lhecker commented on GitHub (Mar 9, 2023): I gave it a shot, but the result might not be exactly what you're looking for. If you could try out the new Outlines.hlsl from my PR (https://github.com/microsoft/terminal/pull/14971) and leave a comment, that'd be great!
claunia commented 2026-01-31 06:44:54 +00:00
Author
Owner
Copy Link

@HoloWise commented on GitHub (Mar 9, 2023):

@lhecker This is looking great. Just gave it a go and it renders as expected in Quake mode.

obraz

If you go pixel peeping it seems to be missing some of the outline around sharper edges of letters due to +2 offset increments. Incrementing y offset by 1 seems to eliminate most instances while incrementing both by 1 seems to get rid of those completely. (but obviously requires more processing and makes outline more pronounced)

obraz

@HoloWise commented on GitHub (Mar 9, 2023): @lhecker This is looking great. Just gave it a go and it renders as expected in Quake mode. ![obraz](https://user-images.githubusercontent.com/36460595/224091451-bcb3b7b8-e03a-405f-89c3-1279ac16c0b4.png) If you go pixel peeping it seems to be missing some of the outline around sharper edges of letters due to +2 offset increments. Incrementing y offset by 1 seems to eliminate most instances while incrementing both by 1 seems to get rid of those completely. (but obviously requires more processing and makes outline more pronounced) ![obraz](https://user-images.githubusercontent.com/36460595/224105678-6766e4a1-78fd-4be5-af16-004ab7778eba.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering In-PR Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?