starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Finish the SSH profile generator #19546

New Issue
Closed
opened 2026-01-31 06:46:45 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 06:46:45 +00:00
Owner
Copy Link

Originally created by @McLavish on GitHub (Mar 17, 2023).

maintainer note: hijacking OP to put tasks in here

Originally tracked in #9031
Added in #14042

### Tasks
- [ ] https://github.com/MicrosoftDocs/terminal/issues/641
- [ ] Fix issues that @DHowett found in the parser
- [ ] Something about making the SUI UX easier to use, disable?

Windows Terminal version

1.17.1023

Windows build number

10.0.22621.1413

Other Software

OpenSSH_for_Windows_8.6p1
LibreSSL 3.4.3

Steps to reproduce

  1. Install Windows Terminal (Preview) through the Microsoft Store
  2. Install the OpenSSH client from Windows Optional Features
  3. Create a user OpenSSH config file under %userprofile%.ssh\config:
Host myhost  
    HostName something.domain.com  
    User myuser  
    IdentityFile "C:\Users\myuser\myfolder\id_rsa"
  1. (Optional) Add "disabledProfileSources" : [ ], to settings.json
  2. Open Windows Terminal (Preview)

Note: It appears adding "disabledProfileSources" : [ "Windows.Terminal.SSH" ], produces a Value not accepted warning in VsCode as it's not listed in the profiles schema DynamicProfileSource enum.
bug

Expected Behavior

Docs says that "Windows Terminal version 1.XX+ can dynamically generate profiles to connect to the SSH hosts within your OpenSSH config file"

Actual Behavior

Nothing happens

Originally created by @McLavish on GitHub (Mar 17, 2023). _maintainer note: hijacking OP to put tasks in here_ Originally tracked in #9031 Added in #14042 ```[tasklist] ### Tasks - [ ] https://github.com/MicrosoftDocs/terminal/issues/641 - [ ] Fix issues that @DHowett found in the parser - [ ] Something about making the SUI UX easier to use, disable? ``` <hr> ### Windows Terminal version 1.17.1023 ### Windows build number 10.0.22621.1413 ### Other Software OpenSSH_for_Windows_8.6p1 LibreSSL 3.4.3 ### Steps to reproduce 1. Install Windows Terminal (Preview) through the Microsoft Store 2. Install the OpenSSH client from Windows Optional Features 3. Create a user OpenSSH config file under %userprofile%\.ssh\config: ``` Host myhost HostName something.domain.com User myuser IdentityFile "C:\Users\myuser\myfolder\id_rsa" ``` 5. (Optional) Add "disabledProfileSources" : [ ], to settings.json 6. Open Windows Terminal (Preview) Note: It appears adding "disabledProfileSources" : [ "Windows.Terminal.SSH" ], produces a Value not accepted warning in VsCode as it's not listed in the profiles schema ![DynamicProfileSource](https://github.com/microsoft/terminal/blob/main/doc/cascadia/profiles.schema.json) enum. ![bug](https://user-images.githubusercontent.com/32342099/225904232-c1d4db80-0b7e-45f1-b88b-e6c75e1cf2bf.png) ### Expected Behavior Docs says that "Windows Terminal version 1.XX+ can dynamically generate profiles to connect to the SSH hosts within your OpenSSH config file" ### Actual Behavior Nothing happens
claunia commented 2026-01-31 06:46:47 +00:00
Author
Owner
Copy Link

@elsaco commented on GitHub (Mar 18, 2023):

@McLavish the feature might not be enabled, yet. See details at;

b9248fa903/src/features.xml (L141-L146)

You could enable it using a branding token and build the terminal. I use dev token and it does generate an SSH profile:

wt_ssh_profile

To my surprise clicking on that profile opened a SSH connection to a Pi4 box, no errors!

@elsaco commented on GitHub (Mar 18, 2023): @McLavish the feature might not be enabled, yet. See details at; https://github.com/microsoft/terminal/blob/b9248fa903eaa8d187c72bf08f8aa17b25f9d6bb/src/features.xml#L141-L146 You could enable it using a branding token and build the terminal. I use `dev` token and it does generate an SSH profile: ![wt_ssh_profile](https://user-images.githubusercontent.com/3933920/226074025-26166595-9531-4aed-ad09-9ffe52aa01de.png) To my surprise clicking on that profile opened a SSH connection to a Pi4 box, no errors!
claunia commented 2026-01-31 06:46:47 +00:00
Author
Owner
Copy Link

@McLavish commented on GitHub (Mar 18, 2023):

@elsaco I guess you're right but then it shouldn't be listed as a feature in the windows terminal docs

image

@McLavish commented on GitHub (Mar 18, 2023): @elsaco I guess you're right but then it shouldn't be listed as a feature in the [windows terminal docs](https://learn.microsoft.com/en-us/windows/terminal/tutorials/ssh) ![image](https://user-images.githubusercontent.com/32342099/226124041-b3f9ca3f-2489-4ff1-8157-17cb6e585fab.png)
claunia commented 2026-01-31 06:46:48 +00:00
Author
Owner
Copy Link

@nguyen-dows commented on GitHub (Mar 22, 2023):

@McLavish I agree. There is already been an issue made to get this removed from the docs page which I've assigned myself too: https://github.com/MicrosoftDocs/terminal/issues/641

Thanks for including the screenshot and link to the doc!

@nguyen-dows commented on GitHub (Mar 22, 2023): @McLavish I agree. There is already been an issue made to get this removed from the docs page which I've assigned myself too: https://github.com/MicrosoftDocs/terminal/issues/641 Thanks for including the screenshot and link to the doc!
claunia commented 2026-01-31 06:46:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 22, 2023):

You know what, good callout. We should remove this from the docs until we ship this. Clearly our docs need some love 😅

I'm gonna hijack your OP to track the rest of the work needed to get this across the finish line.

@zadjii-msft commented on GitHub (Mar 22, 2023): You know what, good callout. We should remove this from the docs until we ship this. Clearly our docs need some love 😅 I'm gonna hijack your OP to track the rest of the work needed to get this across the finish line.
claunia commented 2026-01-31 06:46:48 +00:00
Author
Owner
Copy Link

@rmdes commented on GitHub (Dec 7, 2023):

Any chance this is working now ?

@rmdes commented on GitHub (Dec 7, 2023): Any chance this is working now ?
claunia commented 2026-01-31 06:46:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 7, 2023):

Nope. The issue is still open. We haven't really had the time to loop back around on this one. We'd love the help if you're interested though!

@zadjii-msft commented on GitHub (Dec 7, 2023): Nope. The issue is still open. We haven't really had the time to loop back around on this one. We'd love the help if you're interested though!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#19546
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?